From: Jan Beulich <jbeulich@suse.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"hch@lst.de" <hch@lst.de>, Konrad Wilk <konrad.wilk@oracle.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: [PATCH v2 2/4] PCI: only build xen-pcifront in PV-enabled environments
Date: Fri, 17 Sep 2021 12:48:03 +0200 [thread overview]
Message-ID: <3a7f6c9b-215d-b593-8056-b5fe605dafd7@suse.com> (raw)
In-Reply-To: <164e58ff-2edd-2c99-ac3d-e18eb06ff731@suse.com>
The driver's module init function, pcifront_init(), invokes
xen_pv_domain() first thing. That construct produces constant "false"
when !CONFIG_XEN_PV. Hence there's no point building the driver in
non-PV configurations.
Drop the (now implicit and generally wrong) X86 dependency: At present,
XEN_PV con only be set when X86 is also enabled. In general an
architecture supporting Xen PV (and PCI) would want to have this driver
built.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2: Title and description redone.
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -110,7 +110,7 @@ config PCI_PF_STUB
config XEN_PCIDEV_FRONTEND
tristate "Xen PCI Frontend"
- depends on X86 && XEN
+ depends on XEN_PV
select PCI_XEN
select XEN_XENBUS_FRONTEND
default y
WARNING: multiple messages have this Message-ID (diff)
From: Jan Beulich via iommu <iommu@lists.linux-foundation.org>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Konrad Wilk <konrad.wilk@oracle.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"hch@lst.de" <hch@lst.de>
Subject: [PATCH v2 2/4] PCI: only build xen-pcifront in PV-enabled environments
Date: Fri, 17 Sep 2021 12:48:03 +0200 [thread overview]
Message-ID: <3a7f6c9b-215d-b593-8056-b5fe605dafd7@suse.com> (raw)
In-Reply-To: <164e58ff-2edd-2c99-ac3d-e18eb06ff731@suse.com>
The driver's module init function, pcifront_init(), invokes
xen_pv_domain() first thing. That construct produces constant "false"
when !CONFIG_XEN_PV. Hence there's no point building the driver in
non-PV configurations.
Drop the (now implicit and generally wrong) X86 dependency: At present,
XEN_PV con only be set when X86 is also enabled. In general an
architecture supporting Xen PV (and PCI) would want to have this driver
built.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
---
v2: Title and description redone.
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -110,7 +110,7 @@ config PCI_PF_STUB
config XEN_PCIDEV_FRONTEND
tristate "Xen PCI Frontend"
- depends on X86 && XEN
+ depends on XEN_PV
select PCI_XEN
select XEN_XENBUS_FRONTEND
default y
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-09-17 10:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 10:43 [PATCH v2 0/4] swiotlb-xen: remaining fixes and adjustments Jan Beulich
2021-09-17 10:43 ` Jan Beulich via iommu
2021-09-17 10:45 ` [PATCH v2 1/4] swiotlb-xen: ensure to issue well-formed XENMEM_exchange requests Jan Beulich
2021-09-17 10:45 ` Jan Beulich via iommu
2021-09-17 20:04 ` Stefano Stabellini
2021-09-17 20:04 ` Stefano Stabellini
2021-09-17 20:04 ` Stefano Stabellini
2021-09-17 10:48 ` Jan Beulich [this message]
2021-09-17 10:48 ` [PATCH v2 2/4] PCI: only build xen-pcifront in PV-enabled environments Jan Beulich via iommu
2021-09-17 16:28 ` Bjorn Helgaas
2021-09-17 16:28 ` Bjorn Helgaas
2021-09-17 10:49 ` [PATCH v2 3/4] xen/pci-swiotlb: reduce visibility of symbols Jan Beulich
2021-09-17 10:49 ` Jan Beulich via iommu
2021-09-17 10:50 ` [PATCH v2 4/4] swiotlb-xen: this is PV-only on x86 Jan Beulich
2021-09-17 10:50 ` Jan Beulich via iommu
2021-09-20 15:19 ` [PATCH v2 0/4] swiotlb-xen: remaining fixes and adjustments Juergen Gross
2021-09-20 15:19 ` Juergen Gross via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a7f6c9b-215d-b593-8056-b5fe605dafd7@suse.com \
--to=jbeulich@suse.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.