All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Young <sean@mess.org>
To: linux-media@vger.kernel.org, "Matthias Reichl" <hias@horus.com>,
	"Juan Jesús García de Soria" <skandalfo@gmail.com>
Subject: [PATCH 4/6] media: ite-cir: carrier and duty cycle can be set via ioctl
Date: Mon, 22 Feb 2021 10:43:27 +0000	[thread overview]
Message-ID: <3cbd3f7f50d64bae20ae4f583a0402956e1c8591.1613989288.git.sean@mess.org> (raw)
In-Reply-To: <cover.1613989288.git.sean@mess.org>

The lirc ioctls should be used for this, not module parameters.

Signed-off-by: Sean Young <sean@mess.org>
---
 drivers/media/rc/ite-cir.c | 32 --------------------------------
 1 file changed, 32 deletions(-)

diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
index c5c7631849d0..748788a43da5 100644
--- a/drivers/media/rc/ite-cir.c
+++ b/drivers/media/rc/ite-cir.c
@@ -33,26 +33,6 @@
 
 /* module parameters */
 
-/* low limit for RX carrier freq, Hz, 0 for no RX demodulation */
-static int rx_low_carrier_freq;
-module_param(rx_low_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(rx_low_carrier_freq, "Override low RX carrier frequency, Hz, 0 for no RX demodulation");
-
-/* high limit for RX carrier freq, Hz, 0 for no RX demodulation */
-static int rx_high_carrier_freq;
-module_param(rx_high_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(rx_high_carrier_freq, "Override high RX carrier frequency, Hz, 0 for no RX demodulation");
-
-/* override tx carrier frequency */
-static int tx_carrier_freq;
-module_param(tx_carrier_freq, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(tx_carrier_freq, "Override TX carrier frequency, Hz");
-
-/* override tx duty cycle */
-static int tx_duty_cycle;
-module_param(tx_duty_cycle, int, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(tx_duty_cycle, "Override TX duty cycle, 1-100");
-
 /* override default sample period */
 static long sample_period;
 module_param(sample_period, long, S_IRUGO | S_IWUSR);
@@ -1410,18 +1390,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
 	if (sample_period > 0)
 		itdev->params.sample_period = sample_period;
 
-	if (tx_carrier_freq > 0)
-		itdev->params.tx_carrier_freq = tx_carrier_freq;
-
-	if (tx_duty_cycle > 0 && tx_duty_cycle <= 100)
-		itdev->params.tx_duty_cycle = tx_duty_cycle;
-
-	if (rx_low_carrier_freq > 0)
-		itdev->params.rx_low_carrier_freq = rx_low_carrier_freq;
-
-	if (rx_high_carrier_freq > 0)
-		itdev->params.rx_high_carrier_freq = rx_high_carrier_freq;
-
 	/* set up hardware initial state */
 	itdev->params.init_hardware(itdev);
 
-- 
2.29.2


  parent reply	other threads:[~2021-02-22 10:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 10:43 [PATCH 0/6] media: ite-cir driver cleanups Sean Young
2021-02-22 10:43 ` [PATCH 1/6] media: ite-cir: remove unused fields Sean Young
2021-02-22 10:43 ` [PATCH 2/6] media: ite-cir: set parent device Sean Young
2021-02-22 10:43 ` [PATCH 3/6] media: ite-cir: use standard logging and reduce noise Sean Young
2021-02-22 10:43 ` Sean Young [this message]
2021-02-22 10:43 ` [PATCH 5/6] media: ite-cir: move runtime information into driver data Sean Young
2021-02-22 10:43 ` [PATCH 6/6] media: ite-cir: check for receive overflow Sean Young
2021-02-23 16:13 ` [PATCH 0/6] media: ite-cir driver cleanups Matthias Reichl
2021-02-23 17:50   ` Sean Young
2021-02-23 19:16     ` Matthias Reichl
2021-02-24  9:57       ` Sean Young
2021-02-26 13:57         ` Matthias Reichl
2021-03-01 10:42           ` Sean Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cbd3f7f50d64bae20ae4f583a0402956e1c8591.1613989288.git.sean@mess.org \
    --to=sean@mess.org \
    --cc=hias@horus.com \
    --cc=linux-media@vger.kernel.org \
    --cc=skandalfo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.