From: Mason <slash.tmp@free.fr>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Russell King <rmk@armlinux.org.uk>,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
arm-soc <arm@kernel.org>, Emilio Lopez <emilio@elopez.com.ar>,
dmaengine@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>
Subject: [PATCH v2] dmaengine: sun4i: fix invalid argument
Date: Fri, 21 Apr 2017 10:43:20 +0200 [thread overview]
Message-ID: <3e98596a-0322-e4f1-7cc2-9b0eaceb4465@free.fr> (raw)
In-Reply-To: <20170421082417.7cqtevwuhjvfgjcx@lukather>
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
The "pchans_used" field is an unsigned long array.
for_each_clear_bit_from() expects an unsigned long pointer,
not an array address.
$ make C=2 drivers/dma/sun4i-dma.o
CHECK drivers/dma/sun4i-dma.c
drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types)
drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p
drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1]
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
drivers/dma/sun4i-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 57aa227bfadb..f4ed3f17607c 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv,
}
spin_lock_irqsave(&priv->lock, flags);
- for_each_clear_bit_from(i, &priv->pchans_used, max) {
+ for_each_clear_bit_from(i, priv->pchans_used, max) {
pchan = &pchans[i];
pchan->vchan = vchan;
set_bit(i, priv->pchans_used);
--
3.14159
WARNING: multiple messages have this Message-ID (diff)
From: slash.tmp@free.fr (Mason)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] dmaengine: sun4i: fix invalid argument
Date: Fri, 21 Apr 2017 10:43:20 +0200 [thread overview]
Message-ID: <3e98596a-0322-e4f1-7cc2-9b0eaceb4465@free.fr> (raw)
In-Reply-To: <20170421082417.7cqtevwuhjvfgjcx@lukather>
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
The "pchans_used" field is an unsigned long array.
for_each_clear_bit_from() expects an unsigned long pointer,
not an array address.
$ make C=2 drivers/dma/sun4i-dma.o
CHECK drivers/dma/sun4i-dma.c
drivers/dma/sun4i-dma.c:241:9: warning: incorrect type in argument 1 (different base types)
drivers/dma/sun4i-dma.c:241:9: expected unsigned long const *p
drivers/dma/sun4i-dma.c:241:9: got unsigned long ( *<noident> )[1]
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
---
drivers/dma/sun4i-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c
index 57aa227bfadb..f4ed3f17607c 100644
--- a/drivers/dma/sun4i-dma.c
+++ b/drivers/dma/sun4i-dma.c
@@ -238,7 +238,7 @@ static struct sun4i_dma_pchan *find_and_use_pchan(struct sun4i_dma_dev *priv,
}
spin_lock_irqsave(&priv->lock, flags);
- for_each_clear_bit_from(i, &priv->pchans_used, max) {
+ for_each_clear_bit_from(i, priv->pchans_used, max) {
pchan = &pchans[i];
pchan->vchan = vchan;
set_bit(i, priv->pchans_used);
--
3.14159
next prev parent reply other threads:[~2017-04-21 8:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 22:40 linux-next: build failure after merge of the arm tree Stephen Rothwell
2017-04-21 7:58 ` Mason
2017-04-21 7:58 ` Mason
2017-04-21 8:06 ` [PATCH] dmaengine: sun4i: fix invalid argument Mason
2017-04-21 8:06 ` Mason
2017-04-21 8:24 ` Maxime Ripard
2017-04-21 8:24 ` Maxime Ripard
2017-04-21 8:24 ` Maxime Ripard
2017-04-21 8:43 ` Mason [this message]
2017-04-21 8:43 ` [PATCH v2] " Mason
2017-04-21 14:40 ` Maxime Ripard
2017-04-21 14:40 ` Maxime Ripard
2017-04-21 14:40 ` Maxime Ripard
2017-04-21 8:12 ` linux-next: build failure after merge of the arm tree Stephen Rothwell
2017-04-21 8:12 ` Stephen Rothwell
2017-04-21 8:30 ` Mason
2017-04-21 8:30 ` Mason
2017-04-21 23:43 ` Russell King - ARM Linux
2017-04-21 23:43 ` Russell King - ARM Linux
2017-04-21 23:43 ` Russell King - ARM Linux
2017-04-22 8:41 ` Mason
2017-04-22 8:41 ` Mason
2017-04-22 8:41 ` Mason
2017-04-24 4:20 ` Vinod Koul
2017-04-24 4:20 ` Vinod Koul
2017-04-26 22:34 ` [PATCH v2] arm: bitops: Align prototypes to generic API Mason
2017-04-26 22:34 ` Mason
2017-06-14 19:23 ` linux-next: build failure after merge of the arm tree Mason
2017-06-14 19:23 ` Mason
2017-04-21 11:27 ` Mason
2017-04-21 11:27 ` Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e98596a-0322-e4f1-7cc2-9b0eaceb4465@free.fr \
--to=slash.tmp@free.fr \
--cc=arm@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=rmk@armlinux.org.uk \
--cc=sfr@canb.auug.org.au \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.