All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leigh Brown <leigh@solinno.co.uk>
To: balbi@ti.com
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: [PATCH] input: keypad: lm8323: use level triggered interrupts
Date: Mon, 20 Jun 2011 20:02:27 +0100	[thread overview]
Message-ID: <3f659cd53ac25c98701c2bb3a453ab06@doppler.thel33t.co.uk> (raw)
In-Reply-To: <20110620082605.GE14262@legolas.emea.dhcp.ti.com>

This patch, which should be applied on top of Felipe's
"input: keypad: lm8323: convert to threaded IRQ" patch, fixes the issue
of the Nokia N810 keypad stopping responding if multiple key events 
occur
in quick succession.

Signed-off-by: Leigh Brown <leigh@solinno.co.uk>
---
  drivers/input/keyboard/lm8323.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/input/keyboard/lm8323.c 
b/drivers/input/keyboard/lm8323.c
index 3b21f42..ab0acaf 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -734,7 +734,7 @@ static int __devinit lm8323_probe(struct i2c_client 
*client,
  	}

  	err = request_threaded_irq(client->irq, NULL, lm8323_irq,
-			  IRQF_TRIGGER_FALLING, "lm8323", lm);
+			  IRQF_TRIGGER_LOW|IRQF_ONESHOT, "lm8323", lm);
  	if (err) {
  		dev_err(&client->dev, "could not get IRQ %d\n", client->irq);
  		goto fail4;


  reply	other threads:[~2011-06-20 19:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-13 21:16 [PATCH] input: keypad: lm8323: convert to threaded IRQ Felipe Balbi
2011-06-19 19:00 ` Leigh Brown
2011-06-19 19:56   ` Felipe Balbi
2011-06-19 22:01     ` Leigh Brown
2011-06-20  8:26       ` Felipe Balbi
2011-06-20 19:02         ` Leigh Brown [this message]
2011-06-21 11:26           ` [PATCH] input: keypad: lm8323: use level triggered interrupts Dmitry Torokhov
2011-06-21 11:25 ` [PATCH] input: keypad: lm8323: convert to threaded IRQ Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f659cd53ac25c98701c2bb3a453ab06@doppler.thel33t.co.uk \
    --to=leigh@solinno.co.uk \
    --cc=balbi@ti.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.