All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakob Hauser <jahau@rocketmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	phone-devel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	Jakob Hauser <jahau@rocketmail.com>
Subject: [PATCH v6 01/14] iio: magnetometer: yas530: Change data type of hard_offsets to signed
Date: Fri, 12 Aug 2022 23:54:06 +0200	[thread overview]
Message-ID: <40f052bf6491457d0c5c0ed4c3534dc6fa251c3c.1660337264.git.jahau@rocketmail.com> (raw)
In-Reply-To: <cover.1660337264.git.jahau@rocketmail.com>

The "hard_offsets" are currently unsigned u8 but they should be signed as they
can get negative. They are signed in function yas5xx_meaure_offsets() and in the
Yamaha drivers [1][2].

[1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156
[2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91

Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530")
Signed-off-by: Jakob Hauser <jahau@rocketmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
 drivers/iio/magnetometer/yamaha-yas530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c
index aeaa4da6923b..d1f16729c60e 100644
--- a/drivers/iio/magnetometer/yamaha-yas530.c
+++ b/drivers/iio/magnetometer/yamaha-yas530.c
@@ -132,7 +132,7 @@ struct yas5xx {
 	unsigned int version;
 	char name[16];
 	struct yas5xx_calibration calibration;
-	u8 hard_offsets[3];
+	s8 hard_offsets[3];
 	struct iio_mount_matrix orientation;
 	struct regmap *map;
 	struct regulator_bulk_data regs[2];
-- 
2.35.1


  reply	other threads:[~2022-08-12 21:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1660337264.git.jahau.ref@rocketmail.com>
2022-08-12 21:54 ` [PATCH v6 00/14] Add support for magnetometer Yamaha YAS537 Jakob Hauser
2022-08-12 21:54   ` Jakob Hauser [this message]
2022-08-12 21:54   ` [PATCH v6 02/14] iio: magnetometer: yas530: Change range of data in volatile register Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 03/14] iio: magnetometer: yas530: Correct scaling of magnetic axes Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 04/14] iio: magnetometer: yas530: Correct temperature handling Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 05/14] iio: magnetometer: yas530: Change data type of calibration coefficients Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 06/14] iio: magnetometer: yas530: Rename functions and registers Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 07/14] iio: magnetometer: yas530: Move printk %*ph parameters out from stack Jakob Hauser
2022-08-13 19:57     ` Linus Walleij
2022-08-12 21:54   ` [PATCH v6 08/14] iio: magnetometer: yas530: Apply documentation and style fixes Jakob Hauser
2022-08-12 21:54   ` [PATCH v6 09/14] iio: magnetometer: yas530: Introduce "chip_info" structure Jakob Hauser
2022-08-13 19:58     ` Linus Walleij
2022-08-12 21:54   ` [PATCH v6 10/14] iio: magnetometer: yas530: Add volatile registers to "chip_info" Jakob Hauser
2022-08-13 19:58     ` Linus Walleij
2022-08-12 22:05   ` [PATCH v6 11/14] iio: magnetometer: yas530: Add IIO scaling " Jakob Hauser
2022-08-13 19:59     ` Linus Walleij
2022-08-12 22:05   ` [PATCH v6 12/14] iio: magnetometer: yas530: Add temperature calculation " Jakob Hauser
2022-08-13 19:59     ` Linus Walleij
2022-08-12 22:05   ` [PATCH v6 13/14] iio: magnetometer: yas530: Add function pointers " Jakob Hauser
2022-08-13 20:00     ` Linus Walleij
2022-08-12 22:05   ` [PATCH v6 14/14] iio: magnetometer: yas530: Add YAS537 variant Jakob Hauser
2022-08-14 16:54   ` [PATCH v6 00/14] Add support for magnetometer Yamaha YAS537 Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f052bf6491457d0c5c0ed4c3534dc6fa251c3c.1660337264.git.jahau@rocketmail.com \
    --to=jahau@rocketmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.