All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Suchanek <hramrach@gmail.com>
To: Mark Brown <broonie@kernel.org>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Michal Suchanek <hramrach@gmail.com>
Subject: [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver
Date: Tue, 19 Jul 2016 00:35:41 +0200	[thread overview]
Message-ID: <42e65e5c714f079cb4b85761e59fb700d4550a26.1468880530.git.hramrach@gmail.com> (raw)
In-Reply-To: <cover.1468880530.git.hramrach@gmail.com>
In-Reply-To: <cover.1468880530.git.hramrach@gmail.com>

SPI slave devices are not created when looking up driver for the slave
fails. Create a device anyway so it can be used with spidev.

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
 drivers/spi/spi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index f3ea768..f0de2ec 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1489,9 +1489,8 @@ of_register_spi_device(struct spi_master *master, struct device_node *nc)
 	rc = of_modalias_node(nc, spi->modalias,
 				sizeof(spi->modalias));
 	if (rc < 0) {
-		dev_err(&master->dev, "cannot find modalias for %s\n",
+		dev_warn(&master->dev, "cannot find modalias for %s\n",
 			nc->full_name);
-		goto err_out;
 	}
 
 	/* Device address */
-- 
2.8.1

  parent reply	other threads:[~2016-07-18 22:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-18 22:35 [PATCH v3 0/3] Spidev usability patchset update Michal Suchanek
2016-07-18 22:35 ` Michal Suchanek
2016-07-18 22:35 ` [PATCH v3 1/3] spi: spidev: create spidev device for all spi slaves Michal Suchanek
2016-07-18 22:59   ` Mark Brown
2016-07-18 22:59     ` Mark Brown
2016-07-19 11:17     ` Michal Suchanek
2016-07-19 11:17       ` Michal Suchanek
2016-07-19 12:44       ` Mark Brown
2016-07-19 15:32         ` Michal Suchanek
2016-07-19 17:19           ` Mark Brown
2016-07-19 17:19             ` Mark Brown
2016-07-19 18:33             ` Michal Suchanek
2016-07-19 18:33               ` Michal Suchanek
2016-07-27 18:27               ` Mark Brown
2016-07-20  7:16   ` [lkp] " Fengguang Wu
2016-07-20  7:16     ` Fengguang Wu
2016-07-18 22:35 ` Michal Suchanek [this message]
2016-07-18 23:02   ` [PATCH v3 2/3] spi: of: allow instantiating slaves without a driver Mark Brown
2016-07-18 23:02     ` Mark Brown
2016-07-19  8:31     ` Michal Suchanek
2016-07-19 10:52       ` Mark Brown
2016-07-30 17:45         ` Michal Suchanek
2016-07-30 17:45           ` Michal Suchanek
2016-07-18 22:35 ` [PATCH v3 3/3] spi: core: allow creating devices without spi-max-frequency Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42e65e5c714f079cb4b85761e59fb700d4550a26.1468880530.git.hramrach@gmail.com \
    --to=hramrach@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.