From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Bart Van Assche <bart.vanassche@sandisk.com>, "Nicholas A. Bellinger" <nab@linux-iscsi.org> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 4/5] target: Use kmalloc_array() in compare_and_write_callback() Date: Sun, 9 Apr 2017 21:51:43 +0200 [thread overview] Message-ID: <4629f13b-fd09-8d27-8cd4-3440f13207b0@users.sourceforge.net> (raw) In-Reply-To: <337dfdee-8a9f-9bb3-639a-ea47758966f1@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 9 Apr 2017 20:25:11 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/target/target_core_sbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index ee35c90e3b8d..a7fa4a7339db 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -519,8 +519,8 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd, bool succes goto out; } - write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents, - GFP_KERNEL); + write_sg = kmalloc_array(cmd->t_data_nents, sizeof(*write_sg), + GFP_KERNEL); if (!write_sg) { pr_err("Unable to allocate compare_and_write sg\n"); ret = TCM_OUT_OF_RESOURCES; -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Bart Van Assche <bart.vanassche@sandisk.com>, "Nicholas A. Bellinger" <nab@linux-iscsi.org> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 4/5] target: Use kmalloc_array() in compare_and_write_callback() Date: Sun, 09 Apr 2017 19:51:43 +0000 [thread overview] Message-ID: <4629f13b-fd09-8d27-8cd4-3440f13207b0@users.sourceforge.net> (raw) In-Reply-To: <337dfdee-8a9f-9bb3-639a-ea47758966f1@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 9 Apr 2017 20:25:11 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/target/target_core_sbc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index ee35c90e3b8d..a7fa4a7339db 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c @@ -519,8 +519,8 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd, bool succes goto out; } - write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents, - GFP_KERNEL); + write_sg = kmalloc_array(cmd->t_data_nents, sizeof(*write_sg), + GFP_KERNEL); if (!write_sg) { pr_err("Unable to allocate compare_and_write sg\n"); ret = TCM_OUT_OF_RESOURCES; -- 2.12.2
next prev parent reply other threads:[~2017-04-09 19:51 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-09 19:43 [PATCH 0/5] target: Fine-tuning for some function implementations SF Markus Elfring 2017-04-09 19:43 ` SF Markus Elfring 2017-04-09 19:46 ` [PATCH 1/5] target: Use kcalloc() in two functions SF Markus Elfring 2017-04-09 19:46 ` SF Markus Elfring 2017-04-09 19:47 ` [PATCH 2/5] target: Delete error messages for failed memory allocations SF Markus Elfring 2017-04-09 19:47 ` SF Markus Elfring 2017-04-09 19:50 ` [PATCH 3/5] target: Improve size determinations in two functions SF Markus Elfring 2017-04-09 19:50 ` SF Markus Elfring 2017-04-09 19:51 ` SF Markus Elfring [this message] 2017-04-09 19:51 ` [PATCH 4/5] target: Use kmalloc_array() in compare_and_write_callback() SF Markus Elfring 2017-04-09 19:53 ` [PATCH 5/5] target: Use kmalloc_array() in transport_kmap_data_sg() SF Markus Elfring 2017-04-09 19:53 ` SF Markus Elfring 2017-05-02 3:37 ` [PATCH 0/5] target: Fine-tuning for some function implementations Nicholas A. Bellinger 2017-05-02 3:37 ` Nicholas A. Bellinger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4629f13b-fd09-8d27-8cd4-3440f13207b0@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=bart.vanassche@sandisk.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=nab@linux-iscsi.org \ --cc=target-devel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.