All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Shkolnik <urishk@yahoo.com>
To: LinuxML <linux-media@vger.kernel.org>
Subject: [PATCH] [09051_54] Siano: remove obsolete sms_board_setup
Date: Tue, 19 May 2009 09:15:02 -0700 (PDT)	[thread overview]
Message-ID: <489128.99706.qm@web110801.mail.gq1.yahoo.com> (raw)


# HG changeset patch
# User Uri Shkolnik <uris@siano-ms.com>
# Date 1242749967 -10800
# Node ID 0296b0c436d6deba48c710cfb510988267cea057
# Parent  dfcfb90798d3a27cb174019b17fffdee9ce7b2b9
[09051_54] Siano: remove obsolete sms_board_setup

From: Uri Shkolnik <uris@siano-ms.com>

Remove the target specific sms_board_setup from smsdvb. This
is handled now via smsdvb and sms-cards events.

Priority: normal

Signed-off-by: Uri Shkolnik <uris@siano-ms.com>

diff -r dfcfb90798d3 -r 0296b0c436d6 linux/drivers/media/dvb/siano/sms-cards.c
--- a/linux/drivers/media/dvb/siano/sms-cards.c	Tue May 19 19:05:02 2009 +0300
+++ b/linux/drivers/media/dvb/siano/sms-cards.c	Tue May 19 19:19:27 2009 +0300
@@ -303,28 +303,6 @@ static int sms_set_gpio(struct smscore_d
 	return smscore_set_gpio(coredev, gpio, lvl);
 }
 
-int sms_board_setup(struct smscore_device_t *coredev)
-{
-	int board_id = smscore_get_board_id(coredev);
-	struct sms_board *board = sms_get_board(board_id);
-
-	switch (board_id) {
-	case SMS1XXX_BOARD_HAUPPAUGE_WINDHAM:
-		/* turn off all LEDs */
-		sms_set_gpio(coredev, board->led_power, 0);
-		sms_set_gpio(coredev, board->led_hi, 0);
-		sms_set_gpio(coredev, board->led_lo, 0);
-		break;
-	case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD_R2:
-	case SMS1XXX_BOARD_HAUPPAUGE_TIGER_MINICARD:
-		/* turn off LNA */
-		sms_set_gpio(coredev, board->lna_ctrl, 0);
-		break;
-	}
-	return 0;
-}
-EXPORT_SYMBOL_GPL(sms_board_setup);
-
 int sms_board_power(struct smscore_device_t *coredev, int onoff)
 {
 	int board_id = smscore_get_board_id(coredev);
diff -r dfcfb90798d3 -r 0296b0c436d6 linux/drivers/media/dvb/siano/sms-cards.h
--- a/linux/drivers/media/dvb/siano/sms-cards.h	Tue May 19 19:05:02 2009 +0300
+++ b/linux/drivers/media/dvb/siano/sms-cards.h	Tue May 19 19:19:27 2009 +0300
@@ -109,8 +109,6 @@ int sms_board_event(struct smscore_devic
 int sms_board_event(struct smscore_device_t *coredev,
 		enum SMS_BOARD_EVENTS gevent);
 
-int sms_board_setup(struct smscore_device_t *coredev);
-
 #define SMS_LED_OFF 0
 #define SMS_LED_LO  1
 #define SMS_LED_HI  2
diff -r dfcfb90798d3 -r 0296b0c436d6 linux/drivers/media/dvb/siano/smsdvb.c
--- a/linux/drivers/media/dvb/siano/smsdvb.c	Tue May 19 19:05:02 2009 +0300
+++ b/linux/drivers/media/dvb/siano/smsdvb.c	Tue May 19 19:19:27 2009 +0300
@@ -600,7 +600,6 @@ static int smsdvb_hotplug(struct smscore
 	sms_board_dvb3_event(client, DVB3_EVENT_HOTPLUG);
 
 	sms_info("success");
-	sms_board_setup(coredev);
 
 	return 0;
 



      

             reply	other threads:[~2009-05-19 16:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19 16:15 Uri Shkolnik [this message]
2009-05-19 16:31 ` [PATCH] [09051_54] Siano: remove obsolete sms_board_setup Michael Krufky
2009-05-19 16:59 Uri Shkolnik
     [not found] <675838.26148.qm@web110801.mail.gq1.yahoo.com>
2009-05-19 17:02 ` Michael Krufky
2009-05-19 17:09 Uri Shkolnik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489128.99706.qm@web110801.mail.gq1.yahoo.com \
    --to=urishk@yahoo.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.