All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: eben@raspberrypi.org, dri-devel@lists.freedesktop.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Eric Anholt <eric@anholt.net>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data
Date: Mon,  4 Mar 2019 15:52:35 +0100	[thread overview]
Message-ID: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> (raw)
In-Reply-To: <cover.39761cc6c9d070568123e328cd216367c4c660b4.1551711042.git-series.maxime.ripard@bootlin.com>

In some cases, in order to accomodate with displays with poor EDIDs, we
need to ignore that the monitor alledgedly supports audio output and
disable the audio output.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/gpu/drm/drm_edid.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 990b1909f9d7..c0258b011bb2 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edid)
 }
 EXPORT_SYMBOL(drm_detect_hdmi_monitor);
 
+static bool ignore_edid_audio = false;
+module_param(ignore_edid_audio, bool, 0644);
+MODULE_PARM_DESC(ignore_edid_audio,
+		 "Ignore the EDID and always consider that a monitor doesn't have audio capabilities");
+
 /**
  * drm_detect_monitor_audio - check monitor audio capability
  * @edid: EDID block to scan
@@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid)
 	bool has_audio = false;
 	int start_offset, end_offset;
 
+	if (ignore_edid_audio)
+		goto end;
+
 	edid_ext = drm_find_cea_extension(edid);
 	if (!edid_ext)
 		goto end;
-- 
git-series 0.9.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: eben@raspberrypi.org, dri-devel@lists.freedesktop.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data
Date: Mon,  4 Mar 2019 15:52:35 +0100	[thread overview]
Message-ID: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> (raw)
In-Reply-To: <cover.39761cc6c9d070568123e328cd216367c4c660b4.1551711042.git-series.maxime.ripard@bootlin.com>

In some cases, in order to accomodate with displays with poor EDIDs, we
need to ignore that the monitor alledgedly supports audio output and
disable the audio output.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 drivers/gpu/drm/drm_edid.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 990b1909f9d7..c0258b011bb2 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edid)
 }
 EXPORT_SYMBOL(drm_detect_hdmi_monitor);
 
+static bool ignore_edid_audio = false;
+module_param(ignore_edid_audio, bool, 0644);
+MODULE_PARM_DESC(ignore_edid_audio,
+		 "Ignore the EDID and always consider that a monitor doesn't have audio capabilities");
+
 /**
  * drm_detect_monitor_audio - check monitor audio capability
  * @edid: EDID block to scan
@@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid)
 	bool has_audio = false;
 	int start_offset, end_offset;
 
+	if (ignore_edid_audio)
+		goto end;
+
 	edid_ext = drm_find_cea_extension(edid);
 	if (!edid_ext)
 		goto end;
-- 
git-series 0.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-03-04 14:53 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 14:52 [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Maxime Ripard
2019-03-04 14:52 ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 1/7] drm/vc4: hdmi: Check that the monitor supports HDMI audio Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:10   ` Paul Kocialkowski
2019-03-04 15:10     ` Paul Kocialkowski
2019-03-04 15:54   ` Stefan Wahren
2019-03-04 15:54     ` Stefan Wahren
2019-03-04 18:28     ` Eric Anholt
2019-03-04 18:28       ` Eric Anholt
2019-03-04 20:06       ` Stefan Wahren
2019-03-04 20:06         ` Stefan Wahren
2019-03-04 21:09         ` Eric Anholt
2019-03-04 21:09           ` Eric Anholt
2019-03-04 14:52 ` Maxime Ripard [this message]
2019-03-04 14:52   ` [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data Maxime Ripard
2019-03-04 15:47   ` Jani Nikula
2019-03-04 15:47     ` Jani Nikula
2019-03-04 15:51     ` Adam Jackson
2019-03-04 15:51       ` Adam Jackson
2019-03-05  8:08     ` Maxime Ripard
2019-03-05  8:08       ` Maxime Ripard
2019-03-05 10:33       ` Jani Nikula
2019-03-05 10:33         ` Jani Nikula
2019-03-05 15:08       ` Adam Jackson
2019-03-05 15:08         ` Adam Jackson
2019-03-04 15:59   ` Ville Syrjälä
2019-03-04 15:59     ` Ville Syrjälä
2019-03-04 19:53   ` Eric Anholt
2019-03-04 19:53     ` Eric Anholt
2019-03-04 20:05     ` Alex Deucher
2019-03-04 20:05       ` Alex Deucher
2019-03-05  9:12       ` Maxime Ripard
2019-03-05  9:12         ` Maxime Ripard
2019-03-05 15:24         ` Ville Syrjälä
2019-03-05 15:24           ` Ville Syrjälä
2019-03-05 19:15           ` Ville Syrjälä
2019-03-05 19:15             ` Ville Syrjälä
2019-03-05 19:21             ` Alex Deucher
2019-03-05 19:36               ` Ville Syrjälä
2019-03-05 19:36                 ` Ville Syrjälä
2019-03-13 10:44                 ` Takashi Iwai
2019-03-13 10:44                   ` Takashi Iwai
2019-03-13 14:03                   ` Maxime Ripard
2019-03-13 14:03                     ` Maxime Ripard
2019-03-05 18:11         ` Eric Anholt
2019-03-05 18:11           ` Eric Anholt
2019-03-11 13:07           ` Daniel Vetter
2019-03-11 13:07             ` Daniel Vetter
2019-03-05 21:47         ` Eric Anholt
2019-03-05 21:47           ` Eric Anholt
2019-03-06  8:52           ` Maxime Ripard
2019-03-06  8:52             ` Maxime Ripard
2019-03-06 13:22           ` Maxime Ripard
2019-03-06 13:22             ` Maxime Ripard
2019-03-06 17:51             ` Eric Anholt
2019-03-06 17:51               ` Eric Anholt
2019-03-04 14:52 ` [PATCH 3/7] drm/edid: Allow to ignore the HDMI monitor mode Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:14   ` Paul Kocialkowski
2019-03-04 15:14     ` Paul Kocialkowski
2019-03-04 15:48   ` Jani Nikula
2019-03-04 15:48     ` Jani Nikula
2019-03-04 20:02   ` Eric Anholt
2019-03-04 20:02     ` Eric Anholt
2019-03-05  9:24     ` Maxime Ripard
2019-03-05  9:24       ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 4/7] drm/modes: Rewrite the command line parser Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 5/7] drm/modes: Support modes names on the command line Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 6/7] drm/modes: Allow to specify rotation and reflection on the commandline Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 14:52 ` [PATCH 7/7] drm/modes: Parse overscan properties Maxime Ripard
2019-03-04 14:52   ` Maxime Ripard
2019-03-04 15:21 ` [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Peter Stuge
2019-03-04 15:21   ` Peter Stuge
2019-03-04 15:56   ` Maxime Ripard
2019-03-04 15:56     ` Maxime Ripard
2019-03-04 15:44 ` Stefan Wahren
2019-03-04 15:44   ` Stefan Wahren
2019-03-04 20:06 ` Eric Anholt
2019-03-04 20:06   ` Eric Anholt
2019-03-05  9:14   ` Maxime Ripard
2019-03-05  9:14     ` Maxime Ripard
2019-03-11 13:00     ` Daniel Vetter
2019-03-11 13:00       ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com \
    --to=maxime.ripard@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eben@raspberrypi.org \
    --cc=eric@anholt.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=seanpaul@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.