All of lore.kernel.org
 help / color / mirror / Atom feed
From: vathsala nagaraju <vathsala.nagaraju@intel.com>
To: intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com
Cc: Yaroslav Shabalin <yaroslav.shabalin@gmail.com>
Subject: [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20
Date: Thu, 25 May 2017 22:13:29 +0530	[thread overview]
Message-ID: <49935bdff896ee3140bed471012b9f9110a863a4.1495729964.git.vathsala.nagaraju@intel.com> (raw)
In-Reply-To: <1495558657-32130-1-git-send-email-vathsala.nagaraju@intel.com>

psr1 is also disabled for panel resolution  greater than 32X20.
Added psr2 check to disable only for psr2 panels having resolution
greater than 32X20.

issue was introduced by
commit-id : "acf45d11050abd751dcec986ab121cb2367dcbba"
commit message: "PSR2 is restricted to work with panel resolutions
upto 3200x2000, move the check to intel_psr_match_conditions and fully
block psr."

v2: (Rodrigo)
   Add previous commit details which introduced the issue

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jim Bride <jim.bride@linux.intel.com>
Cc: Yaroslav Shabalin <yaroslav.shabalin@gmail.com>
Reported-by: Yaroslav Shabalin <yaroslav.shabalin@gmail.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: vathsala nagaraju <vathsala.nagaraju@intel.com>
---
 drivers/gpu/drm/i915/intel_psr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
index c3780d0..559f1ab 100644
--- a/drivers/gpu/drm/i915/intel_psr.c
+++ b/drivers/gpu/drm/i915/intel_psr.c
@@ -435,8 +435,9 @@ static bool intel_psr_match_conditions(struct intel_dp *intel_dp)
 	}
 
 	/* PSR2 is restricted to work with panel resolutions upto 3200x2000 */
-	if (intel_crtc->config->pipe_src_w > 3200 ||
-				intel_crtc->config->pipe_src_h > 2000) {
+	if (dev_priv->psr.psr2_support &&
+	    (intel_crtc->config->pipe_src_w > 3200 ||
+	     intel_crtc->config->pipe_src_h > 2000)) {
 		dev_priv->psr.psr2_support = false;
 		return false;
 	}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-05-25 16:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 16:57 [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20 vathsala nagaraju
2017-05-23 17:14 ` ✓ Fi.CI.BAT: success for drm/i915/psr: disable psr2 for resolution greater than 32X20 (rev2) Patchwork
2017-05-23 18:17 ` [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20 Vivi, Rodrigo
2017-05-24 11:54   ` Jani Nikula
2017-05-23 19:27 ` ✓ Fi.CI.BAT: success for drm/i915/psr: disable psr2 for resolution greater than 32X20 (rev2) Patchwork
2017-05-24  5:31   ` Saarinen, Jani
2017-05-24  9:27 ` Patchwork
2017-05-25 16:43 ` vathsala nagaraju [this message]
2017-05-26 19:10   ` [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20 Rodrigo Vivi
2017-05-29  8:24     ` Jani Nikula
2017-05-30 17:45       ` Rodrigo Vivi
2017-05-25 17:00 ` ✓ Fi.CI.BAT: success for drm/i915/psr: disable psr2 for resolution greater than 32X20 (rev3) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2017-05-23  9:14 [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20 Yaroslav Shabalin
2017-05-23  9:24 ` Nagaraju, Vathsala
2017-05-22 23:28 Yaroslav Shabalin
2017-05-23 10:01 ` Nagaraju, Vathsala
2017-01-10  7:02 vathsala nagaraju
2017-01-10 20:48 ` Vivi, Rodrigo
2017-01-10 23:44   ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49935bdff896ee3140bed471012b9f9110a863a4.1495729964.git.vathsala.nagaraju@intel.com \
    --to=vathsala.nagaraju@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=yaroslav.shabalin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.