From: Jes Sorensen <jes@sgi.com> To: Sheng Yang <sheng@linux.intel.com> Cc: Avi Kivity <avi@redhat.com>, "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "Zhang, Xiantao" <xiantao.zhang@intel.com> Subject: KVM build breakage Date: Tue, 24 Feb 2009 17:24:54 +0100 [thread overview] Message-ID: <49A41F56.3030705@sgi.com> (raw) [-- Attachment #1: Type: text/plain, Size: 2121 bytes --] Hi, A snapshot of Avi's tree as of today breaks on ia64. Looks like it is the recent MSI support that caused this. Sheng Yang, please make sure to test on non x86 when you implement things like these that clearly will only build on x86. This patch boots on ia64 for me. Thanks, Jes CC arch/ia64/kvm/../../../virt/kvm/irq_comm.o arch/ia64/kvm/../../../virt/kvm/irq_comm.c: In function 'kvm_set_msi': arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: 'MSI_ADDR_DEST_ID_MASK' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: (Each undeclared identifier is reported only once arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: for each function it appears in.) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:55: error: 'MSI_ADDR_DEST_ID_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:56: error: 'MSI_DATA_VECTOR_MASK' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:57: error: 'MSI_DATA_VECTOR_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:58: error: 'MSI_ADDR_DEST_MODE_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:60: error: 'MSI_DATA_TRIGGER_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:62: error: 'MSI_DATA_DELIVERY_MODE_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:76: error: implicit declaration of function 'kvm_apic_set_irq' make[1]: *** [arch/ia64/kvm/../../../virt/kvm/irq_comm.o] Error 1 make: *** [arch/ia64/kvm] Error 2 commit e4caaecb2fa206ee513756fe17593d7b3334be7b Author: Sheng Yang <sheng@linux.intel.com> Date: Tue Feb 10 13:57:06 2009 +0800 KVM: Use irq routing API for MSI Merge MSI userspace interface with IRQ routing table. Notice the API have been changed, and using IRQ routing table would be the only interface kvm-userspace supported. Signed-off-by: Sheng Yang <sheng@linux.intel.com> Signed-off-by: Avi Kivity <avi@redhat.com> [-- Attachment #2: 0001-kvm-fix-bogus-msi.patch --] [-- Type: text/plain, Size: 1071 bytes --] Do not try to build MSI support on architectures where MSI definitions are not available. Signed-off-by: Jes Sorensen <jes@sgi.com> --- virt/kvm/irq_comm.c | 4 ++++ 1 file changed, 4 insertions(+) Index: kvm/virt/kvm/irq_comm.c =================================================================== --- kvm.orig/virt/kvm/irq_comm.c +++ kvm/virt/kvm/irq_comm.c @@ -45,6 +45,7 @@ return kvm_ioapic_set_irq(kvm->arch.vioapic, e->irqchip.pin, level); } +#ifdef CONFIG_X86 static int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, struct kvm *kvm, int level) { @@ -95,6 +96,7 @@ } return r; } +#endif /* This should be called with the kvm->lock mutex held * Return value: @@ -262,12 +264,14 @@ e->irqchip.irqchip = ue->u.irqchip.irqchip; e->irqchip.pin = ue->u.irqchip.pin + delta; break; +#ifdef CONFIG_X86 case KVM_IRQ_ROUTING_MSI: e->set = kvm_set_msi; e->msi.address_lo = ue->u.msi.address_lo; e->msi.address_hi = ue->u.msi.address_hi; e->msi.data = ue->u.msi.data; break; +#endif default: goto out; }
WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <jes@sgi.com> To: kvm-ia64@vger.kernel.org Subject: KVM build breakage Date: Tue, 24 Feb 2009 16:24:54 +0000 [thread overview] Message-ID: <49A41F56.3030705@sgi.com> (raw) [-- Attachment #1: Type: text/plain, Size: 2121 bytes --] Hi, A snapshot of Avi's tree as of today breaks on ia64. Looks like it is the recent MSI support that caused this. Sheng Yang, please make sure to test on non x86 when you implement things like these that clearly will only build on x86. This patch boots on ia64 for me. Thanks, Jes CC arch/ia64/kvm/../../../virt/kvm/irq_comm.o arch/ia64/kvm/../../../virt/kvm/irq_comm.c: In function 'kvm_set_msi': arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: 'MSI_ADDR_DEST_ID_MASK' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: (Each undeclared identifier is reported only once arch/ia64/kvm/../../../virt/kvm/irq_comm.c:54: error: for each function it appears in.) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:55: error: 'MSI_ADDR_DEST_ID_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:56: error: 'MSI_DATA_VECTOR_MASK' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:57: error: 'MSI_DATA_VECTOR_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:58: error: 'MSI_ADDR_DEST_MODE_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:60: error: 'MSI_DATA_TRIGGER_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:62: error: 'MSI_DATA_DELIVERY_MODE_SHIFT' undeclared (first use in this function) arch/ia64/kvm/../../../virt/kvm/irq_comm.c:76: error: implicit declaration of function 'kvm_apic_set_irq' make[1]: *** [arch/ia64/kvm/../../../virt/kvm/irq_comm.o] Error 1 make: *** [arch/ia64/kvm] Error 2 commit e4caaecb2fa206ee513756fe17593d7b3334be7b Author: Sheng Yang <sheng@linux.intel.com> Date: Tue Feb 10 13:57:06 2009 +0800 KVM: Use irq routing API for MSI Merge MSI userspace interface with IRQ routing table. Notice the API have been changed, and using IRQ routing table would be the only interface kvm-userspace supported. Signed-off-by: Sheng Yang <sheng@linux.intel.com> Signed-off-by: Avi Kivity <avi@redhat.com> [-- Attachment #2: 0001-kvm-fix-bogus-msi.patch --] [-- Type: text/plain, Size: 1071 bytes --] Do not try to build MSI support on architectures where MSI definitions are not available. Signed-off-by: Jes Sorensen <jes@sgi.com> --- virt/kvm/irq_comm.c | 4 ++++ 1 file changed, 4 insertions(+) Index: kvm/virt/kvm/irq_comm.c =================================================================== --- kvm.orig/virt/kvm/irq_comm.c +++ kvm/virt/kvm/irq_comm.c @@ -45,6 +45,7 @@ return kvm_ioapic_set_irq(kvm->arch.vioapic, e->irqchip.pin, level); } +#ifdef CONFIG_X86 static int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, struct kvm *kvm, int level) { @@ -95,6 +96,7 @@ } return r; } +#endif /* This should be called with the kvm->lock mutex held * Return value: @@ -262,12 +264,14 @@ e->irqchip.irqchip = ue->u.irqchip.irqchip; e->irqchip.pin = ue->u.irqchip.pin + delta; break; +#ifdef CONFIG_X86 case KVM_IRQ_ROUTING_MSI: e->set = kvm_set_msi; e->msi.address_lo = ue->u.msi.address_lo; e->msi.address_hi = ue->u.msi.address_hi; e->msi.data = ue->u.msi.data; break; +#endif default: goto out; }
next reply other threads:[~2009-02-24 16:25 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-02-24 16:24 Jes Sorensen [this message] 2009-02-24 16:24 ` KVM build breakage Jes Sorensen 2009-02-25 1:16 ` Zhang, Xiantao 2009-02-25 1:16 ` Zhang, Xiantao 2009-02-25 10:05 ` Jes Sorensen 2009-02-25 10:05 ` Jes Sorensen 2009-02-25 10:22 ` Zhang, Xiantao 2009-02-25 10:22 ` Zhang, Xiantao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=49A41F56.3030705@sgi.com \ --to=jes@sgi.com \ --cc=avi@redhat.com \ --cc=kvm-ia64@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=sheng@linux.intel.com \ --cc=xiantao.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.