Re: [PATCH] regulator: twl4030 VAUX3 supports 3.0V

From: Adrian Hunter <adrian.hunter@nokia.com>
To: David Brownell <david-b@pacbell.net>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
	Mark Brown <broonie@sirena.org.uk>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-omap Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] regulator: twl4030 VAUX3 supports 3.0V
Date: Thu, 26 Mar 2009 16:21:14 +0200	[thread overview]
Message-ID: <49CB8F5A.4030400@nokia.com> (raw)
In-Reply-To: <200903251003.29340.david-b@pacbell.net>

>From 51f946af56a5de9c25b2eb6e6a33660283f84195 Mon Sep 17 00:00:00 2001
From: Adrian Hunter <adrian.hunter@nokia.com>
Date: Fri, 6 Mar 2009 14:51:30 +0200
Subject: [PATCH] regulator: twl4030 VAUX3 supports 3.0V

TWL4030 and TWL5030 support 3.0V on VAUX3.

Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
---
 drivers/regulator/twl4030-regulator.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
index f3ec98c..e2032fb 100644
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -193,6 +193,9 @@ static int twl4030reg_set_mode(struct regulator_dev *rdev, unsigned mode)
  *
  * VSEL values documented as "TI cannot support these values" are flagged
  * in these tables as UNSUP() values; we normally won't assign them.
+ *
+ * VAUX3 at 3V is incorrectly listed in some TI manuals as unsupported.
+ * TI are revising the twl5030/tps659x0 specs to support that 3.0V setting.
  */
 #ifdef CONFIG_TWL4030_ALLOW_UNSUPPORTED
 #define UNSUP_MASK	0x0000
@@ -223,7 +226,7 @@ static const u16 VAUX2_VSEL_table[] = {
 };
 static const u16 VAUX3_VSEL_table[] = {
 	1500, 1800, 2500, 2800,
-	UNSUP(3000), UNSUP(3000), UNSUP(3000), UNSUP(3000),
+	3000, 3000, 3000, 3000,
 };
 static const u16 VAUX4_VSEL_table[] = {
 	700, 1000, 1200, UNSUP(1300),
-- 
1.5.6.3
