All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
To: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Cc: Michal Suchanek <msuchanek@suse.de>,
	Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Eric Biggers <ebiggers@google.com>,
	"J. Bruce Fields" <bfields@redhat.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Benjamin Coddington <bcodding@redhat.com>,
	Ming Lei <ming.lei@redhat.com>,
	Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Damien Le Moal <damien.lemoal@wdc.com>,
	Hou Tao <houtao1@huawei.com>,
	Pavel Begunkov <asml.silence@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Jan Kara <jack@suse.cz>, Hannes Reinecke <hare@suse.com>,
	"Ewan D. Milne" <emilne@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Matthew Wilcox <willy@infradead.org>
Subject: [PATCH v4 07/10] bdev: separate parts of __blkdev_get as helper functions
Date: Thu, 21 Nov 2019 18:13:14 +0100	[thread overview]
Message-ID: <49c843f88373d9ad4f6e607f704f51ca84c1747d.1574355709.git.msuchanek@suse.de> (raw)
In-Reply-To: <cover.1574355709.git.msuchanek@suse.de>

This code will be reused in later patch. Hopefully putting it aside
rather than cut&pasting another copy will make the function more
readable.

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 fs/block_dev.c | 52 +++++++++++++++++++++++++++-----------------------
 1 file changed, 28 insertions(+), 24 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index a3083fbada8b..10c9e0ae2bdc 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1512,6 +1512,28 @@ EXPORT_SYMBOL(bd_set_size);
 
 static void __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part);
 
+static void blkdev_init_size(struct block_device *bdev, struct gendisk *disk)
+{
+	bd_set_size(bdev, (loff_t)get_capacity(disk) << 9);
+	set_init_blocksize(bdev);
+}
+
+static void blkdev_do_partitions(struct block_device *bdev,
+				 struct gendisk *disk, int ret)
+{
+	/*
+	 * If the device is invalidated, rescan partition if open succeeded or
+	 * failed with -ENOMEDIUM.  The latter is necessary to prevent ghost
+	 * partitions on a removed medium.
+	 */
+	if (bdev->bd_invalidated) {
+		if (!ret)
+			rescan_partitions(disk, bdev);
+		else if (ret == -ENOMEDIUM)
+			invalidate_partitions(disk, bdev);
+	}
+}
+
 /*
  * bd_mutex locking:
  *
@@ -1584,23 +1606,9 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
 				}
 			}
 
-			if (!ret) {
-				bd_set_size(bdev,(loff_t)get_capacity(disk)<<9);
-				set_init_blocksize(bdev);
-			}
-
-			/*
-			 * If the device is invalidated, rescan partition
-			 * if open succeeded or failed with -ENOMEDIUM.
-			 * The latter is necessary to prevent ghost
-			 * partitions on a removed medium.
-			 */
-			if (bdev->bd_invalidated) {
-				if (!ret)
-					rescan_partitions(disk, bdev);
-				else if (ret == -ENOMEDIUM)
-					invalidate_partitions(disk, bdev);
-			}
+			if (!ret)
+				blkdev_init_size(bdev, disk);
+			blkdev_do_partitions(bdev, disk, ret);
 
 			if (ret)
 				goto out_clear;
@@ -1632,13 +1640,9 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
 			ret = 0;
 			if (bdev->bd_disk->fops->open)
 				ret = bdev->bd_disk->fops->open(bdev, mode);
-			/* the same as first opener case, read comment there */
-			if (bdev->bd_invalidated) {
-				if (!ret)
-					rescan_partitions(bdev->bd_disk, bdev);
-				else if (ret == -ENOMEDIUM)
-					invalidate_partitions(bdev->bd_disk, bdev);
-			}
+
+			blkdev_do_partitions(bdev, disk, ret);
+
 			if (ret)
 				goto out_unlock_bdev;
 		}
-- 
2.23.0


  parent reply	other threads:[~2019-11-21 17:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 17:13 [PATCH v4 00/10] Fix cdrom autoclose Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 01/10] cdrom: add poll_event_interruptible Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 02/10] cdrom: factor out common open_for_* code Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 03/10] cdrom: wait for the tray to close Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 04/10] cdrom: export autoclose logic as a separate function Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 05/10] cdrom: unify log messages Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 06/10] bdev: reset first_open when looping in __blkget_dev Michal Suchanek
2019-11-21 17:13 ` Michal Suchanek [this message]
2019-11-21 17:13 ` [PATCH v4 08/10] bdev: add open_finish Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 09/10] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation Michal Suchanek
2019-11-21 17:13 ` [PATCH v4 10/10] scsi: sr: wait for the medium to become ready Michal Suchanek
2019-11-21 19:00 ` [PATCH v4 00/10] Fix cdrom autoclose Jens Axboe
2019-11-21 23:43   ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49c843f88373d9ad4f6e607f704f51ca84c1747d.1574355709.git.msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bcodding@redhat.com \
    --cc=bfields@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@wdc.com \
    --cc=ebiggers@google.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=houtao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=jejb@linux.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.