All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org,
	edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org,
	mka@chromium.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Anson Huang <anson.huang@nxp.com>,
	linux-pm@vger.kernel.org
Subject: [PATCH v1 05/10] cpufreq: imx6q: Use auto-registration of thermal cooling device
Date: Mon, 14 Jan 2019 22:04:57 +0530	[thread overview]
Message-ID: <49e531e140f299127ae6c0bc905b993b97c269e2.1547481320.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1547481320.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1547481320.git.amit.kucheria@linaro.org>

Use the CPUFREQ_AUTO_REGISTER_COOLING_DEV flag to allow cpufreq core to
automatically register as a thermal cooling device.

This allows removal of boiler plate code from the driver.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
---
 drivers/cpufreq/imx6q-cpufreq.c | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
index 9fedf627e000..ffb00291f48e 100644
--- a/drivers/cpufreq/imx6q-cpufreq.c
+++ b/drivers/cpufreq/imx6q-cpufreq.c
@@ -9,7 +9,6 @@
 #include <linux/clk.h>
 #include <linux/cpu.h>
 #include <linux/cpufreq.h>
-#include <linux/cpu_cooling.h>
 #include <linux/err.h>
 #include <linux/module.h>
 #include <linux/nvmem-consumer.h>
@@ -52,7 +51,6 @@ static struct clk_bulk_data clks[] = {
 };
 
 static struct device *cpu_dev;
-static struct thermal_cooling_device *cdev;
 static bool free_opp;
 static struct cpufreq_frequency_table *freq_table;
 static unsigned int max_freq;
@@ -193,16 +191,6 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index)
 	return 0;
 }
 
-static void imx6q_cpufreq_ready(struct cpufreq_policy *policy)
-{
-	cdev = of_cpufreq_cooling_register(policy);
-
-	if (!cdev)
-		dev_err(cpu_dev,
-			"running cpufreq without cooling device: %ld\n",
-			PTR_ERR(cdev));
-}
-
 static int imx6q_cpufreq_init(struct cpufreq_policy *policy)
 {
 	int ret;
@@ -216,20 +204,18 @@ static int imx6q_cpufreq_init(struct cpufreq_policy *policy)
 
 static int imx6q_cpufreq_exit(struct cpufreq_policy *policy)
 {
-	cpufreq_cooling_unregister(cdev);
-
 	return 0;
 }
 
 static struct cpufreq_driver imx6q_cpufreq_driver = {
-	.flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK,
+	.flags = CPUFREQ_NEED_INITIAL_FREQ_CHECK |
+		 CPUFREQ_AUTO_REGISTER_COOLING_DEV,
 	.verify = cpufreq_generic_frequency_table_verify,
 	.target_index = imx6q_set_target,
 	.get = cpufreq_generic_get,
 	.init = imx6q_cpufreq_init,
 	.exit = imx6q_cpufreq_exit,
 	.name = "imx6q-cpufreq",
-	.ready = imx6q_cpufreq_ready,
 	.attr = cpufreq_generic_attr,
 	.suspend = cpufreq_generic_suspend,
 };
-- 
2.17.1

  parent reply	other threads:[~2019-01-14 16:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 16:34 [PATCH v1 00/10] cpufreq: Add flag to auto-register as cooling device Amit Kucheria
2019-01-14 16:34 ` Amit Kucheria
2019-01-14 16:34 ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 01/10] cpufreq: Add thermal_cooling_device pointer to struct cpufreq_policy Amit Kucheria
2019-01-16 22:56   ` Rafael J. Wysocki
2019-01-21 15:35     ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 02/10] cpufreq: Add a flag to auto-register a cooling device Amit Kucheria
2019-01-14 20:51   ` Matthias Kaehlcke
2019-01-16 23:03   ` Rafael J. Wysocki
2019-01-17  4:42     ` Viresh Kumar
2019-01-21 14:23       ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 03/10] cpufreq: Replace open-coded << with BIT() Amit Kucheria
2019-01-15 19:05   ` Stephen Boyd
2019-01-16 22:55   ` Rafael J. Wysocki
2019-01-21  8:48     ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 04/10] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-14 20:54   ` Matthias Kaehlcke
2019-01-14 16:34 ` Amit Kucheria [this message]
2019-01-17  4:49   ` [PATCH v1 05/10] cpufreq: imx6q: Use auto-registration of thermal " Viresh Kumar
2019-01-14 16:34 ` [PATCH v1 06/10] cpufreq: cpufreq-dt: " Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 07/10] cpufreq: mediatek: " Amit Kucheria
2019-01-14 16:34   ` Amit Kucheria
2019-01-14 16:35 ` [PATCH v1 08/10] cpufreq: qoriq: " Amit Kucheria
2019-01-14 16:35 ` [PATCH v1 09/10] cpufreq: scmi: " Amit Kucheria
2019-01-14 16:35   ` Amit Kucheria
2019-01-15 10:37   ` Sudeep Holla
2019-01-15 10:37     ` Sudeep Holla
2019-01-14 16:35 ` [PATCH v1 10/10] cpufreq: scpi: " Amit Kucheria
2019-01-14 16:35   ` Amit Kucheria
2019-01-17  5:49 ` [PATCH v1 00/10] cpufreq: Add flag to auto-register as " Viresh Kumar
2019-01-17  5:49   ` Viresh Kumar
2019-01-17  5:49   ` Viresh Kumar
2019-01-17 10:08   ` Rafael J. Wysocki
2019-01-17 10:08     ` Rafael J. Wysocki
2019-01-17 10:08     ` Rafael J. Wysocki
2019-01-17 10:14     ` Rafael J. Wysocki
2019-01-17 10:14       ` Rafael J. Wysocki
2019-01-17 10:14       ` Rafael J. Wysocki
2019-01-17 10:28       ` Viresh Kumar
2019-01-17 10:28         ` Viresh Kumar
2019-01-17 10:28         ` Viresh Kumar
2019-01-17 10:31         ` Rafael J. Wysocki
2019-01-17 10:31           ` Rafael J. Wysocki
2019-01-17 10:31           ` Rafael J. Wysocki
2019-01-17 10:21     ` Viresh Kumar
2019-01-17 10:21       ` Viresh Kumar
2019-01-17 10:21       ` Viresh Kumar
2019-01-17 10:29       ` Rafael J. Wysocki
2019-01-17 10:29         ` Rafael J. Wysocki
2019-01-17 10:29         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49e531e140f299127ae6c0bc905b993b97c269e2.1547481320.git.amit.kucheria@linaro.org \
    --to=amit.kucheria@linaro.org \
    --cc=anson.huang@nxp.com \
    --cc=dianders@chromium.org \
    --cc=edubezval@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=rjw@rjwysocki.net \
    --cc=swboyd@chromium.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.