From: Avi Kivity <avi@redhat.com>
To: Jes Sorensen <jes@sgi.com>
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [patch] fix - do not build blobs when blobs are not needed
Date: Thu, 07 May 2009 12:26:42 +0300 [thread overview]
Message-ID: <4A02A952.60204@redhat.com> (raw)
In-Reply-To: <4A02A1BA.5020003@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Don't like ugly assembler errors because QEMU tries to build some x86
> assembly code which isn't needed on non-x86.
.PHONY: kvm/extboot
+ifdef INSTALL_BLOBS
all: kvm/extboot
kvm/extboot:
@@ -427,3 +428,4 @@
|| ! cmp -s pc-bios/extboot.bin $@/extboot.bin; then \
cp $@/extboot.bin pc-bios/extboot.bin; \
fi
+endif
Index: qemu-kvm/configure
===================================================================
--- qemu-kvm.orig/configure
+++ qemu-kvm/configure
@@ -356,6 +356,7 @@
cpu_emulation="no"
gdbstub="no"
slirp="no"
+ blobs="no"
fi
if [ "$cpu" = "powerpc" ]; then
kvm="yes"
Seems a bit heavy handed. blobs != extboot.
How about instead:
build-targets-x86 = kvm/extboot
all: $(build-targets-$(ARCH))
(or something similar that builds)
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] fix - do not build blobs when blobs are not needed
Date: Thu, 07 May 2009 09:26:42 +0000 [thread overview]
Message-ID: <4A02A952.60204@redhat.com> (raw)
In-Reply-To: <4A02A1BA.5020003@sgi.com>
Jes Sorensen wrote:
> Hi,
>
> Don't like ugly assembler errors because QEMU tries to build some x86
> assembly code which isn't needed on non-x86.
.PHONY: kvm/extboot
+ifdef INSTALL_BLOBS
all: kvm/extboot
kvm/extboot:
@@ -427,3 +428,4 @@
|| ! cmp -s pc-bios/extboot.bin $@/extboot.bin; then \
cp $@/extboot.bin pc-bios/extboot.bin; \
fi
+endif
Index: qemu-kvm/configure
=================================--- qemu-kvm.orig/configure
+++ qemu-kvm/configure
@@ -356,6 +356,7 @@
cpu_emulation="no"
gdbstub="no"
slirp="no"
+ blobs="no"
fi
if [ "$cpu" = "powerpc" ]; then
kvm="yes"
Seems a bit heavy handed. blobs != extboot.
How about instead:
build-targets-x86 = kvm/extboot
all: $(build-targets-$(ARCH))
(or something similar that builds)
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-05-07 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:54 [patch] fix - do not build blobs when blobs are not needed Jes Sorensen
2009-05-07 8:54 ` Jes Sorensen
2009-05-07 9:26 ` Avi Kivity [this message]
2009-05-07 9:26 ` Avi Kivity
2009-05-07 9:35 ` Jes Sorensen
2009-05-07 9:35 ` Jes Sorensen
2009-05-07 9:49 ` Avi Kivity
2009-05-07 9:49 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A02A952.60204@redhat.com \
--to=avi@redhat.com \
--cc=jes@sgi.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.