From: Jes Sorensen <jes@sgi.com>
To: Avi Kivity <avi@redhat.com>
Cc: "kvm-ia64@vger.kernel.org" <kvm-ia64@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [patch] fix - do not build blobs when blobs are not needed
Date: Thu, 07 May 2009 11:35:57 +0200 [thread overview]
Message-ID: <4A02AB7D.5000509@sgi.com> (raw)
In-Reply-To: <4A02A952.60204@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Avi Kivity wrote:
> Seems a bit heavy handed. blobs != extboot.
>
> How about instead:
>
> build-targets-x86 = kvm/extboot
>
> all: $(build-targets-$(ARCH))
>
> (or something similar that builds)
There's no problem that cannot be fixed by applying an appropriately
large hammer .... :-)
This one works for me.
Jes
[-- Attachment #2: 0009-qemu-kvm-ia64-defaults.patch --]
[-- Type: text/x-patch, Size: 487 bytes --]
Do not try to build extboot on non-x86.
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
Makefile | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: qemu-kvm/Makefile
===================================================================
--- qemu-kvm.orig/Makefile
+++ qemu-kvm/Makefile
@@ -419,7 +419,10 @@
.PHONY: kvm/extboot
-all: kvm/extboot
+build-targets-x86 = kvm/extboot
+build-targets-ia64 =
+
+all: $(build-targets-$(ARCH))
kvm/extboot:
$(MAKE) -C $@
WARNING: multiple messages have this Message-ID (diff)
From: Jes Sorensen <jes@sgi.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [patch] fix - do not build blobs when blobs are not needed
Date: Thu, 07 May 2009 09:35:57 +0000 [thread overview]
Message-ID: <4A02AB7D.5000509@sgi.com> (raw)
In-Reply-To: <4A02A1BA.5020003@sgi.com>
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Avi Kivity wrote:
> Seems a bit heavy handed. blobs != extboot.
>
> How about instead:
>
> build-targets-x86 = kvm/extboot
>
> all: $(build-targets-$(ARCH))
>
> (or something similar that builds)
There's no problem that cannot be fixed by applying an appropriately
large hammer .... :-)
This one works for me.
Jes
[-- Attachment #2: 0009-qemu-kvm-ia64-defaults.patch --]
[-- Type: text/x-patch, Size: 487 bytes --]
Do not try to build extboot on non-x86.
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
Makefile | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: qemu-kvm/Makefile
===================================================================
--- qemu-kvm.orig/Makefile
+++ qemu-kvm/Makefile
@@ -419,7 +419,10 @@
.PHONY: kvm/extboot
-all: kvm/extboot
+build-targets-x86 = kvm/extboot
+build-targets-ia64 =
+
+all: $(build-targets-$(ARCH))
kvm/extboot:
$(MAKE) -C $@
next prev parent reply other threads:[~2009-05-07 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:54 [patch] fix - do not build blobs when blobs are not needed Jes Sorensen
2009-05-07 8:54 ` Jes Sorensen
2009-05-07 9:26 ` Avi Kivity
2009-05-07 9:26 ` Avi Kivity
2009-05-07 9:35 ` Jes Sorensen [this message]
2009-05-07 9:35 ` Jes Sorensen
2009-05-07 9:49 ` Avi Kivity
2009-05-07 9:49 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A02AB7D.5000509@sgi.com \
--to=jes@sgi.com \
--cc=avi@redhat.com \
--cc=kvm-ia64@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.