From: Bryan Schumaker <bjschuma@netapp.com> To: Jiri Slaby <jslaby@suse.cz> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>, Jiri Slaby <jirislaby@gmail.com>, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mm-commits@vger.kernel.org, ML netdev <netdev@vger.kernel.org>, linux-nfs@vger.kernel.org Subject: Re: [PATCH] NFS: Fix infinite loop in gss_create_upcall() Date: Wed, 13 Apr 2011 16:42:33 -0400 [thread overview] Message-ID: <4DA60AB9.1050104@netapp.com> (raw) In-Reply-To: <4DA49F7F.8060005@suse.cz> On 04/12/2011 02:52 PM, Jiri Slaby wrote: > On 04/12/2011 08:43 PM, Bryan Schumaker wrote: >> On 04/12/2011 02:34 PM, Jiri Slaby wrote: >>> On 04/12/2011 08:31 PM, Trond Myklebust wrote: >>>>> Yes, it fixes the problem. But it waits 15s before it times out. This is >>>>> inacceptable for automounted NFS dirs. >>>> >>>> I'm still confused as to why you are hitting it at all. In the normal >>>> autonegotiation case, the client should be trying to use AUTH_SYS first >>>> and then trying rpcsec_gss if and only if that fails. >>>> >>>> Are you really exporting a filesystem using AUTH_NULL as the only >>>> supported flavour? >>> >>> I don't know, I connect to a nfs server which is not maintained by me. >>> It looks like that. How can I find out? >> >> If you're not using gss for anything, you could try rmmod-ing rpcsec_gss_krb5 (and other rpcsec_gss_* modules). > > I don't have NFS in modules. It's all built-in. And this one is > unconditionally selected because of CONFIG_NFS_V4. Does this patch help? - Bryan We should attempt an AUTH_NULL style mount before trying gss flavors. This should prevent a hang if gss modules are loaded but the userspace program isn't running. diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 9bf41ea..4e3c16b 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2218,8 +2218,8 @@ static int nfs4_proc_get_root(struct nfs_server *server, struct nfs_fh *fhandle, rpc_authflavor_t flav_array[NFS_MAX_SECFLAVORS + 2]; flav_array[0] = RPC_AUTH_UNIX; - len = gss_mech_list_pseudoflavors(&flav_array[1]); - flav_array[1+len] = RPC_AUTH_NULL; + flav_array[1] = RPC_AUTH_NULL; + len = gss_mech_list_pseudoflavors(&flav_array[2]); len += 2; for (i = 0; i < len; i++) { > > regards,
WARNING: multiple messages have this Message-ID (diff)
From: Bryan Schumaker <bjschuma-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org> To: Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org> Cc: Trond Myklebust <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>, Jiri Slaby <jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mm-commits-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, ML netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] NFS: Fix infinite loop in gss_create_upcall() Date: Wed, 13 Apr 2011 16:42:33 -0400 [thread overview] Message-ID: <4DA60AB9.1050104@netapp.com> (raw) In-Reply-To: <4DA49F7F.8060005-AlSwsSmVLrQ@public.gmane.org> On 04/12/2011 02:52 PM, Jiri Slaby wrote: > On 04/12/2011 08:43 PM, Bryan Schumaker wrote: >> On 04/12/2011 02:34 PM, Jiri Slaby wrote: >>> On 04/12/2011 08:31 PM, Trond Myklebust wrote: >>>>> Yes, it fixes the problem. But it waits 15s before it times out. This is >>>>> inacceptable for automounted NFS dirs. >>>> >>>> I'm still confused as to why you are hitting it at all. In the normal >>>> autonegotiation case, the client should be trying to use AUTH_SYS first >>>> and then trying rpcsec_gss if and only if that fails. >>>> >>>> Are you really exporting a filesystem using AUTH_NULL as the only >>>> supported flavour? >>> >>> I don't know, I connect to a nfs server which is not maintained by me. >>> It looks like that. How can I find out? >> >> If you're not using gss for anything, you could try rmmod-ing rpcsec_gss_krb5 (and other rpcsec_gss_* modules). > > I don't have NFS in modules. It's all built-in. And this one is > unconditionally selected because of CONFIG_NFS_V4. Does this patch help? - Bryan We should attempt an AUTH_NULL style mount before trying gss flavors. This should prevent a hang if gss modules are loaded but the userspace program isn't running. diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 9bf41ea..4e3c16b 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -2218,8 +2218,8 @@ static int nfs4_proc_get_root(struct nfs_server *server, struct nfs_fh *fhandle, rpc_authflavor_t flav_array[NFS_MAX_SECFLAVORS + 2]; flav_array[0] = RPC_AUTH_UNIX; - len = gss_mech_list_pseudoflavors(&flav_array[1]); - flav_array[1+len] = RPC_AUTH_NULL; + flav_array[1] = RPC_AUTH_NULL; + len = gss_mech_list_pseudoflavors(&flav_array[2]); len += 2; for (i = 0; i < len; i++) { > > regards, -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-04-13 20:42 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-03-31 21:48 mmotm 2011-03-31-14-48 uploaded akpm 2011-03-31 21:48 ` akpm 2011-04-01 15:56 ` [PATCH -mm] olpc: xo_1 needs delay.h Randy Dunlap 2011-04-01 15:57 ` [PATCH -mm] leds: fix pca9532 build when GPIOLIB is disabled Randy Dunlap 2011-04-02 8:56 ` nfs client doesn't work [was: mmotm 2011-03-31-14-48 uploaded] Jiri Slaby 2011-04-02 8:56 ` Jiri Slaby [not found] ` <1302122693.16786.0.camel@lade.trondhjem.org> 2011-04-07 6:42 ` Jiri Slaby 2011-04-07 6:42 ` Jiri Slaby 2011-04-11 20:40 ` Jiri Slaby 2011-04-11 20:40 ` Jiri Slaby 2011-04-11 20:40 ` Jiri Slaby 2011-04-11 20:40 ` Jiri Slaby 2011-04-11 21:08 ` Jiri Slaby 2011-04-11 21:08 ` Jiri Slaby 2011-04-12 17:41 ` [PATCH] NFS: Fix infinite loop in gss_create_upcall() Bryan Schumaker 2011-04-12 17:41 ` Bryan Schumaker 2011-04-12 18:05 ` Jiri Slaby 2011-04-12 18:05 ` Jiri Slaby 2011-04-12 18:31 ` Trond Myklebust 2011-04-12 18:34 ` Jiri Slaby 2011-04-12 18:34 ` Jiri Slaby 2011-04-12 18:38 ` Trond Myklebust 2011-04-12 18:38 ` Trond Myklebust 2011-04-12 18:43 ` Bryan Schumaker 2011-04-12 18:43 ` Bryan Schumaker 2011-04-12 18:52 ` Jiri Slaby 2011-04-12 18:52 ` Jiri Slaby 2011-04-13 20:42 ` Bryan Schumaker [this message] 2011-04-13 20:42 ` Bryan Schumaker 2011-04-14 20:37 ` Jiri Slaby 2011-04-14 20:37 ` Jiri Slaby 2011-04-14 21:21 ` Trond Myklebust 2011-04-14 21:30 ` Jiri Slaby 2011-04-14 21:30 ` Jiri Slaby 2011-04-11 20:56 ` nfs client doesn't work [was: mmotm 2011-03-31-14-48 uploaded] Bryan Schumaker 2011-04-11 20:56 ` Bryan Schumaker 2011-04-11 21:19 ` Jiri Slaby 2011-04-03 9:11 ` mmotm 2011-03-31-14-48 uploaded KOSAKI Motohiro 2011-04-04 20:46 ` Peter Zijlstra 2011-04-04 20:46 ` Peter Zijlstra 2011-04-05 5:23 ` KOSAKI Motohiro 2011-04-11 4:11 ` KOSAKI Motohiro 2011-04-11 4:11 ` KOSAKI Motohiro 2011-04-11 4:11 ` KOSAKI Motohiro
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4DA60AB9.1050104@netapp.com \ --to=bjschuma@netapp.com \ --cc=Trond.Myklebust@netapp.com \ --cc=akpm@linux-foundation.org \ --cc=jirislaby@gmail.com \ --cc=jslaby@suse.cz \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nfs@vger.kernel.org \ --cc=mm-commits@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.