All of lore.kernel.org
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-omap@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] OMAP2/4: PM: Boot message is not an error/info,	and not helpful, remove it
Date: Mon, 30 May 2011 19:14:11 +0530	[thread overview]
Message-ID: <4DE39F2B.3040506@ti.com> (raw)
In-Reply-To: <4DE39D40.2060500@ru.mvista.com>

On 5/30/2011 7:06 PM, Sergei Shtylyov wrote:
> Hello.
>
> Santosh Shilimkar wrote:
>
>> The commit '99aa18278e' removed the boot messege for OMAP3. Do the same
>
> Please specify that commit's summary in parens -- for the human readers.
> Oh, and you don't need quotes around commit ID too.
>
Yes I missed that. Updated patch below.

Regards
Santosh

 From 53e986a2a43dc204146af99c2d7a906dba781ea0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 30 May 2011 15:52:01 +0530
Subject: [PATCH] OMAP2/4: PM: Boot message is not an error/info, and not 
helpful, remove it

The commit 99aa18278e (OMAP3: PM: Boot message is not an error,
and not helpful, remove it), removed the boot message for OMAP3.
Do the same for OMAP2 and OMAP4 since it's really just noise in the
boot log and PM init is always called.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
---
  arch/arm/mach-omap2/pm24xx.c |    1 -
  arch/arm/mach-omap2/pm44xx.c |    2 --
  2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c
index df3ded6..5970759 100644
--- a/arch/arm/mach-omap2/pm24xx.c
+++ b/arch/arm/mach-omap2/pm24xx.c
@@ -442,7 +442,6 @@ static int __init omap2_pm_init(void)
  	if (!cpu_is_omap24xx())
  		return -ENODEV;

-	printk(KERN_INFO "Power Management for OMAP2 initializing\n");
  	l = omap2_prm_read_mod_reg(OCP_MOD, OMAP2_PRCM_REVISION_OFFSET);
  	printk(KERN_INFO "PRCM revision %d.%d\n", (l >> 4) & 0x0f, l & 0x0f);

diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index 59a870b..a6259d6 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -103,8 +103,6 @@ static int __init omap4_pm_init(void)
  	if (!cpu_is_omap44xx())
  		return -ENODEV;

-	pr_err("Power Management for TI OMAP4.\n");
-
  	ret = pwrdm_for_each(pwrdms_setup, NULL);
  	if (ret) {
  		pr_err("Failed to setup powerdomains\n");
-- 
1.6.0.4


WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP2/4: PM: Boot message is not an error/info,	and not helpful, remove it
Date: Mon, 30 May 2011 19:14:11 +0530	[thread overview]
Message-ID: <4DE39F2B.3040506@ti.com> (raw)
In-Reply-To: <4DE39D40.2060500@ru.mvista.com>

On 5/30/2011 7:06 PM, Sergei Shtylyov wrote:
> Hello.
>
> Santosh Shilimkar wrote:
>
>> The commit '99aa18278e' removed the boot messege for OMAP3. Do the same
>
> Please specify that commit's summary in parens -- for the human readers.
> Oh, and you don't need quotes around commit ID too.
>
Yes I missed that. Updated patch below.

Regards
Santosh

 From 53e986a2a43dc204146af99c2d7a906dba781ea0 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Mon, 30 May 2011 15:52:01 +0530
Subject: [PATCH] OMAP2/4: PM: Boot message is not an error/info, and not 
helpful, remove it

The commit 99aa18278e (OMAP3: PM: Boot message is not an error,
and not helpful, remove it), removed the boot message for OMAP3.
Do the same for OMAP2 and OMAP4 since it's really just noise in the
boot log and PM init is always called.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Kevin Hilman <khilman@ti.com>
---
  arch/arm/mach-omap2/pm24xx.c |    1 -
  arch/arm/mach-omap2/pm44xx.c |    2 --
  2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/pm24xx.c b/arch/arm/mach-omap2/pm24xx.c
index df3ded6..5970759 100644
--- a/arch/arm/mach-omap2/pm24xx.c
+++ b/arch/arm/mach-omap2/pm24xx.c
@@ -442,7 +442,6 @@ static int __init omap2_pm_init(void)
  	if (!cpu_is_omap24xx())
  		return -ENODEV;

-	printk(KERN_INFO "Power Management for OMAP2 initializing\n");
  	l = omap2_prm_read_mod_reg(OCP_MOD, OMAP2_PRCM_REVISION_OFFSET);
  	printk(KERN_INFO "PRCM revision %d.%d\n", (l >> 4) & 0x0f, l & 0x0f);

diff --git a/arch/arm/mach-omap2/pm44xx.c b/arch/arm/mach-omap2/pm44xx.c
index 59a870b..a6259d6 100644
--- a/arch/arm/mach-omap2/pm44xx.c
+++ b/arch/arm/mach-omap2/pm44xx.c
@@ -103,8 +103,6 @@ static int __init omap4_pm_init(void)
  	if (!cpu_is_omap44xx())
  		return -ENODEV;

-	pr_err("Power Management for TI OMAP4.\n");
-
  	ret = pwrdm_for_each(pwrdms_setup, NULL);
  	if (ret) {
  		pr_err("Failed to setup powerdomains\n");
-- 
1.6.0.4

  reply	other threads:[~2011-05-30 13:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30 10:32 [PATCH] OMAP2/4: PM: Boot message is not an error/info, and not helpful, remove it Santosh Shilimkar
2011-05-30 10:32 ` Santosh Shilimkar
2011-05-30 13:36 ` Sergei Shtylyov
2011-05-30 13:36   ` Sergei Shtylyov
2011-05-30 13:44   ` Santosh Shilimkar [this message]
2011-05-30 13:44     ` Santosh Shilimkar
2011-05-30 14:11     ` Menon, Nishanth
2011-05-30 14:11       ` Menon, Nishanth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE39F2B.3040506@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.