From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@panasas.com>, NFS list <linux-nfs@vger.kernel.org>
Subject: [PATCH] FIXME: BUG wdata->mds_offset never gets set
Date: Wed, 15 Jun 2011 17:43:38 -0400 [thread overview]
Message-ID: <4DF9278A.5010103@panasas.com> (raw)
The fileslayout and blockslayout drivers had a set of
wdata->mds_offset in their .write_pagelist member.
The objects driver did not. Which breaks layout_commit.
FIXME: Since all drivers set mds_offset in exactly the same place
to the same value. And then never touch it. It calls for the
generic layer to take care of it.
(I'll send the fix tomorrow)
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
fs/nfs/objlayout/objlayout.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/nfs/objlayout/objlayout.c b/fs/nfs/objlayout/objlayout.c
index dc3956c..96dd474 100644
--- a/fs/nfs/objlayout/objlayout.c
+++ b/fs/nfs/objlayout/objlayout.c
@@ -430,6 +430,8 @@ objlayout_write_pagelist(struct nfs_write_data *wdata,
status = objio_write_pagelist(state, how & FLUSH_STABLE);
out:
dprintk("%s: Return status %Zd\n", __func__, status);
+ /* pnfs_set_layoutcommit needs this */
+ wdata->mds_offset = wdata->args.offset;
wdata->pnfs_error = status;
return PNFS_ATTEMPTED;
}
--
1.7.3.4
next reply other threads:[~2011-06-15 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 21:43 Boaz Harrosh [this message]
2011-06-16 2:50 ` [PATCH] FIXME: BUG wdata->mds_offset never gets set Benny Halevy
2011-06-16 12:52 ` Boaz Harrosh
2011-06-16 15:35 ` [PATCH 1/3] pnfs: write: Set mds_offset in the generic layer - it is needed by all LDs Boaz Harrosh
2011-06-16 15:37 ` [PATCH 2/3] SQUASHME pnfs-blocks: mds_offset is set in the generic layer Boaz Harrosh
2011-06-16 15:38 ` [PATCH 3/3] SQUASHME: pnfs-obj: " Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF9278A.5010103@panasas.com \
--to=bharrosh@panasas.com \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.