From: Mi Jinlong <mijinlong@cn.fujitsu.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: NFS <linux-nfs@vger.kernel.org>
Subject: [PATCH 2/2 v2] nfsd41: check the size of request
Date: Sat, 02 Jul 2011 17:02:54 +0800 [thread overview]
Message-ID: <4E0EDEBE.8040902@cn.fujitsu.com> (raw)
This patch just check request's size when it consists SEQUENCE.
Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
---
fs/nfsd/nfs4state.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index e98f3c2..17e30bf 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1736,6 +1736,21 @@ static bool nfsd4_session_too_many_ops(struct svc_rqst *rqstp, struct nfsd4_sess
return args->opcnt > session->se_fchannel.maxops;
}
+static int nfsd4_check_request_size(struct nfsd4_compoundargs *args,
+ struct nfsd4_session *session)
+{
+ struct xdr_buf *xb = &args->rqstp->rq_arg;
+
+ /* Only SEQUENCE operation */
+ if (args->opcnt == 1)
+ return 0;
+
+ if (xb->len > session->se_fchannel.maxreq_sz)
+ return nfserr_req_too_big;
+
+ return 0;
+}
+
__be32
nfsd4_sequence(struct svc_rqst *rqstp,
struct nfsd4_compound_state *cstate,
@@ -1804,6 +1819,7 @@ nfsd4_sequence(struct svc_rqst *rqstp,
cstate->slot = slot;
cstate->session = session;
+ status = nfsd4_check_request_size(rqstp->rq_argp, session);
out:
/* Hold a session reference until done processing the compound. */
if (cstate->session) {
--
1.7.5.4
next reply other threads:[~2011-07-02 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 9:02 Mi Jinlong [this message]
2011-07-06 16:43 ` [PATCH 2/2 v2] nfsd41: check the size of request J. Bruce Fields
2011-07-08 9:13 ` Mi Jinlong
2011-07-08 20:03 ` J. Bruce Fields
2011-07-09 2:19 ` [PATCH 2/2 v3] " Mi Jinlong
2011-07-13 0:25 ` J. Bruce Fields
2011-07-14 6:56 ` [PATCH 2/2 v4] " Mi Jinlong
2011-07-14 14:51 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0EDEBE.8040902@cn.fujitsu.com \
--to=mijinlong@cn.fujitsu.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.