From: Bertrand Marquis <bertrand.marquis@arm.com>
To: xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Jan Beulich <jbeulich@suse.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: [PATCH v2 3/3] xen/arm: Warn user on cpu errata 832075
Date: Mon, 26 Oct 2020 16:21:33 +0000 [thread overview]
Message-ID: <4d62bc0844576b80e00ea48e318be238a4d73eae.1603728729.git.bertrand.marquis@arm.com> (raw)
In-Reply-To: <a6fc6cfd71d6d53cf89bf533a348bda799b25d7d.1603728729.git.bertrand.marquis@arm.com>
In-Reply-To: <cover.1603728729.git.bertrand.marquis@arm.com>
When a Cortex A57 processor is affected by CPU errata 832075, a guest
not implementing the workaround for it could deadlock the system.
Add a warning during boot informing the user that only trusted guests
should be executed on the system.
An equivalent warning is already given to the user by KVM on cores
affected by this errata.
Also taint the hypervisor as unsecure when this errata applies and
mention Cortex A57 r0p0 - r1p2 as not security supported in SUPPORT.md
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
SUPPORT.md | 1 +
xen/arch/arm/cpuerrata.c | 13 +++++++++++++
2 files changed, 14 insertions(+)
diff --git a/SUPPORT.md b/SUPPORT.md
index 5fbe5fc444..f7a3b046b0 100644
--- a/SUPPORT.md
+++ b/SUPPORT.md
@@ -38,6 +38,7 @@ supported in this document.
### ARM v8
Status: Supported
+ Status, Cortex A57 r0p0 - r1p2, not security supported (Errata 832075)
## Host hardware support
diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
index 0430069a84..b35e8cd0b9 100644
--- a/xen/arch/arm/cpuerrata.c
+++ b/xen/arch/arm/cpuerrata.c
@@ -503,6 +503,19 @@ void check_local_cpu_errata(void)
void __init enable_errata_workarounds(void)
{
enable_cpu_capabilities(arm_errata);
+
+#ifdef CONFIG_ARM64_ERRATUM_832075
+ if ( cpus_have_cap(ARM64_WORKAROUND_DEVICE_LOAD_ACQUIRE) )
+ {
+ printk_once("**** This CPU is affected by the errata 832075. ****\n"
+ "**** Guests without CPU erratum workarounds ****\n"
+ "**** can deadlock the system! ****\n"
+ "**** Only trusted guests should be used. ****\n");
+
+ /* Taint the machine has being insecure */
+ add_taint(TAINT_MACHINE_UNSECURE);
+ }
+#endif
}
static int cpu_errata_callback(struct notifier_block *nfb,
--
2.17.1
next prev parent reply other threads:[~2020-10-26 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 16:20 [PATCH v2 0/3] xen/arm: Warn user on cpu errata 832075 Bertrand Marquis
2020-10-26 16:21 ` [PATCH v2 1/3] xen/arm: use printk_once for errata warning prints Bertrand Marquis
2020-10-27 22:42 ` Stefano Stabellini
2020-10-26 16:21 ` [PATCH v2 2/3] xen: Add an unsecure Taint type Bertrand Marquis
2020-10-27 22:43 ` Stefano Stabellini
2020-10-26 16:21 ` Bertrand Marquis [this message]
2020-10-27 22:44 ` [PATCH v2 3/3] xen/arm: Warn user on cpu errata 832075 Stefano Stabellini
2020-10-28 8:43 ` Bertrand Marquis
2020-10-28 9:43 ` George Dunlap
2020-10-28 9:56 ` Bertrand Marquis
2020-10-28 18:36 ` Julien Grall
2020-10-28 18:39 ` Julien Grall
2020-10-28 20:10 ` Stefano Stabellini
2020-10-29 9:55 ` Bertrand Marquis
2020-10-29 23:32 ` Stefano Stabellini
2020-10-30 8:40 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d62bc0844576b80e00ea48e318be238a4d73eae.1603728729.git.bertrand.marquis@arm.com \
--to=bertrand.marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.