From: Jan Beulich <jbeulich@suse.com>
To: Wei Liu <wl@xen.org>, Paul Durrant <paul@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case
Date: Tue, 23 Feb 2021 17:29:25 +0100 [thread overview]
Message-ID: <4dd5b8ec-a255-7ab1-6dbf-52705acd6d62@suse.com> (raw)
When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the
special considerations for the head of the SKB no longer apply. Don't
mistakenly report ERROR to the frontend for the first entry in the list,
even if - from all I can tell - this shouldn't matter much as the overall
transmit will need to be considered failed anyway.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -499,7 +499,7 @@ check_frags:
* the header's copy failed, and they are
* sharing a slot, send an error
*/
- if (i == 0 && sharedslot)
+ if (i == 0 && !first_shinfo && sharedslot)
xenvif_idx_release(queue, pending_idx,
XEN_NETIF_RSP_ERROR);
else
next reply other threads:[~2021-02-23 16:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 16:29 Jan Beulich [this message]
2021-02-24 16:39 ` [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case Paul Durrant
2021-02-25 7:33 ` Jan Beulich
2021-02-25 12:11 ` Paul Durrant
2021-02-25 14:00 ` Jan Beulich
2021-02-25 16:23 ` Paul Durrant
2021-05-20 11:46 ` Jan Beulich
2021-07-15 8:58 ` Ping: " Jan Beulich
2021-09-16 15:45 ` Ping²: " Jan Beulich
2021-09-16 18:34 ` Paul Durrant
2021-09-16 21:48 ` Sander Eikelenboom
2021-09-17 6:21 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd5b8ec-a255-7ab1-6dbf-52705acd6d62@suse.com \
--to=jbeulich@suse.com \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.