All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	shawn.guo@linaro.org, sboyd@codeaurora.org,
	linux-arm-msm@vger.kernel.org, spk.linux@gmail.com,
	thomas.ab@samsung.com, t.figa@samsung.com,
	santosh.shilimkar@ti.com, thomas.petazzoni@free-electrons.com,
	pramod.gurav@smartplayin.com,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V3 03/10] cpufreq: cpu0: don't validate clock on clk_put()
Date: Thu, 28 Aug 2014 11:22:25 +0530	[thread overview]
Message-ID: <4f6f0b21db83466aef5569fddcef76a3c9b7dc5a.1409201048.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1409201048.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1409201048.git.viresh.kumar@linaro.org>

CPU clk is not optional for this driver and probe would fail if it couldn't find
a suitable clock.

And so, while calling clk_put() we don't need to validate clocks.

Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/cpufreq-cpu0.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
index 4cfde63..d2dc921 100644
--- a/drivers/cpufreq/cpufreq-cpu0.c
+++ b/drivers/cpufreq/cpufreq-cpu0.c
@@ -217,8 +217,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
 out_free_table:
 	dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table);
 out_put_clk:
-	if (!IS_ERR(cpu_clk))
-		clk_put(cpu_clk);
+	clk_put(cpu_clk);
 out_put_reg:
 	if (!IS_ERR(cpu_reg))
 		regulator_put(cpu_reg);
-- 
2.0.3.693.g996b0fd


  parent reply	other threads:[~2014-08-28  5:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  5:52 [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 01/10] cpufreq: Add support for per-policy driver data Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 02/10] cpufreq: cpu0: Update Module Author Viresh Kumar
2014-08-28  5:52 ` Viresh Kumar [this message]
2014-08-28  5:52 ` [PATCH V3 04/10] cpufreq: cpu0: print relevant error when we defer probe Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 05/10] cpufreq: cpu0: use dev_{err|warn|dbg} instead of pr_{err|warn|debug} Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 06/10] cpufreq: cpu0: Move per-cluster initialization code to ->init() Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 07/10] cpufreq: cpu0: try regulators with name "cpu-supply" Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 08/10] cpufreq: cpu0: Make allocate_resources() work for any CPU Viresh Kumar
2014-08-28  5:52 ` [PATCH V3 09/10] cpufreq: cpu0: rename driver and internals to 'cpufreq_generic' Viresh Kumar
2014-09-08 23:34   ` Rafael J. Wysocki
2014-09-08 23:18     ` Stephen Boyd
2014-09-08 23:39       ` Rafael J. Wysocki
2014-09-08 23:52         ` Rafael J. Wysocki
2014-09-09  0:01           ` Stephen Boyd
2014-09-09  4:47             ` Viresh Kumar
2014-09-09 13:29               ` Rafael J. Wysocki
2014-09-09 13:52                 ` Viresh Kumar
2014-09-09  0:02           ` Rafael J. Wysocki
2014-08-28  5:52 ` [PATCH V3 10/10] cpufreq: generic: set platform_{driver|device} '.name' to 'cpufreq-generic' Viresh Kumar
2014-08-28 14:16 ` [PATCH V3 00/10] CPUFreq: cpufreq-cpu0 updates for 3.{17|18 ?} Santosh Shilimkar
2014-09-01  6:40   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f6f0b21db83466aef5569fddcef76a3c9b7dc5a.1409201048.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pramod.gurav@smartplayin.com \
    --cc=rjw@rjwysocki.net \
    --cc=santosh.shilimkar@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=shawn.guo@linaro.org \
    --cc=spk.linux@gmail.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.ab@samsung.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.