From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <volodymyr_babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Shawn Anastasio" <sanastasio@raptorengineering.com>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: [PATCH] xenoprof: move asm/ include
Date: Mon, 30 Oct 2023 14:19:15 +0100 [thread overview]
Message-ID: <4fda4793-6fdc-70e6-575d-062f72c8c0dc@suse.com> (raw)
There's no need for xen/xenoprof.h to include the arch header when the
respective config option is off. The only compensation needed is for
svm.c to explicitly include the arch header instead of the common one
(matching what vmx.c and traps.c do).
With that Arm's header can be deleted, and neither RISC-V nor PPC will
need to introduce one.
While there also adjust and move the (prior) inclusion of inttypes.h.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/arm/include/asm/xenoprof.h
+++ /dev/null
@@ -1,12 +0,0 @@
-#ifndef __ASM_XENOPROF_H__
-#define __ASM_XENOPROF_H__
-
-#endif /* __ASM_XENOPROF_H__ */
-/*
- * Local variables:
- * mode: C
- * c-file-style: "BSD"
- * c-basic-offset: 4
- * indent-tabs-mode: nil
- * End:
- */
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -12,7 +12,6 @@
#include <xen/lib.h>
#include <xen/sched.h>
#include <xen/trace.h>
-#include <xen/xenoprof.h>
#include <asm/amd.h>
#include <asm/apic.h>
@@ -38,6 +37,7 @@
#include <asm/processor.h>
#include <asm/p2m.h>
#include <asm/x86_emulate.h>
+#include <asm/xenoprof.h>
#include <public/sched.h>
--- a/xen/include/xen/xenoprof.h
+++ b/xen/include/xen/xenoprof.h
@@ -10,15 +10,15 @@
#ifndef __XEN_XENOPROF_H__
#define __XEN_XENOPROF_H__
-#include <xen/inttypes.h>
-#include <asm/xenoprof.h>
-
#define PMU_OWNER_NONE 0
#define PMU_OWNER_XENOPROF 1
#define PMU_OWNER_HVM 2
#ifdef CONFIG_XENOPROF
+#include <xen/stdint.h>
+#include <asm/xenoprof.h>
+
struct domain;
struct vcpu;
struct cpu_user_regs;
next reply other threads:[~2023-10-30 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 13:19 Jan Beulich [this message]
2023-10-30 13:24 ` [PATCH] xenoprof: move asm/ include Jan Beulich
2023-10-30 14:03 ` Oleksii
2023-10-30 15:36 ` Bertrand Marquis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fda4793-6fdc-70e6-575d-062f72c8c0dc@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sanastasio@raptorengineering.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.