All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org
Subject: [PATCH 2/2] dmaengine: at_hdmac: Remove unused field values that do not fit
Date: Tue, 23 May 2023 14:42:55 +0200	[thread overview]
Message-ID: <5070ac45-2f91-c9d7-de7c-31d38750015e@axentia.se> (raw)
In-Reply-To: <dc4834cb-fadf-17a5-fbc7-cf500db88f20@axentia.se>

The values are not used, and they do not fit in the intended
register field (ATC_FC, 2 bits wide). Kill 'em all.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/dma/at_hdmac.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 6f352160bc3b..51d0a0c7aaf7 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -137,10 +137,6 @@
 #define ATC_FC_MEM2PER		0x1		/* Mem-to-Periph (DMA) */
 #define ATC_FC_PER2MEM		0x2		/* Periph-to-Mem (DMA) */
 #define ATC_FC_PER2PER		0x3		/* Periph-to-Periph (DMA) */
-#define ATC_FC_PER2MEM_PER	0x4		/* Periph-to-Mem (Peripheral) */
-#define ATC_FC_MEM2PER_PER	0x5		/* Mem-to-Periph (Peripheral) */
-#define ATC_FC_PER2PER_SRCPER	0x6		/* Periph-to-Periph (Src Peripheral) */
-#define ATC_FC_PER2PER_DSTPER	0x7		/* Periph-to-Periph (Dst Peripheral) */
 #define ATC_SRC_ADDR_MODE	GENMASK(25, 24)
 #define ATC_SRC_ADDR_MODE_INCR	0x0		/* Incrementing Mode */
 #define ATC_SRC_ADDR_MODE_DECR	0x1		/* Decrementing Mode */
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Peter Rosin <peda@axentia.se>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Vinod Koul <vkoul@kernel.org>,
	dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dmaengine: at_hdmac: Remove unused field values that do not fit
Date: Tue, 23 May 2023 14:42:55 +0200	[thread overview]
Message-ID: <5070ac45-2f91-c9d7-de7c-31d38750015e@axentia.se> (raw)
In-Reply-To: <dc4834cb-fadf-17a5-fbc7-cf500db88f20@axentia.se>

The values are not used, and they do not fit in the intended
register field (ATC_FC, 2 bits wide). Kill 'em all.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/dma/at_hdmac.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index 6f352160bc3b..51d0a0c7aaf7 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -137,10 +137,6 @@
 #define ATC_FC_MEM2PER		0x1		/* Mem-to-Periph (DMA) */
 #define ATC_FC_PER2MEM		0x2		/* Periph-to-Mem (DMA) */
 #define ATC_FC_PER2PER		0x3		/* Periph-to-Periph (DMA) */
-#define ATC_FC_PER2MEM_PER	0x4		/* Periph-to-Mem (Peripheral) */
-#define ATC_FC_MEM2PER_PER	0x5		/* Mem-to-Periph (Peripheral) */
-#define ATC_FC_PER2PER_SRCPER	0x6		/* Periph-to-Periph (Src Peripheral) */
-#define ATC_FC_PER2PER_DSTPER	0x7		/* Periph-to-Periph (Dst Peripheral) */
 #define ATC_SRC_ADDR_MODE	GENMASK(25, 24)
 #define ATC_SRC_ADDR_MODE_INCR	0x0		/* Incrementing Mode */
 #define ATC_SRC_ADDR_MODE_DECR	0x1		/* Decrementing Mode */
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-05-23 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-23 12:42 [PATCH 0/2] dmaengine: at_hdmac: Regression fix and cleanup Peter Rosin
2023-05-23 12:42 ` Peter Rosin
2023-05-23 12:42 ` [PATCH 1/2] dmaengine: at_hdmac: Repair bitfield macros for peripheral ID handling Peter Rosin
2023-05-23 12:42   ` Peter Rosin
2023-05-23 15:15   ` Tudor Ambarus
2023-05-23 15:15     ` Tudor Ambarus
2023-05-23 12:42 ` Peter Rosin [this message]
2023-05-23 12:42   ` [PATCH 2/2] dmaengine: at_hdmac: Remove unused field values that do not fit Peter Rosin
2023-05-23 14:04   ` Tudor Ambarus
2023-05-23 14:04     ` Tudor Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5070ac45-2f91-c9d7-de7c-31d38750015e@axentia.se \
    --to=peda@axentia.se \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.