All of lore.kernel.org
 help / color / mirror / Atom feed
From: vinholikatti@gmail.com
To: james.bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, santoshsy@gmail.com,
	patches@linaro.org, linux-samsung-soc@vger.kernel.org,
	arnd@linaro.org, saugata.das@linaro.org, venkat@linaro.org,
	subhashj@codeaurora.org, sthumma@codeaurora.org,
	vinholikatti@gmail.com
Subject: [PATCH V6 4/4] [SCSI] ufs: Correct the expected data transfersize
Date: Tue,  5 Feb 2013 22:17:37 +0530	[thread overview]
Message-ID: <511137e6.0657420a.5b57.ffffa80b@mx.google.com> (raw)
In-Reply-To: <1360082857-3317-1-git-send-email-y>

From: Vinayak Holikatti <vinholikatti@gmail.com>

This patch corrects the expected data transfer size of the
command UPIU. The current implementation of cmd->transfersize
is wrong as it probably equal to sector size. With this
implementation the transfer size is updated correctly

Reported-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Santosh Yaraganavi <santoshsy@gmail.com>
Signed-off-by: Vinayak Holikatti <vinholikatti@gmail.com>
---
 drivers/scsi/ufs/ufshcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 60fd40c..c32a478 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -478,7 +478,7 @@ static void ufshcd_compose_upiu(struct ufshcd_lrb *lrbp)
 		ucd_cmd_ptr->header.dword_2 = 0;
 
 		ucd_cmd_ptr->exp_data_transfer_len =
-			cpu_to_be32(lrbp->cmd->transfersize);
+			cpu_to_be32(lrbp->cmd->sdb.length);
 
 		memcpy(ucd_cmd_ptr->cdb,
 		       lrbp->cmd->cmnd,
-- 
1.7.5.4

      parent reply	other threads:[~2013-02-05 16:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1360082857-3317-1-git-send-email-y>
2013-02-05 16:47 ` [PATCH V6 1/4] [SCSI] drivers/scsi/ufs: Seggregate PCI Specific Code vinholikatti
2013-02-24  9:23   ` James Bottomley
2013-02-24 12:25     ` vinayak holikatti
2013-02-05 16:47 ` [PATCH V6 2/4] [SCSI] drivers/scsi/ufs: Separate PCI code into glue driver vinholikatti
2013-02-05 16:47 ` [PATCH V6 3/4] [SCSI] ufs: Add Platform glue driver for ufshcd vinholikatti
2013-02-05 16:47 ` vinholikatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=511137e6.0657420a.5b57.ffffa80b@mx.google.com \
    --to=vinholikatti@gmail.com \
    --cc=arnd@linaro.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=santoshsy@gmail.com \
    --cc=saugata.das@linaro.org \
    --cc=sthumma@codeaurora.org \
    --cc=subhashj@codeaurora.org \
    --cc=venkat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.