From: Santosh Shilimkar <santosh.shilimkar@ti.com> To: linux-omap@vger.kernel.org Cc: Kevin Hilman <khilman@linaro.org>, tony@atomide.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code Date: Thu, 28 Mar 2013 12:59:46 +0530 [thread overview] Message-ID: <5153F16A.5070307@ti.com> (raw) In-Reply-To: <51535AF4.3090607@ti.com> On Thursday 28 March 2013 02:17 AM, Santosh Shilimkar wrote: > On Thursday 28 March 2013 12:13 AM, Kevin Hilman wrote: >> Santosh Shilimkar <santosh.shilimkar@ti.com> writes: >> >>> This was added with intial port where OMAP PM support wasn't existing >>> and only simple WFI based hooks were used. >>> >>> This should have been cleaned up while adding the PM support but some >>> how fall through cracks. >> >> Changelog describes a bit of history, but does not it's no longer >> needed. >> > I thought "This should have been cleaned up while adding PM support" > means its no longer needed. At least I meant that way. > > Anyway I will just make it explicit. > For record, patch with updated changelog end of email. Regards, Santosh >From 4df9c29bf6eec23e99e83c9e1531603af69b4b42 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar <santosh.shilimkar@ti.com> Date: Sun, 10 Feb 2013 13:14:17 +0530 Subject: [PATCH v2 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code This was added with intial port where OMAP PM support wasn't existing and only simple WFI based hooks were used. This should have been cleaned up while adding the PM support but some how fall through cracks. So remove the cache flush code which is no longer needed now. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap2/omap-hotplug.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c index e712d17..458f72f 100644 --- a/arch/arm/mach-omap2/omap-hotplug.c +++ b/arch/arm/mach-omap2/omap-hotplug.c @@ -19,11 +19,8 @@ #include <linux/smp.h> #include <linux/io.h> -#include <asm/cacheflush.h> #include "omap-wakeupgen.h" - #include "common.h" - #include "powerdomain.h" /* @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu) unsigned int boot_cpu = 0; void __iomem *base = omap_get_wakeupgen_base(); - flush_cache_all(); - dsb(); - /* * we're ready for shutdown now, so do it */ -- 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code Date: Thu, 28 Mar 2013 12:59:46 +0530 [thread overview] Message-ID: <5153F16A.5070307@ti.com> (raw) In-Reply-To: <51535AF4.3090607@ti.com> On Thursday 28 March 2013 02:17 AM, Santosh Shilimkar wrote: > On Thursday 28 March 2013 12:13 AM, Kevin Hilman wrote: >> Santosh Shilimkar <santosh.shilimkar@ti.com> writes: >> >>> This was added with intial port where OMAP PM support wasn't existing >>> and only simple WFI based hooks were used. >>> >>> This should have been cleaned up while adding the PM support but some >>> how fall through cracks. >> >> Changelog describes a bit of history, but does not it's no longer >> needed. >> > I thought "This should have been cleaned up while adding PM support" > means its no longer needed. At least I meant that way. > > Anyway I will just make it explicit. > For record, patch with updated changelog end of email. Regards, Santosh >From 4df9c29bf6eec23e99e83c9e1531603af69b4b42 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar <santosh.shilimkar@ti.com> Date: Sun, 10 Feb 2013 13:14:17 +0530 Subject: [PATCH v2 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code This was added with intial port where OMAP PM support wasn't existing and only simple WFI based hooks were used. This should have been cleaned up while adding the PM support but some how fall through cracks. So remove the cache flush code which is no longer needed now. Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com> --- arch/arm/mach-omap2/omap-hotplug.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c index e712d17..458f72f 100644 --- a/arch/arm/mach-omap2/omap-hotplug.c +++ b/arch/arm/mach-omap2/omap-hotplug.c @@ -19,11 +19,8 @@ #include <linux/smp.h> #include <linux/io.h> -#include <asm/cacheflush.h> #include "omap-wakeupgen.h" - #include "common.h" - #include "powerdomain.h" /* @@ -35,9 +32,6 @@ void __ref omap4_cpu_die(unsigned int cpu) unsigned int boot_cpu = 0; void __iomem *base = omap_get_wakeupgen_base(); - flush_cache_all(); - dsb(); - /* * we're ready for shutdown now, so do it */ -- 1.7.9.5
next prev parent reply other threads:[~2013-03-28 7:27 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-20 15:18 [PATCH 0/9] ARM: OMAP: Static deps, fiq, omap-smp cleanup Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 1/9] ARM: OMAP4+: Use common scratchpad SAR RAM offsets for all architectures Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:41 ` Kevin Hilman 2013-03-27 18:41 ` Kevin Hilman 2013-03-27 20:49 ` Santosh Shilimkar 2013-03-27 20:49 ` Santosh Shilimkar 2013-03-27 20:49 ` Tony Lindgren 2013-03-27 20:49 ` Tony Lindgren 2013-03-27 20:52 ` Santosh Shilimkar 2013-03-27 20:52 ` Santosh Shilimkar 2013-03-28 7:32 ` Santosh Shilimkar 2013-03-28 7:32 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 2/9] ARM: OMAP1: PM: Remove bogus fiq_[enable/disable] tuple Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 16:09 ` Tony Lindgren 2013-02-20 16:09 ` Tony Lindgren 2013-02-20 16:14 ` Santosh Shilimkar 2013-02-20 16:14 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 3/9] ARM: OMAP2+: " Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:36 ` Kevin Hilman 2013-03-27 18:36 ` Kevin Hilman 2013-03-27 19:02 ` Santosh Shilimkar 2013-03-27 19:02 ` Santosh Shilimkar 2013-03-28 7:37 ` Santosh Shilimkar 2013-03-28 7:37 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 4/9] ARM: OMAP4+: Remove the un-necessary cache flush from hotplug code Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:43 ` Kevin Hilman 2013-03-27 18:43 ` Kevin Hilman 2013-03-27 20:47 ` Santosh Shilimkar 2013-03-27 20:47 ` Santosh Shilimkar 2013-03-28 7:29 ` Santosh Shilimkar [this message] 2013-03-28 7:29 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 5/9] ARM: OMAP4+: Remove un-necessary cacheflush in secondary CPU boot path Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 6/9] ARM: OMAP4+: Remove out of placed smp_wmb() in secondary wakeup code Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-02-21 12:55 ` Sergei Shtylyov 2013-02-21 12:55 ` Sergei Shtylyov 2013-02-21 12:59 ` Santosh Shilimkar 2013-02-21 12:59 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 7/9] ARM: OMAP4+: Move the CPU wakeup prepare code under smp_prepare_cpus() Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:45 ` Kevin Hilman 2013-03-27 18:45 ` Kevin Hilman 2013-03-27 19:04 ` Santosh Shilimkar 2013-03-27 19:04 ` Santosh Shilimkar 2013-03-27 19:54 ` Kevin Hilman 2013-03-27 19:54 ` Kevin Hilman 2013-03-27 20:50 ` Santosh Shilimkar 2013-03-27 20:50 ` Santosh Shilimkar 2013-03-28 7:35 ` Santosh Shilimkar 2013-03-28 7:35 ` Santosh Shilimkar 2013-03-28 9:46 ` Russell King - ARM Linux 2013-03-28 9:46 ` Russell King - ARM Linux 2013-03-28 9:58 ` Santosh Shilimkar 2013-03-28 9:58 ` Santosh Shilimkar 2013-03-28 12:04 ` Russell King - ARM Linux 2013-03-28 12:04 ` Russell King - ARM Linux 2013-03-28 12:09 ` Santosh Shilimkar 2013-03-28 12:09 ` Santosh Shilimkar 2013-02-20 15:18 ` [PATCH 8/9] ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 19:01 ` Peter Korsgaard 2013-03-27 19:01 ` Peter Korsgaard 2013-02-20 15:18 ` [PATCH 9/9] ARM: OMAP4: PM: Now remove L4 per clockdomain static depedency with MPU Santosh Shilimkar 2013-02-20 15:18 ` Santosh Shilimkar 2013-03-27 18:46 ` Kevin Hilman 2013-03-27 18:46 ` Kevin Hilman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5153F16A.5070307@ti.com \ --to=santosh.shilimkar@ti.com \ --cc=khilman@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.