All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
	linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
	Stephen Warren <swarren@nvidia.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched
Date: Fri, 12 Apr 2013 15:52:44 -0600	[thread overview]
Message-ID: <5168822C.6040303@wwwdotorg.org> (raw)
In-Reply-To: <5167BA67.5080403@synopsys.com>

On 04/12/2013 01:40 AM, Vineet Gupta wrote:
> On 04/09/2013 07:40 PM, Vineet Gupta wrote:
>> On 04/04/2013 11:06 PM, Stephen Warren wrote:
>>
>>> +.SECONDARY: $(obj)/%.dtb.S
>>> +
>>>  $(obj)/%.dtb.S: $(obj)/%.dtb
>>>         $(call cmd,dt_S_dtb)
>>>
>>> and no longer see make rm'ing the .dtb.S file. So, the .SECONDARY is
>>> behaving as expected, and should fix your problem.
>> Interestingly, if I make the file name explicit, .SECONDARY works for me too.
>>
>> .SECONDARY: $(obj)/angel4.dtb.S
>>
>> http://stackoverflow.com/questions/5426934/why-this-makefile-removes-my-goal
>>
>> Is this a make bug or is it related to when the rule is parsed by make !
>>
>> -Vineet
> 
> Ping ? Anyone know how to resolve this

After installing the ARC toolchain (which was a bit painful to track
down and install...) I reproduced your exact problem. I believe the
patch below fixes it:

diff --git a/arch/arc/boot/dts/Makefile b/arch/arc/boot/dts/Makefile
index 5776835..2f2cf23 100644
--- a/arch/arc/boot/dts/Makefile
+++ b/arch/arc/boot/dts/Makefile
@@ -8,6 +8,8 @@ endif
 obj-y   += $(builtindtb-y).dtb.o
 targets += $(builtindtb-y).dtb

+.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
+
 dtbs:  $(addprefix  $(obj)/, $(builtindtb-y).dtb)

 clean-files := *.dtb


  reply	other threads:[~2013-04-12 21:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  7:12 [PATCH] Kbuild: Avoid DTB rebuilds if source files are untouched Vineet Gupta
2013-04-03  7:12 ` Vineet Gupta
2013-04-03  7:14 ` Vineet Gupta
2013-04-03  7:14   ` Vineet Gupta
2013-04-03 16:18   ` Stephen Warren
2013-04-04  5:30     ` Vineet Gupta
2013-04-04  5:30       ` Vineet Gupta
2013-04-04 17:36       ` Stephen Warren
2013-04-09 13:37         ` Vineet Gupta
2013-04-09 13:37           ` Vineet Gupta
2013-04-09 14:10         ` Vineet Gupta
2013-04-09 14:10           ` Vineet Gupta
2013-04-12  7:40           ` Vineet Gupta
2013-04-12  7:40             ` Vineet Gupta
2013-04-12 21:52             ` Stephen Warren [this message]
2013-04-15 13:59               ` Vineet Gupta
2013-04-15 13:59                 ` Vineet Gupta
2013-04-15 17:12                 ` Stephen Warren
2013-04-16 15:53               ` James Hogan
2013-04-16 15:53                 ` James Hogan
2013-04-16 16:02                 ` James Hogan
2013-04-16 16:02                   ` James Hogan
2013-04-17  4:15                   ` Vineet Gupta
2013-04-17  4:15                     ` Vineet Gupta
2013-04-17  4:13                 ` Vineet Gupta
2013-04-17  4:13                   ` Vineet Gupta
2013-04-17  9:13                   ` James Hogan
2013-04-17  9:13                     ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5168822C.6040303@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=Vineet.Gupta1@synopsys.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sam@ravnborg.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.