All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Javi Merino <javi.merino@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Date: Wed, 17 Jul 2013 16:06:21 -0700	[thread overview]
Message-ID: <51E7236D.3010700@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1307171849180.14924@syhkavp.arg>

On 07/17/13 15:53, Nicolas Pitre wrote:
> On Wed, 17 Jul 2013, Stephen Boyd wrote:
>
>> On 07/17/13 15:34, Nicolas Pitre wrote:
>>> On Wed, 17 Jul 2013, Stephen Boyd wrote:
>>>
>>>> On 07/12/13 05:10, Stephen Boyd wrote:
>>>>> On 07/12, Javi Merino wrote:
>>>>>> I agree, we should drop the check.  It's annoying in uniprocessors and
>>>>>> unlikely to be found in the real world unless your gic entry in the dt
>>>>>> is wrong.
>>> And that's a likely outcome in the real world.
>>>
>>>>> Ok. How about this?
>>>> Any comments?
>>> What about this instead:
>> Unfortunately arm64 doesn't have SMP_ON_UP. 
> And why does that matter?

Because the gic driver is compiled on both arm and arm64? I suppose we
could define is_smp() to 1 on arm64 but its probably better to rely on
generic kernel things instead of arch specific functions.

>
>> It sounds like you preferred the first patch using num_possible_cpus()
> Probably, yes.  I didn't follow the early conversation though.

This was the first patch:

---8<----

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 19ceaa6..589c760 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -368,7 +368,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
 			break;
 	}
 
-	if (!mask)
+	if (!mask && num_possible_cpus() > 1)
 		pr_crit("GIC CPU mask not found - kernel will fail to boot.\n");
 
 	return mask;


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Date: Wed, 17 Jul 2013 16:06:21 -0700	[thread overview]
Message-ID: <51E7236D.3010700@codeaurora.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1307171849180.14924@syhkavp.arg>

On 07/17/13 15:53, Nicolas Pitre wrote:
> On Wed, 17 Jul 2013, Stephen Boyd wrote:
>
>> On 07/17/13 15:34, Nicolas Pitre wrote:
>>> On Wed, 17 Jul 2013, Stephen Boyd wrote:
>>>
>>>> On 07/12/13 05:10, Stephen Boyd wrote:
>>>>> On 07/12, Javi Merino wrote:
>>>>>> I agree, we should drop the check.  It's annoying in uniprocessors and
>>>>>> unlikely to be found in the real world unless your gic entry in the dt
>>>>>> is wrong.
>>> And that's a likely outcome in the real world.
>>>
>>>>> Ok. How about this?
>>>> Any comments?
>>> What about this instead:
>> Unfortunately arm64 doesn't have SMP_ON_UP. 
> And why does that matter?

Because the gic driver is compiled on both arm and arm64? I suppose we
could define is_smp() to 1 on arm64 but its probably better to rely on
generic kernel things instead of arch specific functions.

>
>> It sounds like you preferred the first patch using num_possible_cpus()
> Probably, yes.  I didn't follow the early conversation though.

This was the first patch:

---8<----

diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 19ceaa6..589c760 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -368,7 +368,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
 			break;
 	}
 
-	if (!mask)
+	if (!mask && num_possible_cpus() > 1)
 		pr_crit("GIC CPU mask not found - kernel will fail to boot.\n");
 
 	return mask;


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-07-17 23:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-05 23:39 [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system Stephen Boyd
2013-07-05 23:39 ` Stephen Boyd
2013-07-12 11:13 ` Javi Merino
2013-07-12 11:13   ` Javi Merino
2013-07-12 12:10   ` Stephen Boyd
2013-07-12 12:10     ` Stephen Boyd
2013-07-17 21:53     ` Stephen Boyd
2013-07-17 21:53       ` Stephen Boyd
2013-07-17 22:34       ` Nicolas Pitre
2013-07-17 22:34         ` Nicolas Pitre
2013-07-17 22:36         ` Stephen Boyd
2013-07-17 22:36           ` Stephen Boyd
2013-07-17 22:53           ` Nicolas Pitre
2013-07-17 22:53             ` Nicolas Pitre
2013-07-17 23:06             ` Stephen Boyd [this message]
2013-07-17 23:06               ` Stephen Boyd
2013-08-22 18:43               ` Stephen Boyd
2013-08-22 18:43                 ` Stephen Boyd
2013-08-22 18:59                 ` Nicolas Pitre
2013-08-22 18:59                   ` Nicolas Pitre
2013-08-23  4:35                   ` Stephen Boyd
2013-08-23  4:35                     ` Stephen Boyd
2013-08-23  4:51                     ` Nicolas Pitre
2013-08-23  4:51                       ` Nicolas Pitre
2013-08-23  9:15                       ` Russell King - ARM Linux
2013-08-23  9:15                         ` Russell King - ARM Linux
2013-07-20  7:27 ` Bedia, Vaibhav
2013-07-20  7:27   ` Bedia, Vaibhav
2013-07-23 17:01   ` Stephen Boyd
2013-07-23 17:01     ` Stephen Boyd
2015-01-31  0:43 Stephen Boyd
2015-01-31  0:43 ` Stephen Boyd
2015-01-31  7:09 ` Felipe Balbi
2015-01-31  7:09   ` Felipe Balbi
2015-01-31  7:09   ` Felipe Balbi
2015-02-12  3:51   ` Nishanth Menon
2015-02-12  3:51     ` Nishanth Menon
2015-02-12  3:51     ` Nishanth Menon
2015-02-01 21:25 ` Stefan Agner
2015-02-01 21:25   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E7236D.3010700@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=javi.merino@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.