[Ocfs2-devel] [PATCH] ocfs2: cleanup dead code in ocfs2_acl_from_xattr()

From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: cleanup dead code in ocfs2_acl_from_xattr()
Date: Tue, 30 Jul 2013 16:58:22 +0800	[thread overview]
Message-ID: <51F7802E.9080609@huawei.com> (raw)

In ocfs2_acl_from_xattr(), if size is less than
sizeof(struct posix_acl_entry), it returns ERR_PTR(-EINVAL) directly.
Then assign (size / sizeof(struct posix_acl_entry)) to count which will
be at least 1, that means the following branch (count < 0) and
(count == 0) will never be true.

Signed-off-by: Joseph Qi <joseph.qi@huawei.com>
---
 fs/ocfs2/acl.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index 8a40457..b4f788e 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -51,10 +51,6 @@ static struct posix_acl *ocfs2_acl_from_xattr(const void *value, size_t size)
 		return ERR_PTR(-EINVAL);
 
 	count = size / sizeof(struct posix_acl_entry);
-	if (count < 0)
-		return ERR_PTR(-EINVAL);
-	if (count == 0)
-		return NULL;
 
 	acl = posix_acl_alloc(count, GFP_NOFS);
 	if (!acl)
-- 
1.7.9.7
