From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
alevy@redhat.com
Subject: [PATCH -next] gpu: fix qxl missing crc32_le
Date: Fri, 20 Dec 2013 10:58:15 -0800 [thread overview]
Message-ID: <52B49347.3090209@infradead.org> (raw)
In-Reply-To: <20131220172503.b2b7cb92f437d974f032e1a4@canb.auug.org.au>
From: Randy Dunlap <rdunlap@infradead.org>
Fix build error: qxl uses crc32 functions so it needs to select
CRC32.
Also use angle quotes around a kernel header file name.
drivers/built-in.o: In function `qxl_display_read_client_monitors_config':
(.text+0x19d754): undefined reference to `crc32_le'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/gpu/drm/qxl/Kconfig | 1 +
drivers/gpu/drm/qxl/qxl_display.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20131220.orig/drivers/gpu/drm/qxl/qxl_display.c
+++ linux-next-20131220/drivers/gpu/drm/qxl/qxl_display.c
@@ -24,7 +24,7 @@
*/
-#include "linux/crc32.h"
+#include <linux/crc32.h>
#include "qxl_drv.h"
#include "qxl_object.h"
--- linux-next-20131220.orig/drivers/gpu/drm/qxl/Kconfig
+++ linux-next-20131220/drivers/gpu/drm/qxl/Kconfig
@@ -8,6 +8,7 @@ config DRM_QXL
select DRM_KMS_HELPER
select DRM_KMS_FB_HELPER
select DRM_TTM
+ select CRC32
help
QXL virtual GPU for Spice virtualization desktop integration.
Do not enable this driver unless your distro ships a corresponding
next prev parent reply other threads:[~2013-12-20 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 6:25 linux-next: Tree for Dec 20 Stephen Rothwell
2013-12-20 6:25 ` Stephen Rothwell
2013-12-20 18:58 ` Randy Dunlap [this message]
2013-12-20 20:52 ` linux-next: Tree for Dec 20 (brocade/bna) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B49347.3090209@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@linux.ie \
--cc=alevy@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.