From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: sage@inktank.com
Cc: ceph-devel@vger.kernel.org
Subject: [PATCH] ceph: remove useless ACL check
Date: Thu, 10 Apr 2014 13:29:17 +0800 [thread overview]
Message-ID: <53462C2D.1030803@huawei.com> (raw)
In-Reply-To: <1397107160-20844-1-git-send-email-zhenzhang.zhang@huawei.com>
posix_acl_xattr_set() already does the check, and it's the only
way to feed in an ACL from userspace.
So the check here is useless, remove it.
Signed-off-by: zhang zhen <zhenzhang.zhang@huawei.com>
---
fs/ceph/acl.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ceph/acl.c b/fs/ceph/acl.c
index 21887d6..469f2e8 100644
--- a/fs/ceph/acl.c
+++ b/fs/ceph/acl.c
@@ -104,12 +104,6 @@ int ceph_set_acl(struct inode *inode, struct posix_acl *acl, int type)
umode_t new_mode = inode->i_mode, old_mode = inode->i_mode;
struct dentry *dentry;
- if (acl) {
- ret = posix_acl_valid(acl);
- if (ret < 0)
- goto out;
- }
-
switch (type) {
case ACL_TYPE_ACCESS:
name = POSIX_ACL_XATTR_ACCESS;
--
1.8.5.5
.
next parent reply other threads:[~2014-04-10 5:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397107160-20844-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-04-10 5:29 ` Zhang Zhen [this message]
2014-04-10 8:16 ` [PATCH] ceph: remove useless ACL check Yan, Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53462C2D.1030803@huawei.com \
--to=zhenzhang.zhang@huawei.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.