All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <trblinux@gmail.com>
To: Laura Abbott <lauraa@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	Kevin Hilman <khilman@linaro.org>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robherring2@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linaro-kernel@lists.linaro.org, afaerber@suse.de,
	devicetree@vger.kernel.org
Subject: Re: [PATCHv2 1/3] of: Split early_init_dt_scan into two parts
Date: Wed, 02 Jul 2014 11:30:33 +0530	[thread overview]
Message-ID: <53B3A001.1090909@gmail.com> (raw)
In-Reply-To: <1404266608-3274-1-git-send-email-lauraa@codeaurora.org>

On 07/02/2014 07:33 AM, Laura Abbott wrote:
> Currently, early_init_dt_scan validates the header, sets the
> boot params, and scans for chosen/memory all in one function.
> Split this up into two separate functions (validation/setting
> boot params in one, scanning in another) to allow for
> additional setup between boot params and scanning the memory.
> 
> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
> ---

Tested the patchset on top of Linus' tree.

Verified after enabling following debug message.
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -865,7 +865,7 @@ int __init early_init_dt_scan_memory(unsigned long
node, const char *uname,

        endp = reg + (l / sizeof(__be32));

-       pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n",
+       pr_err("memory scan node %s, reg size %d, data: %x %x %x %x,\n",


Output before:
memory scan node memory, reg size 96, data: 20 10 30 10,

Output after:
memory scan node memory, reg size 64, data: 20 10 30 10,

Tested-by: Tushar Behera <trblinux@gmail.com>

One minor nit below ...

>  drivers/of/fdt.c       | 18 +++++++++++++++++-
>  include/linux/of_fdt.h |  2 ++
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index c4cddf0..55bfca9 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -922,7 +922,7 @@ int __init __weak early_init_dt_reserve_memory_arch(phys_addr_t base,
>  }
>  #endif
>  
> -bool __init early_init_dt_scan(void *params)
> +bool __init early_init_dt_verify(void *params)
>  {
>  	if (!params)
>  		return false;
> @@ -936,6 +936,12 @@ bool __init early_init_dt_scan(void *params)
>  		return false;
>  	}
>  
> +	return true;
> +}
> +
> +

Extra blank line here. Can be removed.

-- 
Tushar Behera

WARNING: multiple messages have this Message-ID (diff)
From: trblinux@gmail.com (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/3] of: Split early_init_dt_scan into two parts
Date: Wed, 02 Jul 2014 11:30:33 +0530	[thread overview]
Message-ID: <53B3A001.1090909@gmail.com> (raw)
In-Reply-To: <1404266608-3274-1-git-send-email-lauraa@codeaurora.org>

On 07/02/2014 07:33 AM, Laura Abbott wrote:
> Currently, early_init_dt_scan validates the header, sets the
> boot params, and scans for chosen/memory all in one function.
> Split this up into two separate functions (validation/setting
> boot params in one, scanning in another) to allow for
> additional setup between boot params and scanning the memory.
> 
> Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
> ---

Tested the patchset on top of Linus' tree.

Verified after enabling following debug message.
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -865,7 +865,7 @@ int __init early_init_dt_scan_memory(unsigned long
node, const char *uname,

        endp = reg + (l / sizeof(__be32));

-       pr_debug("memory scan node %s, reg size %d, data: %x %x %x %x,\n",
+       pr_err("memory scan node %s, reg size %d, data: %x %x %x %x,\n",


Output before:
memory scan node memory, reg size 96, data: 20 10 30 10,

Output after:
memory scan node memory, reg size 64, data: 20 10 30 10,

Tested-by: Tushar Behera <trblinux@gmail.com>

One minor nit below ...

>  drivers/of/fdt.c       | 18 +++++++++++++++++-
>  include/linux/of_fdt.h |  2 ++
>  2 files changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index c4cddf0..55bfca9 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -922,7 +922,7 @@ int __init __weak early_init_dt_reserve_memory_arch(phys_addr_t base,
>  }
>  #endif
>  
> -bool __init early_init_dt_scan(void *params)
> +bool __init early_init_dt_verify(void *params)
>  {
>  	if (!params)
>  		return false;
> @@ -936,6 +936,12 @@ bool __init early_init_dt_scan(void *params)
>  		return false;
>  	}
>  
> +	return true;
> +}
> +
> +

Extra blank line here. Can be removed.

-- 
Tushar Behera

  parent reply	other threads:[~2014-07-02  6:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02  2:03 [PATCHv2 1/3] of: Split early_init_dt_scan into two parts Laura Abbott
2014-07-02  2:03 ` Laura Abbott
2014-07-02  2:03 ` [PATCHv2 2/3] of: Add memory limiting function for flattened devicetrees Laura Abbott
2014-07-02  2:03   ` Laura Abbott
2014-07-02  2:03 ` [PATCHv2 3/3] arm: Add devicetree fixup machine function Laura Abbott
2014-07-02  2:03   ` Laura Abbott
2014-07-02  6:00 ` Tushar Behera [this message]
2014-07-02  6:00   ` [PATCHv2 1/3] of: Split early_init_dt_scan into two parts Tushar Behera
2014-07-08  0:54 ` Laura Abbott
2014-07-08  0:54   ` Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B3A001.1090909@gmail.com \
    --to=trblinux@gmail.com \
    --cc=afaerber@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=khilman@linaro.org \
    --cc=lauraa@codeaurora.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.