All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	linux-fsdevel@vger.kernel.org, kinglongmee@gmail.com
Subject: [PATCH 1/6 v5] NFSD: Remove the duplicate initialize of file_lock
Date: Wed, 20 Aug 2014 17:51:14 +0800	[thread overview]
Message-ID: <53F46F92.8000103@gmail.com> (raw)
In-Reply-To: <53F36CB5.2030707@gmail.com>

locks_alloc_lock() has initialize the struct file_lock,
so, don't need re-initialize it by locks_init_lock().

v5: same the first version, only cleanup

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Reviewed-by: Jeff Layton <jlayton@primarydata.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/nfsd/nfs4state.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 2e80a59..98edf97 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3759,7 +3759,6 @@ static struct file_lock *nfs4_alloc_init_lease(struct nfs4_file *fp, int flag)
 	fl = locks_alloc_lock();
 	if (!fl)
 		return NULL;
-	locks_init_lock(fl);
 	fl->fl_lmops = &nfsd_lease_mng_ops;
 	fl->fl_flags = FL_DELEG;
 	fl->fl_type = flag == NFS4_OPEN_DELEGATE_READ? F_RDLCK: F_WRLCK;
@@ -5210,7 +5209,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 	}
 
 	fp = lock_stp->st_stid.sc_file;
-	locks_init_lock(file_lock);
 	switch (lock->lk_type) {
 		case NFS4_READ_LT:
 		case NFS4_READW_LT:
@@ -5354,7 +5352,7 @@ nfsd4_lockt(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 		status = nfserr_jukebox;
 		goto out;
 	}
-	locks_init_lock(file_lock);
+
 	switch (lockt->lt_type) {
 		case NFS4_READ_LT:
 		case NFS4_READW_LT:
@@ -5432,7 +5430,7 @@ nfsd4_locku(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 		status = nfserr_jukebox;
 		goto fput;
 	}
-	locks_init_lock(file_lock);
+
 	file_lock->fl_type = F_UNLCK;
 	file_lock->fl_owner = (fl_owner_t)lockowner(stp->st_stateowner);
 	file_lock->fl_pid = current->tgid;
-- 
1.9.3


  reply	other threads:[~2014-08-20  9:51 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-07 14:12 [PATCH 2/4] NFSD: Rervert "knfsd: locks: flag NFSv4-owned locks" Kinglong Mee
2014-07-07 16:45 ` Jeff Layton
2014-07-08  2:30   ` Kinglong Mee
2014-07-07 17:26 ` Jeff Layton
2014-07-08  3:23   ` Kinglong Mee
2014-07-08 11:03     ` Jeff Layton
2014-07-08 12:26       ` Kinglong Mee
2014-07-08 12:39         ` Jeff Layton
2014-07-11 22:11           ` J. Bruce Fields
2014-08-02 14:45 ` [PATCH] fs/locks.c: Copy fl_lmops to conflock for nfsd using Kinglong Mee
2014-08-02 14:59   ` Trond Myklebust
     [not found]   ` <53DCF97D.3000605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-02 23:05     ` Jeff Layton
2014-08-02 23:05       ` Jeff Layton
     [not found]       ` <20140802190505.442f07b8-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-05 19:14         ` J. Bruce Fields
2014-08-05 19:14           ` J. Bruce Fields
     [not found]           ` <20140805191458.GV23341-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2014-08-05 19:20             ` Jeff Layton
2014-08-05 19:20               ` Jeff Layton
     [not found] ` <53BAAAC5.9000106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 13:33   ` [PATCH 1/3] NFSD: New FL_NFSD for marking file_lock belongs to NFSD Kinglong Mee
2014-08-06 13:33     ` Kinglong Mee
     [not found]     ` <53E22EA5.70708-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 13:35       ` [PATCH 2/3] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-06 13:35         ` Kinglong Mee
     [not found]         ` <53E22F2C.8070900-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-06 13:38           ` [PATCH 3/3 RFC] fs/locks.c: Copy all infomation for conflock Kinglong Mee
2014-08-06 13:38             ` Kinglong Mee
2014-08-09 11:08           ` [PATCH 2/3] NFSD: Increase the reference of lockowner when coping file_lock Jeff Layton
2014-08-09 11:08             ` Jeff Layton
     [not found]             ` <20140809070818.4d939a6a-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-10 15:47               ` Kinglong Mee
2014-08-10 15:47                 ` Kinglong Mee
2014-08-09 10:51     ` [PATCH 1/3] NFSD: New FL_NFSD for marking file_lock belongs to NFSD Jeff Layton
     [not found]       ` <20140809065112.700e0ecc-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-10 12:46         ` Kinglong Mee
2014-08-10 12:46           ` Kinglong Mee
2014-08-10 15:38         ` [PATCH 1/3 v2] fs/locks.c: Copy all information for conflock Kinglong Mee
2014-08-10 15:38           ` Kinglong Mee
2014-08-15  0:07           ` [PATCH 2/5 v3] locks: Copy all infomation " Kinglong Mee
     [not found]             ` <53ED4F30.4060308-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-15 11:14               ` Jeff Layton
2014-08-15 11:14                 ` Jeff Layton
     [not found]                 ` <20140815071450.498949d8-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-15 14:33                   ` Kinglong Mee
2014-08-15 14:33                     ` Kinglong Mee
     [not found]                     ` <53EE1A4E.1010707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-16 13:35                       ` Kinglong Mee
2014-08-16 13:35                         ` Kinglong Mee
     [not found]                         ` <53EF5E35.5090501-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-17 13:42                           ` Kinglong Mee
2014-08-17 13:42                             ` Kinglong Mee
     [not found]                             ` <53F0B13D.2040700-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-18 11:54                               ` Jeff Layton
2014-08-18 11:54                                 ` Jeff Layton
2014-08-19 15:10                                 ` Kinglong Mee
2014-08-15  0:10           ` [PATCH 4/5 v3] NFSD: New helper nfs4_get_stateowner() for atomic_inc reference Kinglong Mee
     [not found]           ` <53E791F1.40802-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-10 15:42             ` [PATCH 2/3 v2] fs/locks.c: New ops in file_lock_operations for copying/releasing owner Kinglong Mee
2014-08-10 15:42               ` Kinglong Mee
2014-08-10 15:43             ` [PATCH 3/3 v2] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-10 15:43               ` Kinglong Mee
     [not found]               ` <53E7933D.80504-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-11 16:46                 ` Jeff Layton
2014-08-11 16:46                   ` Jeff Layton
     [not found]                   ` <20140811124610.16f49168-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-14 12:30                     ` Kinglong Mee
2014-08-14 12:30                       ` Kinglong Mee
2014-08-11 16:19             ` [PATCH 1/3 v2] fs/locks.c: Copy all information for conflock Jeff Layton
2014-08-11 16:19               ` Jeff Layton
     [not found]               ` <20140811121949.4c3d7894-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-11 16:25                 ` Joe Perches
2014-08-11 16:25                   ` Joe Perches
2014-08-14 12:59                   ` Kinglong Mee
2014-08-14 12:59                     ` Kinglong Mee
2014-08-14 12:26                 ` Kinglong Mee
2014-08-14 12:26                   ` Kinglong Mee
2014-08-14 14:00                   ` Jeff Layton
     [not found]                     ` <20140814100025.2b2f72db-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-14 14:04                       ` Kinglong Mee
2014-08-14 14:04                         ` Kinglong Mee
2014-08-15  0:02             ` [PATCH 1/5 v3] NFSD: Remove duplicate initialization of file_lock Kinglong Mee
2014-08-15  0:02               ` Kinglong Mee
     [not found]               ` <53ED4E2F.2010701-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-15 10:57                 ` Jeff Layton
2014-08-15 10:57                   ` Jeff Layton
     [not found]                   ` <20140815065741.42f18ec9-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-15 21:35                     ` J. Bruce Fields
2014-08-15 21:35                       ` J. Bruce Fields
2014-08-15  0:09             ` [PATCH 3/5 v3] locks: New ops in file_lock_operations for copy/release owner Kinglong Mee
2014-08-15  0:09               ` Kinglong Mee
2014-08-15  0:13             ` [PATCH 5/5 v3] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-15  0:13               ` Kinglong Mee
2014-08-19 15:18               ` [PATCH 2/6 v4] locks: New ops in file_lock_operations for get/put owner Kinglong Mee
     [not found]                 ` <53F36AE2.7070507-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-19 19:42                   ` Jeff Layton
2014-08-19 19:42                     ` Jeff Layton
2014-08-19 15:21               ` [PATCH 3/6 v4] locks: Rename __locks_copy_lock() to locks_copy_conflock() Kinglong Mee
2014-08-19 19:46                 ` Jeff Layton
     [not found]               ` <53ED5093.6000308-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-19 15:16                 ` [PATCH 1/6 v4] NFSD: Remove the duplicate initialize of file_lock Kinglong Mee
2014-08-19 15:16                   ` Kinglong Mee
2014-08-19 15:24                 ` [PATCH 4/6 v4] locks: Copy fl_lmops information for conflock in, locks_copy_conflock() Kinglong Mee
2014-08-19 15:24                   ` Kinglong Mee
2014-08-19 20:08                   ` Jeff Layton
2014-08-19 15:25               ` [PATCH 5/6 v4] NFSD: New helper nfs4_get_stateowner() for atomic_inc sop reference Kinglong Mee
2014-08-19 20:14                 ` Jeff Layton
2014-08-19 15:26               ` [PATCH 6/6 v4] NFSD: Increase the reference of lockowner when coping file_lock Kinglong Mee
2014-08-20  9:51                 ` Kinglong Mee [this message]
     [not found]                 ` <53F36CB5.2030707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-19 20:23                   ` Jeff Layton
2014-08-19 20:23                     ` Jeff Layton
2014-08-19 20:24                     ` J. Bruce Fields
     [not found]                     ` <20140819162344.269953bd-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-20 10:02                       ` Kinglong Mee
2014-08-20 10:02                         ` Kinglong Mee
2014-08-20  9:53                   ` [PATCH 2/6 v5] locks: Rename __locks_copy_lock() to locks_copy_conflock() Kinglong Mee
2014-08-20  9:53                     ` Kinglong Mee
2014-08-20  9:54                   ` [PATCH 3/6 v5] locks: New ops in file_lock_operations for get/put owner Kinglong Mee
2014-08-20  9:54                     ` Kinglong Mee
2014-08-20  9:57                   ` [PATCH 5/6 v5] NFSD: New helper nfs4_get_stateowner() for atomic_inc sop reference Kinglong Mee
2014-08-20  9:57                     ` Kinglong Mee
2014-08-20  9:59                   ` [PATCH 6/6 v5] NFSD: Get reference of lockowner when coping file_lock Kinglong Mee
2014-08-20  9:59                     ` Kinglong Mee
2014-08-20  9:56                 ` [PATCH 4/6 v5] locks: Copy fl_lmops information for conflock in locks_copy_conflock() Kinglong Mee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F46F92.8000103@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=jeff.layton@primarydata.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.