All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jyri Sarha <jsarha@ti.com>
To: <dri-devel@lists.freedesktop.org>, <tony@atomide.com>,
	<sam@ravnborg.org>, <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>
Cc: <tomi.valkeinen@ti.com>, <laurent.pinchart@ideasonboard.com>,
	<peter.ujfalusi@ti.com>, <bparrot@ti.com>
Subject: [PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
Date: Mon, 9 Dec 2019 16:42:16 +0200	[thread overview]
Message-ID: <54966ffd61ca46528bc55961c532001aa7463c30.1575901747.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1575901747.git.jsarha@ti.com>

Add WARN() to the beginnig of tilcdc-panel probe. The obsolete
tilcdc-panel driver should not be used anymore, since tilcdc is fully
capable of using generic drm panels like panel-simple and panel-common
binding.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 5584e656b857..cf8e2462a524 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
 	struct pinctrl *pinctrl;
 	int ret;
 
+	/*
+	 * The obsolete tilcdc-panel driver should not be used
+         * anymore, since tilcdc is fully capable of using generic drm
+         * panels like panel-simple and panel-common binding.
+	 */
+
+	WARN(true,
+	     "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
+	     dev_name(&pdev->dev));
+
 	/* bail out early if no DT data: */
 	if (!node) {
 		dev_err(&pdev->dev, "device-tree data is missing\n");
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, tony@atomide.com,
	sam@ravnborg.org, robh+dt@kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org
Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com
Subject: [PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
Date: Mon, 9 Dec 2019 16:42:16 +0200	[thread overview]
Message-ID: <54966ffd61ca46528bc55961c532001aa7463c30.1575901747.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1575901747.git.jsarha@ti.com>

Add WARN() to the beginnig of tilcdc-panel probe. The obsolete
tilcdc-panel driver should not be used anymore, since tilcdc is fully
capable of using generic drm panels like panel-simple and panel-common
binding.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 5584e656b857..cf8e2462a524 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
 	struct pinctrl *pinctrl;
 	int ret;
 
+	/*
+	 * The obsolete tilcdc-panel driver should not be used
+         * anymore, since tilcdc is fully capable of using generic drm
+         * panels like panel-simple and panel-common binding.
+	 */
+
+	WARN(true,
+	     "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
+	     dev_name(&pdev->dev));
+
 	/* bail out early if no DT data: */
 	if (!node) {
 		dev_err(&pdev->dev, "device-tree data is missing\n");
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jyri Sarha <jsarha@ti.com>
To: <dri-devel@lists.freedesktop.org>, <tony@atomide.com>,
	<sam@ravnborg.org>,  <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>
Cc: peter.ujfalusi@ti.com, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com
Subject: [PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe
Date: Mon, 9 Dec 2019 16:42:16 +0200	[thread overview]
Message-ID: <54966ffd61ca46528bc55961c532001aa7463c30.1575901747.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1575901747.git.jsarha@ti.com>

Add WARN() to the beginnig of tilcdc-panel probe. The obsolete
tilcdc-panel driver should not be used anymore, since tilcdc is fully
capable of using generic drm panels like panel-simple and panel-common
binding.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 5584e656b857..cf8e2462a524 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -309,6 +309,16 @@ static int panel_probe(struct platform_device *pdev)
 	struct pinctrl *pinctrl;
 	int ret;
 
+	/*
+	 * The obsolete tilcdc-panel driver should not be used
+         * anymore, since tilcdc is fully capable of using generic drm
+         * panels like panel-simple and panel-common binding.
+	 */
+
+	WARN(true,
+	     "tilcdc-panel is obsolte and should not be used. Please update your configuration!\n",
+	     dev_name(&pdev->dev));
+
 	/* bail out early if no DT data: */
 	if (!node) {
 		dev_err(&pdev->dev, "device-tree data is missing\n");
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2019-12-09 14:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 14:42 [PATCH v2 0/3] drm/tilcdc: Remove "ti,tilcdc,tfp410" and mark "ti,tilcdc,panel" obsolete Jyri Sarha
2019-12-09 14:42 ` [PATCH v2 0/3] drm/tilcdc: Remove "ti, tilcdc, tfp410" and mark "ti, tilcdc, panel" obsolete Jyri Sarha
2019-12-09 14:42 ` Jyri Sarha
2019-12-09 14:42 ` [PATCH v2 1/3] drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver Jyri Sarha
2019-12-09 14:42   ` Jyri Sarha
2019-12-09 14:42   ` Jyri Sarha
2019-12-09 14:42 ` [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding Jyri Sarha
2019-12-09 14:42   ` [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti, tilcdc, panel" binding Jyri Sarha
2019-12-09 14:42   ` Jyri Sarha
2019-12-09 14:50   ` [PATCH v2 2/3] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding Laurent Pinchart
2019-12-09 14:50     ` Laurent Pinchart
2019-12-13  9:04     ` Jyri Sarha
2019-12-13  9:04       ` Jyri Sarha
2019-12-13  9:04       ` Jyri Sarha
2019-12-13 10:36       ` Laurent Pinchart
2019-12-13 10:36         ` Laurent Pinchart
2019-12-13 10:36         ` Laurent Pinchart
2019-12-09 14:42 ` Jyri Sarha [this message]
2019-12-09 14:42   ` [PATCH v2 3/3] drm/tilcdc: panel: Add WARN() with a comment to tilcdc-panel probe Jyri Sarha
2019-12-09 14:42   ` Jyri Sarha
2019-12-09 14:48   ` Laurent Pinchart
2019-12-09 14:48     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54966ffd61ca46528bc55961c532001aa7463c30.1575901747.git.jsarha@ti.com \
    --to=jsarha@ti.com \
    --cc=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.