From: Boaz Harrosh <boaz@plexistor.com> To: Ingo Molnar <mingo@redhat.com>, x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>, "Roger C. Pao" <rcpao.enmotus@gmail.com>, Dan Williams <dan.j.williams@intel.com>, Thomas Gleixner <tglx@linutronix.de>, linux-nvdimm <linux-nvdimm@lists.01.org>, "H. Peter Anvin" <hpa@zytor.com>, Matthew Wilcox <willy@linux.intel.com>, Andy Lutomirski <luto@amacapital.net>, Christoph Hellwig <hch@infradead.org> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Subject: [PATCH 8/8] OUT-OF-TREE: pmem: Allow request_mem to fail (BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET) Date: Thu, 05 Mar 2015 14:01:18 +0200 [thread overview] Message-ID: <54F8458E.2060202@plexistor.com> (raw) In-Reply-To: <54F830D4.7030205@plexistor.com> With old Kernels there was a bug in x86 where any unknown memory chip type would come up BUSY when calling request_mem_region_exclusive(). So for pmem to work with old Kernels and real NvDIMM chips we have a new Kconfig option CONFIG_BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET. People have been running with hacked up pmem that will ignore the return code from request_mem_region_exclusive. So here it is official Signed-off-by: Boaz Harrosh <boaz@plexistor.com> --- drivers/block/Kconfig | 12 ++++++++++++ drivers/block/pmem.c | 9 ++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 635fa6a..58a2c69 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -435,6 +435,18 @@ config BLK_DEV_PMEM_USE_PAGES to other devices in the system, then you must say "Yes" here. If unsure leave as Yes. +config BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET + bool "Ignore the return code from request_mem_region_exclusive" + depends on BLK_DEV_PMEM + help + In Old Kernels type-12 Memory type which is used by NvDIMM + chips Comes out busy when calling request_mem_region_exclusive, + because of a bug. + If this option is set to "yes". The pmem will ignore the + failure, and continue as usual. If you have an old Kernel and + a real NvDIMM chip you must say yes here. + (Ignored if BLK_DEV_PMEM_USE_PAGES=y) + config CDROM_PKTCDVD tristate "Packet writing on CD/DVD media" depends on !UML diff --git a/drivers/block/pmem.c b/drivers/block/pmem.c index d0c80f4..ba1167c 100644 --- a/drivers/block/pmem.c +++ b/drivers/block/pmem.c @@ -172,8 +172,10 @@ int pmem_mapmem(struct pmem_device *pmem) "pmem"); if (unlikely(!res_mem)) { pr_warn("pmem: request_mem_region_exclusive phys=0x%llx size=0x%zx failed\n", - pmem->phys_addr, pmem->size); - return -EINVAL; + pmem->phys_addr, pmem->size); +#ifndef CONFIG_BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET + return -EBUSY; +#endif } pmem->virt_addr = ioremap_cache(pmem->phys_addr, pmem->size); @@ -184,7 +186,8 @@ int pmem_mapmem(struct pmem_device *pmem) return 0; out_release: - release_mem_region(pmem->phys_addr, pmem->size); + if (res_mem) + release_mem_region(pmem->phys_addr, pmem->size); return err; } -- 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Boaz Harrosh <boaz@plexistor.com> To: Ingo Molnar <mingo@redhat.com>, x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>, "Roger C. Pao" <rcpao.enmotus@gmail.com>, Dan Williams <dan.j.williams@intel.com>, Thomas Gleixner <tglx@linutronix.de>, linux-nvdimm <linux-nvdimm@ml01.01.org>, "H. Peter Anvin" <hpa@zytor.com>, Matthew Wilcox <willy@linux.intel.com>, Andy Lutomirski <luto@amacapital.net>, Christoph Hellwig <hch@infradead.org> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Subject: [PATCH 8/8] OUT-OF-TREE: pmem: Allow request_mem to fail (BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET) Date: Thu, 05 Mar 2015 14:01:18 +0200 [thread overview] Message-ID: <54F8458E.2060202@plexistor.com> (raw) In-Reply-To: <54F830D4.7030205@plexistor.com> With old Kernels there was a bug in x86 where any unknown memory chip type would come up BUSY when calling request_mem_region_exclusive(). So for pmem to work with old Kernels and real NvDIMM chips we have a new Kconfig option CONFIG_BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET. People have been running with hacked up pmem that will ignore the return code from request_mem_region_exclusive. So here it is official Signed-off-by: Boaz Harrosh <boaz@plexistor.com> --- drivers/block/Kconfig | 12 ++++++++++++ drivers/block/pmem.c | 9 ++++++--- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index 635fa6a..58a2c69 100644 --- a/drivers/block/Kconfig +++ b/drivers/block/Kconfig @@ -435,6 +435,18 @@ config BLK_DEV_PMEM_USE_PAGES to other devices in the system, then you must say "Yes" here. If unsure leave as Yes. +config BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET + bool "Ignore the return code from request_mem_region_exclusive" + depends on BLK_DEV_PMEM + help + In Old Kernels type-12 Memory type which is used by NvDIMM + chips Comes out busy when calling request_mem_region_exclusive, + because of a bug. + If this option is set to "yes". The pmem will ignore the + failure, and continue as usual. If you have an old Kernel and + a real NvDIMM chip you must say yes here. + (Ignored if BLK_DEV_PMEM_USE_PAGES=y) + config CDROM_PKTCDVD tristate "Packet writing on CD/DVD media" depends on !UML diff --git a/drivers/block/pmem.c b/drivers/block/pmem.c index d0c80f4..ba1167c 100644 --- a/drivers/block/pmem.c +++ b/drivers/block/pmem.c @@ -172,8 +172,10 @@ int pmem_mapmem(struct pmem_device *pmem) "pmem"); if (unlikely(!res_mem)) { pr_warn("pmem: request_mem_region_exclusive phys=0x%llx size=0x%zx failed\n", - pmem->phys_addr, pmem->size); - return -EINVAL; + pmem->phys_addr, pmem->size); +#ifndef CONFIG_BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET + return -EBUSY; +#endif } pmem->virt_addr = ioremap_cache(pmem->phys_addr, pmem->size); @@ -184,7 +186,8 @@ int pmem_mapmem(struct pmem_device *pmem) return 0; out_release: - release_mem_region(pmem->phys_addr, pmem->size); + if (res_mem) + release_mem_region(pmem->phys_addr, pmem->size); return err; } -- 1.9.3
next prev parent reply other threads:[~2015-03-05 12:01 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-05 10:16 [PATCH 0/3 v5] e820: Fix handling of NvDIMM chips Boaz Harrosh 2015-03-05 10:16 ` Boaz Harrosh 2015-03-05 10:20 ` [PATCH 1/3] e820: Don't let unknown DIMM type come out BUSY Boaz Harrosh 2015-03-05 10:20 ` Boaz Harrosh 2015-03-05 20:41 ` Dan Williams 2015-03-05 20:41 ` Dan Williams 2015-03-09 10:54 ` Boaz Harrosh 2015-03-09 10:54 ` Boaz Harrosh 2015-03-05 10:21 ` [PATCH 2/3] resource: Add new flag IORESOURCE_MEM_WARN Boaz Harrosh 2015-03-05 10:21 ` Boaz Harrosh 2015-03-05 10:24 ` [PATCH 3/3] e820: Add the unknown-12 Memory type (DDR3-NvDIMM) Boaz Harrosh 2015-03-05 10:24 ` Boaz Harrosh 2015-03-05 20:56 ` Dan Williams 2015-03-05 20:56 ` Dan Williams 2015-03-05 23:09 ` Andy Lutomirski 2015-03-05 23:09 ` Andy Lutomirski 2015-03-09 12:10 ` Boaz Harrosh 2015-03-09 12:10 ` Boaz Harrosh 2015-03-10 5:11 ` joeyli 2015-03-10 5:11 ` joeyli 2015-03-10 8:56 ` Boaz Harrosh 2015-03-10 8:56 ` Boaz Harrosh 2015-03-10 13:19 ` Andy Lutomirski 2015-03-10 13:19 ` Andy Lutomirski 2015-03-09 11:19 ` Boaz Harrosh 2015-03-09 11:19 ` Boaz Harrosh 2015-03-09 14:44 ` Dan Williams 2015-03-09 14:44 ` Dan Williams 2015-03-09 15:14 ` Andy Lutomirski 2015-03-09 15:14 ` Andy Lutomirski 2015-03-09 15:17 ` Dan Williams 2015-03-09 15:17 ` Dan Williams 2015-03-10 8:47 ` Boaz Harrosh 2015-03-10 8:47 ` Boaz Harrosh 2015-03-05 10:32 ` [RFC 0/8] pmem: Submission of the Persistent memory block device Boaz Harrosh 2015-03-05 10:32 ` Boaz Harrosh 2015-03-05 11:55 ` [PATCH 1/8] pmem: Initial version of persistent memory driver Boaz Harrosh 2015-03-05 11:55 ` Boaz Harrosh 2015-03-05 20:35 ` Paul Bolle 2015-03-05 20:35 ` Paul Bolle 2015-03-05 23:03 ` Andy Lutomirski 2015-03-05 23:03 ` Andy Lutomirski 2015-03-09 12:20 ` Boaz Harrosh 2015-03-09 12:20 ` Boaz Harrosh 2015-03-18 18:06 ` Andy Lutomirski 2015-03-18 18:06 ` Andy Lutomirski 2015-03-26 4:00 ` Elliott, Robert (Server Storage) 2015-03-26 4:00 ` Elliott, Robert (Server Storage) 2015-03-26 7:51 ` Boaz Harrosh 2015-03-26 7:51 ` Boaz Harrosh 2015-03-26 21:31 ` Dave Chinner 2015-03-26 21:31 ` Dave Chinner 2015-03-18 17:43 ` Ross Zwisler 2015-03-18 17:43 ` Ross Zwisler 2015-03-19 9:24 ` Boaz Harrosh 2015-03-19 9:24 ` Boaz Harrosh 2015-03-20 0:11 ` Dan Williams 2015-03-20 0:11 ` Dan Williams 2015-03-05 11:55 ` [PATCH 2/8] pmem: KISS, remove register_blkdev Boaz Harrosh 2015-03-05 11:55 ` Boaz Harrosh 2015-03-05 11:56 ` [PATCH 3/8] pmem: Add support for rw_page() Boaz Harrosh 2015-03-05 11:56 ` Boaz Harrosh 2015-03-05 11:57 ` [PATCH 4/8] pmem: Add support for direct_access() Boaz Harrosh 2015-03-05 11:57 ` Boaz Harrosh 2015-03-05 11:58 ` [PATCH 5/8] mm: Let sparse_{add,remove}_one_section receive a node_id Boaz Harrosh 2015-03-05 11:58 ` Boaz Harrosh 2015-03-06 18:43 ` Ross Zwisler 2015-03-06 18:43 ` Ross Zwisler 2015-03-05 11:59 ` [PATCH 6/8] mm: New add_persistent_memory/remove_persistent_memory Boaz Harrosh 2015-03-05 11:59 ` Boaz Harrosh 2015-03-05 11:59 ` [PATCH 7/8] pmem: Add support for page structs Boaz Harrosh 2015-03-05 11:59 ` Boaz Harrosh 2015-03-23 20:59 ` Dan Williams 2015-03-23 20:59 ` Dan Williams 2015-03-05 12:01 ` Boaz Harrosh [this message] 2015-03-05 12:01 ` [PATCH 8/8] OUT-OF-TREE: pmem: Allow request_mem to fail (BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET) Boaz Harrosh 2015-03-06 18:37 ` [RFC 0/8] pmem: Submission of the Persistent memory block device Ross Zwisler 2015-03-06 18:37 ` Ross Zwisler 2015-03-07 1:39 ` Christoph Hellwig 2015-03-09 12:41 ` Boaz Harrosh 2015-03-09 12:41 ` Boaz Harrosh 2015-03-05 22:48 ` [PATCH 0/3 v5] e820: Fix handling of NvDIMM chips H. Peter Anvin 2015-03-05 23:06 ` Andy Lutomirski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=54F8458E.2060202@plexistor.com \ --to=boaz@plexistor.com \ --cc=dan.j.williams@intel.com \ --cc=hch@infradead.org \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=luto@amacapital.net \ --cc=mingo@redhat.com \ --cc=rcpao.enmotus@gmail.com \ --cc=ross.zwisler@linux.intel.com \ --cc=tglx@linutronix.de \ --cc=willy@linux.intel.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.