From: Stefan Bader <stefan.bader@canonical.com>
To: kvm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: regression: nested: L1 3.15+ fails to load kvm-intel on L0 <3.15
Date: Wed, 18 Mar 2015 09:46:10 +0100 [thread overview]
Message-ID: <55093B52.5090904@canonical.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
Someone reported[1] that some of their L1 guests fail to load the kvm-intel
module (without much details). Turns out that this was (at least) caused by
KVM: vmx: Allow the guest to run with dirty debug registers
as this adds VM_EXIT_SAVE_DEBUG_CONTROLS to the required MSR_IA32_VMX_EXIT_CTLS
bits. Not sure this should be fixed up in pre 3.15 kernels or the other way
round. Maybe naively asked but would it be sufficient to add this as required to
older kernels vmcs setup (without the code to make any use of it)?
Regardless of that, I wonder whether the below (this version untested) sound
acceptable for upstream? At least it would make debugging much simpler. :)
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2953,8 +2953,11 @@ static __init int adjust_vmx_controls(u32 ctl_min, u32 ct
ctl |= vmx_msr_low; /* bit == 1 in low word ==> must be one */
/* Ensure minimum (required) set of control bits are supported. */
- if (ctl_min & ~ctl)
+ if (ctl_min & ~ctl) {
+ printk(KERN_ERR "vmx: msr(%08x) does not match requirements. "
+ "req=%08x cur=%08x\n", msr, ctl_min, ctl);
return -EIO;
+ }
*result = ctl;
return 0;
Thanks,
-Stefan
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1431473
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next reply other threads:[~2015-03-18 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 8:46 Stefan Bader [this message]
2015-03-18 9:18 ` regression: nested: L1 3.15+ fails to load kvm-intel on L0 <3.15 Paolo Bonzini
2015-03-18 9:59 ` Stefan Bader
2015-03-18 10:27 ` Paolo Bonzini
2015-03-18 10:30 ` Stefan Bader
2015-03-19 19:58 ` regression: nested: L1 3.15+ fails to load kvm-intel on L0 <3.10 Stefan Bader
2015-03-19 20:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55093B52.5090904@canonical.com \
--to=stefan.bader@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.