From: Roger Quadros <rogerq@ti.com> To: wg@grandegger.com, mkl@pengutronix.de, tony@atomide.com Cc: jay.schroeder@garmin.com, linux-can@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, Grygorii Strashko <grygorii.strashko@ti.com> Subject: [PATCH v2 1/2] net: can: c_can: Fix default pinmux glitch at init Date: Wed, 8 Jul 2015 14:38:12 +0300 [thread overview] Message-ID: <559D0BA4.9000000@ti.com> (raw) In-Reply-To: <1436279277-3386-2-git-send-email-rogerq@ti.com> From: "J.D. Schroeder" <jay.schroeder@garmin.com> The previous change 3973c526ae9c (net: can: c_can: Disable pins when CAN interface is down) causes a slight glitch on the pinctrl settings when used. Since commit ab78029 (drivers/pinctrl: grab default handles from device core), the device core will automatically set the default pins. This causes the pins to be momentarily set to the default and then to the sleep state in register_c_can_dev(). By adding an optional "enable" state, boards can set the default pin state to be disabled and avoid the glitch when the switch from default to sleep first occurs. If the "enable" state is not available c_can_pinctrl_select_state() falls back to using the "default" pinctrl state. [Roger Q] - Forward port to v4.2 and use pinctrl_get_select(). Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- drivers/net/can/c_can/c_can.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 041525d..5d214d1 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -592,6 +592,7 @@ static int c_can_start(struct net_device *dev) { struct c_can_priv *priv = netdev_priv(dev); int err; + struct pinctrl *p; /* basic c_can configuration */ err = c_can_chip_config(dev); @@ -604,8 +605,13 @@ static int c_can_start(struct net_device *dev) priv->can.state = CAN_STATE_ERROR_ACTIVE; - /* activate pins */ - pinctrl_pm_select_default_state(dev->dev.parent); + /* Attempt to use "active" if available else use "default" */ + p = pinctrl_get_select(priv->device, "active"); + if (!IS_ERR(p)) + pinctrl_put(p); + else + pinctrl_pm_select_default_state(priv->device); + return 0; } -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com> To: <wg@grandegger.com>, <mkl@pengutronix.de>, <tony@atomide.com> Cc: <jay.schroeder@garmin.com>, <linux-can@vger.kernel.org>, <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Grygorii Strashko <grygorii.strashko@ti.com> Subject: [PATCH v2 1/2] net: can: c_can: Fix default pinmux glitch at init Date: Wed, 8 Jul 2015 14:38:12 +0300 [thread overview] Message-ID: <559D0BA4.9000000@ti.com> (raw) In-Reply-To: <1436279277-3386-2-git-send-email-rogerq@ti.com> From: "J.D. Schroeder" <jay.schroeder@garmin.com> The previous change 3973c526ae9c (net: can: c_can: Disable pins when CAN interface is down) causes a slight glitch on the pinctrl settings when used. Since commit ab78029 (drivers/pinctrl: grab default handles from device core), the device core will automatically set the default pins. This causes the pins to be momentarily set to the default and then to the sleep state in register_c_can_dev(). By adding an optional "enable" state, boards can set the default pin state to be disabled and avoid the glitch when the switch from default to sleep first occurs. If the "enable" state is not available c_can_pinctrl_select_state() falls back to using the "default" pinctrl state. [Roger Q] - Forward port to v4.2 and use pinctrl_get_select(). Signed-off-by: J.D. Schroeder <jay.schroeder@garmin.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- drivers/net/can/c_can/c_can.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c index 041525d..5d214d1 100644 --- a/drivers/net/can/c_can/c_can.c +++ b/drivers/net/can/c_can/c_can.c @@ -592,6 +592,7 @@ static int c_can_start(struct net_device *dev) { struct c_can_priv *priv = netdev_priv(dev); int err; + struct pinctrl *p; /* basic c_can configuration */ err = c_can_chip_config(dev); @@ -604,8 +605,13 @@ static int c_can_start(struct net_device *dev) priv->can.state = CAN_STATE_ERROR_ACTIVE; - /* activate pins */ - pinctrl_pm_select_default_state(dev->dev.parent); + /* Attempt to use "active" if available else use "default" */ + p = pinctrl_get_select(priv->device, "active"); + if (!IS_ERR(p)) + pinctrl_put(p); + else + pinctrl_pm_select_default_state(priv->device); + return 0; } -- 2.1.4
next prev parent reply other threads:[~2015-07-08 11:38 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-07 14:27 [PATCH 0/2] ARM: dra7: fix DCAN glitch Roger Quadros 2015-07-07 14:27 ` Roger Quadros 2015-07-07 14:27 ` [PATCH 1/2] net: can: c_can: Fix default pinmux glitch at init Roger Quadros 2015-07-07 14:27 ` Roger Quadros 2015-07-07 14:33 ` Marc Kleine-Budde 2015-07-07 14:35 ` Roger Quadros 2015-07-07 14:35 ` Roger Quadros 2015-07-07 14:37 ` Roger Quadros 2015-07-07 14:37 ` Roger Quadros 2015-07-07 14:43 ` Marc Kleine-Budde 2015-07-08 8:09 ` Roger Quadros 2015-07-08 8:09 ` Roger Quadros 2015-07-08 8:17 ` Marc Kleine-Budde 2015-07-07 15:49 ` Grygorii Strashko 2015-07-07 15:49 ` Grygorii Strashko 2015-07-08 8:13 ` Roger Quadros 2015-07-08 8:13 ` Roger Quadros 2015-07-08 10:31 ` Grygorii Strashko 2015-07-08 10:31 ` Grygorii Strashko 2015-07-08 10:44 ` Roger Quadros 2015-07-08 10:44 ` Roger Quadros 2015-07-08 11:38 ` Roger Quadros [this message] 2015-07-08 11:38 ` [PATCH v2 " Roger Quadros 2015-07-09 10:58 ` Grygorii Strashko 2015-07-09 10:58 ` Grygorii Strashko 2015-07-09 10:59 ` Marc Kleine-Budde 2015-07-09 11:19 ` Grygorii Strashko 2015-07-09 11:19 ` Grygorii Strashko 2015-07-07 14:27 ` [PATCH 2/2] ARM: dts: dra7x-evm: Prevent glitch on DCAN1 pinmux Roger Quadros 2015-07-07 14:27 ` Roger Quadros 2015-07-09 18:34 ` Marc Kleine-Budde 2015-07-12 19:18 ` Marc Kleine-Budde 2015-07-13 6:29 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=559D0BA4.9000000@ti.com \ --to=rogerq@ti.com \ --cc=grygorii.strashko@ti.com \ --cc=jay.schroeder@garmin.com \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=mkl@pengutronix.de \ --cc=tony@atomide.com \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.