From: Sudeep Holla <sudeep.holla@arm.com> To: Stephen Boyd <sboyd@codeaurora.org> Cc: Sudeep Holla <sudeep.holla@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Liviu Dudau <Liviu.Dudau@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, "Jon Medhurst (Tixy)" <tixy@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Kevin Hilman <khilman@kernel.org>, Olof Johansson <olof@lixom.net>, Mike Turquette <mturquette@baylibre.com> Subject: Re: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor) Date: Wed, 22 Jul 2015 15:19:17 +0100 [thread overview] Message-ID: <55AFA665.4020906@arm.com> (raw) In-Reply-To: <55AE8A02.9070801@codeaurora.org> On 21/07/15 19:05, Stephen Boyd wrote: > On 07/20/2015 01:54 AM, Sudeep Holla wrote: >> >> >> On 17/07/15 19:13, Stephen Boyd wrote: >>> On 07/17/2015 04:17 AM, Sudeep Holla wrote: >> >> [...] >> >>>> >>>> determine_rate change shouldn't affect SCPI clock driver but I remember >>>> seeing round_rate change too on the list which returns value using the >>>> argument from Boris. Is that planned for v4.3 ? I would need the stable >>>> branch from this clk_hw_set_rate_range if you decide to push. Let me >>>> know your preferences. I will post the updated version of the patch >>>> accordingly. >>>> >>> >>> We're not going to change round_rate() so it sounds like you don't need >>> a stable branch. But you would need this new consumer API. So you still >>> need a branch right? >>> >> >> I am fine either way. If no one else need the stable branch to be shared >> with arm-soc, I prefer to use clock consumer API for now to avoid all >> the troubles to you guys and switch to provider API later. I will post >> it once the both this driver and that provider API is merged, if that's >> fine with you ? > > Ok. Sounds fine as long as we don't forget. > It's ready indeed :), will post it when everything is in place. Regards, Sudeep --->8 From 3ddf7fe5b1286efa712d4f2ba8108ce1855f3e74 Mon Sep 17 00:00:00 2001 From: Sudeep Holla <sudeep.holla@arm.com> Date: Fri, 17 Jul 2015 12:19:54 +0100 Subject: [PATCH] clk: scpi: use provider clk_hw_set_rate_range API instead of consumer API SCPI clock provider uses the consumer API clk_set_rate_range to set min/max rate constraints on the clocks it provides. Commit c87c640f915a ("clk: Allow providers to configure min/max rates") added a separate provider API clk_hw_set_rate_range to set the min/max rate of a clock. This patch switches away from clk_set_rate_range consumer API to clk_hw_set_rate_range provider API. Cc: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/clk/clk-scpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 06d0558e8f46..f7c8b7a03cfe 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -174,7 +174,7 @@ scpi_clk_ops_init(struct device *dev, const struct of_device_id *match, clk = devm_clk_register(dev, &sclk->hw); if (!IS_ERR(clk) && max) - clk_set_rate_range(clk, min, max); + clk_hw_set_rate_range(&sclk->hw, min, max); return clk; } -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor) Date: Wed, 22 Jul 2015 15:19:17 +0100 [thread overview] Message-ID: <55AFA665.4020906@arm.com> (raw) In-Reply-To: <55AE8A02.9070801@codeaurora.org> On 21/07/15 19:05, Stephen Boyd wrote: > On 07/20/2015 01:54 AM, Sudeep Holla wrote: >> >> >> On 17/07/15 19:13, Stephen Boyd wrote: >>> On 07/17/2015 04:17 AM, Sudeep Holla wrote: >> >> [...] >> >>>> >>>> determine_rate change shouldn't affect SCPI clock driver but I remember >>>> seeing round_rate change too on the list which returns value using the >>>> argument from Boris. Is that planned for v4.3 ? I would need the stable >>>> branch from this clk_hw_set_rate_range if you decide to push. Let me >>>> know your preferences. I will post the updated version of the patch >>>> accordingly. >>>> >>> >>> We're not going to change round_rate() so it sounds like you don't need >>> a stable branch. But you would need this new consumer API. So you still >>> need a branch right? >>> >> >> I am fine either way. If no one else need the stable branch to be shared >> with arm-soc, I prefer to use clock consumer API for now to avoid all >> the troubles to you guys and switch to provider API later. I will post >> it once the both this driver and that provider API is merged, if that's >> fine with you ? > > Ok. Sounds fine as long as we don't forget. > It's ready indeed :), will post it when everything is in place. Regards, Sudeep --->8 From 3ddf7fe5b1286efa712d4f2ba8108ce1855f3e74 Mon Sep 17 00:00:00 2001 From: Sudeep Holla <sudeep.holla@arm.com> Date: Fri, 17 Jul 2015 12:19:54 +0100 Subject: [PATCH] clk: scpi: use provider clk_hw_set_rate_range API instead of consumer API SCPI clock provider uses the consumer API clk_set_rate_range to set min/max rate constraints on the clocks it provides. Commit c87c640f915a ("clk: Allow providers to configure min/max rates") added a separate provider API clk_hw_set_rate_range to set the min/max rate of a clock. This patch switches away from clk_set_rate_range consumer API to clk_hw_set_rate_range provider API. Cc: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/clk/clk-scpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 06d0558e8f46..f7c8b7a03cfe 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -174,7 +174,7 @@ scpi_clk_ops_init(struct device *dev, const struct of_device_id *match, clk = devm_clk_register(dev, &sclk->hw); if (!IS_ERR(clk) && max) - clk_set_rate_range(clk, min, max); + clk_hw_set_rate_range(&sclk->hw, min, max); return clk; } -- 1.9.1
next prev parent reply other threads:[~2015-07-22 14:19 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-08 10:39 [PATCH v4 0/8] ARM64: juno: add SCPI mailbox protocol, clock and CPUFreq support Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-06-08 10:39 ` [PATCH v4 1/8] Documentation: add DT binding for ARM System Control and Power Interface(SCPI) protocol Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-07-08 13:59 ` Sudeep Holla 2015-07-08 13:59 ` Sudeep Holla 2015-07-08 13:59 ` Sudeep Holla 2015-07-22 8:43 ` Liviu Dudau 2015-07-22 8:43 ` Liviu Dudau 2015-07-22 8:43 ` Liviu Dudau 2015-07-22 8:43 ` Liviu Dudau 2015-07-22 9:25 ` Sudeep Holla 2015-07-22 9:25 ` Sudeep Holla 2015-07-22 9:25 ` Sudeep Holla 2015-07-22 9:55 ` Mark Rutland 2015-07-22 9:55 ` Mark Rutland 2015-07-22 9:55 ` Mark Rutland 2015-07-22 15:56 ` Sudeep Holla 2015-07-22 15:56 ` Sudeep Holla 2015-07-22 15:56 ` Sudeep Holla 2015-07-22 15:56 ` Sudeep Holla 2015-07-22 16:23 ` Mark Rutland 2015-07-22 16:23 ` Mark Rutland 2015-07-22 16:23 ` Mark Rutland 2015-06-08 10:39 ` [PATCH v4 2/8] firmware: add support " Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-06-11 11:54 ` Jassi Brar 2015-06-11 11:54 ` Jassi Brar 2015-06-11 11:54 ` Jassi Brar 2015-06-11 13:23 ` Sudeep Holla 2015-06-11 13:23 ` Sudeep Holla 2015-06-11 13:23 ` Sudeep Holla 2015-06-08 10:39 ` [PATCH v4 3/8] clk: add support for clocks provided by SCP(System Control Processor) Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-07-02 17:23 ` Stephen Boyd 2015-07-02 17:23 ` Stephen Boyd 2015-07-03 14:52 ` Sudeep Holla 2015-07-03 14:52 ` Sudeep Holla 2015-07-03 14:52 ` Sudeep Holla 2015-07-03 16:12 ` Sudeep Holla 2015-07-03 16:12 ` Sudeep Holla 2015-07-03 16:12 ` Sudeep Holla 2015-07-06 19:52 ` Stephen Boyd 2015-07-06 19:52 ` Stephen Boyd 2015-07-06 19:52 ` Stephen Boyd 2015-07-07 16:03 ` Sudeep Holla 2015-07-07 16:03 ` Sudeep Holla 2015-07-07 16:03 ` Sudeep Holla 2015-07-08 1:46 ` Stephen Boyd 2015-07-08 1:46 ` Stephen Boyd 2015-07-08 1:46 ` Stephen Boyd 2015-07-16 16:11 ` Sudeep Holla 2015-07-16 16:11 ` Sudeep Holla 2015-07-16 16:11 ` Sudeep Holla 2015-07-16 19:31 ` Stephen Boyd 2015-07-16 19:31 ` Stephen Boyd 2015-07-16 19:31 ` Stephen Boyd 2015-07-17 11:17 ` Sudeep Holla 2015-07-17 11:17 ` Sudeep Holla 2015-07-17 11:17 ` Sudeep Holla 2015-07-17 18:13 ` Stephen Boyd 2015-07-17 18:13 ` Stephen Boyd 2015-07-17 18:13 ` Stephen Boyd 2015-07-20 8:54 ` Sudeep Holla 2015-07-20 8:54 ` Sudeep Holla 2015-07-20 8:54 ` Sudeep Holla 2015-07-21 18:05 ` Stephen Boyd 2015-07-21 18:05 ` Stephen Boyd 2015-07-21 18:05 ` Stephen Boyd 2015-07-22 14:19 ` Sudeep Holla [this message] 2015-07-22 14:19 ` Sudeep Holla 2015-07-22 14:19 ` Sudeep Holla 2015-06-08 10:39 ` [PATCH v4 4/8] clk: scpi: add support for cpufreq virtual device Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-06-08 10:39 ` [PATCH v4 5/8] cpufreq: arm_big_little: add SCPI interface driver Sudeep Holla 2015-06-08 10:39 ` Sudeep Holla 2015-06-08 10:40 ` [PATCH v4 6/8] arm64: dts: add SRAM, MHU mailbox and SCPI support on Juno Sudeep Holla 2015-06-08 10:40 ` Sudeep Holla 2015-06-08 13:51 ` Jon Medhurst (Tixy) 2015-06-08 13:51 ` Jon Medhurst (Tixy) 2015-06-08 14:32 ` Sudeep Holla 2015-06-08 14:32 ` Sudeep Holla 2015-06-08 14:32 ` Sudeep Holla 2015-06-08 14:35 ` Liviu Dudau 2015-06-08 14:35 ` Liviu Dudau 2015-06-08 14:35 ` Liviu Dudau 2015-07-22 13:28 ` Liviu Dudau 2015-07-22 13:28 ` Liviu Dudau 2015-07-22 13:28 ` Liviu Dudau 2015-07-22 15:40 ` Sudeep Holla 2015-07-22 15:40 ` Sudeep Holla 2015-07-22 15:40 ` Sudeep Holla 2015-07-22 16:06 ` Liviu Dudau 2015-07-22 16:06 ` Liviu Dudau 2015-07-22 16:06 ` Liviu Dudau 2015-07-22 16:16 ` Sudeep Holla 2015-07-22 16:16 ` Sudeep Holla 2015-07-22 16:16 ` Sudeep Holla 2015-06-08 10:40 ` [PATCH v4 7/8] arm64: dts: add CPU topology " Sudeep Holla 2015-06-08 10:40 ` Sudeep Holla 2015-07-22 13:31 ` Liviu Dudau 2015-07-22 13:31 ` Liviu Dudau 2015-07-22 13:31 ` Liviu Dudau 2015-06-08 10:40 ` [PATCH v4 8/8] arm64: dts: add clock support for all the cpus Sudeep Holla 2015-06-08 10:40 ` Sudeep Holla 2015-07-22 13:32 ` Liviu Dudau 2015-07-22 13:32 ` Liviu Dudau 2015-07-22 13:32 ` Liviu Dudau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=55AFA665.4020906@arm.com \ --to=sudeep.holla@arm.com \ --cc=Liviu.Dudau@arm.com \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=arnd@arndb.de \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=olof@lixom.net \ --cc=sboyd@codeaurora.org \ --cc=tixy@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.