From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Janusz <januszmk6@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpeng.li@hotmail.com>,
Laszlo Ersek <lersek@redhat.com>,
kvm@vger.kernel.org
Cc: edk2-devel@ml01.01.org
Subject: Re: [edk2] KVM: MTRR: fix memory type handling if MTRR is completely disabled
Date: Wed, 14 Oct 2015 11:58:36 +0800 [thread overview]
Message-ID: <561DD2EC.5040800@linux.intel.com> (raw)
In-Reply-To: <560E96D8.9080007@gmail.com>
Janusz,
Could you please try this:
$ git diff
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 185fc16..bdd564f 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4957,12 +4957,14 @@ static int handle_emulation_failure(struct kvm_vcpu *vcpu)
++vcpu->stat.insn_emulation_fail;
trace_kvm_emulate_insn_failed(vcpu);
+#if 0
if (!is_guest_mode(vcpu) && kvm_x86_ops->get_cpl(vcpu) == 0) {
vcpu->run->exit_reason = KVM_EXIT_INTERNAL_ERROR;
vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_EMULATION;
vcpu->run->internal.ndata = 0;
r = EMULATE_FAIL;
}
+#endif
kvm_queue_exception(vcpu, UD_VECTOR);
return r;
To see if the issue still there?
On 10/02/2015 10:38 PM, Janusz wrote:
> W dniu 01.10.2015 o 16:18, Paolo Bonzini pisze:
>>
>> On 01/10/2015 16:12, Janusz wrote:
>>> Now, I can also add, that the problem is only when I allow VM to use
>>> more than one core, so with option for example:
>>> -smp 8,cores=4,threads=2,sockets=1 and other combinations like -smp
>>> 4,threads=1 its not working, and without it I am always running VM
>>> without problems
>>>
>>> Any ideas what can it be? or any idea what would help to find out what
>>> is causing this?
>> I am going to send a revert of the patch tomorrow.
>>
>> Paolo
> Thanks, but revert patch doesn't help, so something else is wrong here
>
next prev parent reply other threads:[~2015-10-14 4:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 9:37 [edk2] KVM: MTRR: fix memory type handling if MTRR is completely disabled Janusz
2015-09-18 10:07 ` Laszlo Ersek
2015-09-18 17:48 ` Janusz
2015-09-21 2:51 ` Xiao Guangrong
2015-09-21 3:30 ` Wanpeng Li
2015-09-21 3:40 ` Xiao Guangrong
2015-10-01 14:12 ` Janusz
2015-10-01 14:18 ` Paolo Bonzini
2015-10-02 14:38 ` Janusz
2015-10-10 20:07 ` Xiao Guangrong
2015-10-12 18:20 ` Xiao Guangrong
2015-10-12 18:29 ` Xiao Guangrong
2015-10-14 3:58 ` Xiao Guangrong [this message]
2015-10-14 7:37 ` Janusz
2015-10-14 8:24 ` Xiao Guangrong
2015-10-14 8:32 ` Xiao Guangrong
2015-10-14 9:13 ` Janusz
2015-10-14 9:16 ` Janusz
2015-10-14 9:47 ` Laszlo Ersek
2015-10-15 3:59 ` Xiao Guangrong
2015-10-14 18:08 ` Janusz
2015-10-15 4:19 ` Xiao Guangrong
2015-10-15 6:19 ` Janusz
2015-10-15 6:41 ` Xiao Guangrong
2015-10-15 6:58 ` Janusz
2015-10-15 7:10 ` Xiao Guangrong
2015-10-15 7:21 ` Janusz
2015-10-15 16:18 ` Laszlo Ersek
2015-10-15 16:53 ` Kinney, Michael D
2015-10-15 18:46 ` Laszlo Ersek
2015-10-20 17:27 ` Janusz
2015-10-20 17:44 ` Laszlo Ersek
2015-10-20 18:52 ` Janusz Mocek
[not found] ` <5620696F.7050406@linux.intel.com>
2015-10-16 18:22 ` Laszlo Ersek
2015-09-21 8:23 ` Janusz
2015-09-22 8:59 ` Paolo Bonzini
2015-09-22 10:29 ` Janusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DD2EC.5040800@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=edk2-devel@ml01.01.org \
--cc=januszmk6@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.