All of lore.kernel.org
 help / color / mirror / Atom feed
From: tom.ty89@gmail.com
To: patch@alsa-project.org
Cc: alsa-devel@alsa-project.org, Tom Yan <tom.ty89@gmail.com>
Subject: [PATCH - a52 plugin 1/1] fix reported input channel order
Date: Tue, 12 Jan 2016 15:57:39 +0800	[thread overview]
Message-ID: <5694b1fa.8a41620a.6c971.ffffd9ad@mx.google.com> (raw)

From: Tom Yan <tom.ty89@gmail.com>

a52 plugin expects the input to be in ALSA order and remaps it to general order when encoding. However it reports that the input it takes should be in general order.

This fix should make programs (e.g. mpv) that is aware of channel layout reported by ALSA remap sources appropriately before sending when necessary.

It should not cause any regression to programs (e.g. mplayer) that does not check the reported channel layout (hence not affected by the issue) and remaps sources anyway.

Signed-off-by: Tom Yan <tom.ty89@gmail.com>

diff --git a/a52/pcm_a52.c b/a52/pcm_a52.c
index 4e4c5f7..88529eb 100644
--- a/a52/pcm_a52.c
+++ b/a52/pcm_a52.c
@@ -663,8 +663,8 @@ static unsigned int chmap4[4] = {
 };
 static unsigned int chmap6[6] = {
 	SND_CHMAP_FL, SND_CHMAP_FR,
-	SND_CHMAP_FC, SND_CHMAP_LFE,
 	SND_CHMAP_RL, SND_CHMAP_RR,
+	SND_CHMAP_FC, SND_CHMAP_LFE,
 };
 
 static snd_pcm_chmap_query_t **a52_query_chmaps(snd_pcm_ioplug_t *io ATTRIBUTE_UNUSED)
-- 
2.7.0

             reply	other threads:[~2016-01-12  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  7:57 tom.ty89 [this message]
2016-01-12  8:48 ` [PATCH - a52 plugin 1/1] fix reported input channel order Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5694b1fa.8a41620a.6c971.ffffd9ad@mx.google.com \
    --to=tom.ty89@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.