[Qemu-devel] [PATCH 25/51] paaudio: fix playback glitches

From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Kővágó, Zoltán" <dirty.ice.hu@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	qemu-devel@nongnu.org
Subject: [Qemu-devel]  [PATCH 25/51] paaudio: fix playback glitches
Date: Sun, 17 Jan 2016 10:32:10 +0100	[thread overview]
Message-ID: <569B5F9A.5090005@t-online.de> (raw)

Hi,

a better way to fix the playback glitches is to use a bigger playback
buffer on pulseaudio server side. I suggest you replace your patch with
a patch like this one:

diff --git a/audio/paaudio.c b/audio/paaudio.c
index fea6071..8bd5b91 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -554,7 +554,7 @@ static int qpa_init_out(HWVoiceOut *hw, struct audsettings *as,
      * qemu audio tick runs at 100 Hz (by default), so processing
      * data chunks worth 10 ms of sound should be a good fit.
      */
-    ba.tlength = pa_usec_to_bytes (10 * 1000, &ss);
+    ba.tlength = pa_usec_to_bytes (50 * 1000, &ss);
     ba.minreq = pa_usec_to_bytes (5 * 1000, &ss);
     ba.maxlength = -1;
     ba.prebuf = -1;

I tested your patch and while it really improves audio playback, I
still notice audio drop-outs. With my suggestion I experience no
playback glitches.

Regards,
Volker
