From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org
Subject: [PATCH] usbhid: replace inappropriate ENOSYS with ENODEV
Date: Wed, 20 Jan 2016 22:56:28 +0100 [thread overview]
Message-ID: <56A0028C.9080308@gmail.com> (raw)
Primary meaning of ENOSYS is "system call not available" but it's also used
with meaning "function not implemented". Both are not applicable here.
Typically this error occurs when the device was unplugged.
usbhid_raw_request returns -ENODEV in such a case what seems to be more
reasonable. Therefore use -ENODEV also here.
Primary motivation for this change is a change in the LED subsystem to
ignore -ENODEV if the device was most likely unplugged.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/hid/usbhid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index ad71160..64a8d9c 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -928,7 +928,7 @@ static int usbhid_output_report(struct hid_device *hid, __u8 *buf, size_t count)
int actual_length, skipped_report_id = 0, ret;
if (!usbhid->urbout)
- return -ENOSYS;
+ return -ENODEV;
if (buf[0] == 0x0) {
/* Don't send the Report ID */
--
2.7.0
next reply other threads:[~2016-01-20 21:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 21:56 Heiner Kallweit [this message]
2016-01-21 14:18 ` [PATCH] usbhid: replace inappropriate ENOSYS with ENODEV Jiri Kosina
2016-01-21 17:42 ` Dmitry Torokhov
2016-01-22 23:30 ` Jiri Kosina
2016-01-22 23:35 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0028C.9080308@gmail.com \
--to=hkallweit1@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.