All of lore.kernel.org
 help / color / mirror / Atom feed
From: tom.ty89@gmail.com
To: patch@alsa-project.org
Cc: alsa-devel@alsa-project.org, Tom Yan <tom.ty89@gmail.com>
Subject: [PATCH - alsactl 1/1] make systemd service start in proper way
Date: Sun, 24 Jan 2016 08:30:23 +0800	[thread overview]
Message-ID: <56a41b26.5908620a.ff61a.6c10@mx.google.com> (raw)

From: Tom Yan <tom.ty89@gmail.com>

Use sound.target to trigger the service, which is the proper way
to start a service related to sound card. This also makes sure that
the service will only start if a sound card exists in the system.

basic.target is too early for either of the service:
1. alsa-state.service will spam "No soundcards found" on every boot
2. alsa-restore.service will never start because of
   "ConditionPathExistsGlob=/dev/snd/control*"

"After=sysinit.target" is removed from alsa-state.service because it
never made any sense.

"After=alsa-state.service" is removed from alsa-restore.service because
it is completely unnecessary with the daemon conf switch.

Now either of serivce is enough to manage the state all by itself without
the udev rules if only ONE sound card exists in the system, while the rules
are still necessary in system with multiple sound cards.

"StandardOutput=syslog" is also removed from alsa-restore.service because it
makes little sense (if it has ever switched the behaviour away from default).

Signed-off-by: Tom Yan <tom.ty89@gmail.com>

diff --git a/alsactl/Makefile.am b/alsactl/Makefile.am
index cac8094..90fab9d 100644
--- a/alsactl/Makefile.am
+++ b/alsactl/Makefile.am
@@ -29,8 +29,8 @@ systemdsystemunit_DATA = \
 
 install-data-hook:
 	$(MKDIR_P) -m 0755 \
-		$(DESTDIR)$(systemdsystemunitdir)/basic.target.wants
-	( cd $(DESTDIR)$(systemdsystemunitdir)/basic.target.wants && \
+		$(DESTDIR)$(systemdsystemunitdir)/sound.target.wants
+	( cd $(DESTDIR)$(systemdsystemunitdir)/sound.target.wants && \
 		rm -f alsa-state.service alsa-restore.service && \
 		$(LN_S) ../alsa-state.service alsa-state.service && \
 		$(LN_S) ../alsa-restore.service alsa-restore.service)
diff --git a/alsactl/alsa-restore.service.in b/alsactl/alsa-restore.service.in
index 2884098..fbcf983 100644
--- a/alsactl/alsa-restore.service.in
+++ b/alsactl/alsa-restore.service.in
@@ -6,12 +6,9 @@
 [Unit]
 Description=Save/Restore Sound Card State
 ConditionPathExists=!@daemonswitch@
-ConditionPathExistsGlob=/dev/snd/control*
-After=alsa-state.service
 
 [Service]
 Type=oneshot
 RemainAfterExit=true
 ExecStart=-@sbindir@/alsactl restore
 ExecStop=-@sbindir@/alsactl store
-StandardOutput=syslog
diff --git a/alsactl/alsa-state.service.in b/alsactl/alsa-state.service.in
index f1321d6..5a8fe5e 100644
--- a/alsactl/alsa-state.service.in
+++ b/alsactl/alsa-state.service.in
@@ -6,7 +6,6 @@
 [Unit]
 Description=Manage Sound Card State (restore and store)
 ConditionPathExists=@daemonswitch@
-After=sysinit.target
 
 [Service]
 Type=simple
-- 
2.7.0

             reply	other threads:[~2016-01-24  0:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24  0:30 tom.ty89 [this message]
2016-01-24  7:56 ` [PATCH - alsactl 1/1] make systemd service start in proper way Takashi Iwai
2016-01-24 10:48   ` Tom Yan
2016-01-24 11:32     ` Takashi Iwai
2016-01-24 12:57       ` Tom Yan
2016-01-24 20:49         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56a41b26.5908620a.ff61a.6c10@mx.google.com \
    --to=tom.ty89@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=patch@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.