All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: jzh Chang <changjzh@gmail.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Paul Durrant <paul.durrant@citrix.com>,
	Keir Fraser <keir@xen.org>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] x86/HVM: fix forwarding of internally cached requests
Date: Thu, 21 Apr 2016 08:19:04 -0600	[thread overview]
Message-ID: <5718FD7802000078000E4613@prv-mh.provo.novell.com> (raw)
In-Reply-To: <CAPYBitb7Qo_ZDh9g88AcPRv6w__ROD+JpENf4X2+F5dKtcAe3w@mail.gmail.com>

>>> On 30.03.16 at 09:28, <changjzh@gmail.com> wrote:
> 2016-03-29 18:39 GMT+08:00 Jan Beulich <JBeulich@suse.com>:
>> ---
>> I assume this also addresses the issue which
>> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg03189.html 
>> attempted to deal with in a not really acceptable way.
>
> I hope this issue is resolved, but it still exists.

Mind giving the small below patch a try?

Jan

--- unstable.orig/xen/arch/x86/msi.c
+++ unstable/xen/arch/x86/msi.c
@@ -430,8 +430,13 @@ static bool_t msi_set_mask_bit(struct ir
         {
             writel(flag, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
             readl(entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET);
+
             if ( likely(control & PCI_MSIX_FLAGS_ENABLE) )
                 break;
+
+            entry->msi_attrib.host_masked = host;
+            entry->msi_attrib.guest_masked = guest;
+
             flag = 1;
         }
         else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) )



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-04-21 14:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29 10:39 [PATCH v2] x86/HVM: fix forwarding of internally cached requests Jan Beulich
2016-03-29 10:43 ` Paul Durrant
2016-03-30  7:28 ` jzh Chang
2016-04-21  6:24   ` Jan Beulich
     [not found]     ` <CAPYBitZG=5R0jyHhn5ksa4eGPGtLocFApj1am-DyDUXp5i_6HA@mail.gmail.com>
2016-04-21  8:08       ` Jan Beulich
2016-04-21 14:19   ` Jan Beulich [this message]
2016-04-22  2:02     ` jzh Chang
2016-04-22  7:17       ` Jan Beulich
2016-04-25  8:40         ` Li, Liang Z
2016-04-25  8:54           ` Xu, Quan
2016-04-28 15:13           ` Jan Beulich
2016-04-28 16:11             ` Xu, Quan
2016-05-03 12:50               ` Xu, Quan
2016-05-03 13:38                 ` Jan Beulich
2016-05-04  8:07                   ` Xu, Quan
2016-05-19  8:30             ` Xu, Quan
2016-05-19  9:15               ` Jan Beulich
2016-05-19 14:35                 ` Xu, Quan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5718FD7802000078000E4613@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=changjzh@gmail.com \
    --cc=keir@xen.org \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.