From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
willy@linux.intel.com
Subject: Re: Build regressions/improvements in v4.0-rc1
Date: Mon, 23 Feb 2015 11:24:46 +0100 [thread overview]
Message-ID: <5721217.aGU5oqfDWo@wuerfel> (raw)
In-Reply-To: <CAMuHMdVMCvw1euM0c2AYrYibO4ObZLV6F_-CDPZZ6x44D6Hwug@mail.gmail.com>
On Monday 23 February 2015 10:14:55 Geert Uytterhoeven wrote:
> On Mon, Feb 23, 2015 at 10:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > + /home/kisskb/slave/src/fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2
> >
> > DAX support was merged with 'depends on !(ARM || MIPS || SPARC)', so I don't
> > see how this could happen.
>
> sh is not ARM, not MIPS, not SPARC, so...?
I misread your email and thought this was still under arm-randconfig.
I checked the other architectures, and found that the same is missing on
ARC, so we should add both:
diff --git a/fs/Kconfig b/fs/Kconfig
index ec35851e5b71..a24d496787d6 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -36,7 +36,7 @@ source "fs/nilfs2/Kconfig"
config FS_DAX
bool "Direct Access (DAX) support"
depends on MMU
- depends on !(ARM || MIPS || SPARC)
+ depends on !(ARC || ARM || MIPS || SH || SPARC)
help
Direct Access (DAX) can be used on memory-backed block devices.
If the block device supports DAX and the filesystem supports DAX,
It's also not implemented on c6x and blackfin, but both of them have
MMU=n, so they are already excluded.
> >> sh-randconfig
>
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]: => 55:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_direction_output' [-Werror=implicit-function-declaration]: => 61:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]: => 30:3
> >
> > Something wrong in arch/sh/include/asm/gpio.h? the codec is only
> > selectable when gpiolib is enabled, but the consumer.h header
> > apparently does not get included here.
>
> I think it's an bad select, for which a patch has been available since
> about 2 weeks.
Ah, right. I was looking at linux-next, which has the fix, so I did not
see the problem at first.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: willy@linux.intel.com,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: Build regressions/improvements in v4.0-rc1
Date: Mon, 23 Feb 2015 11:24:46 +0100 [thread overview]
Message-ID: <5721217.aGU5oqfDWo@wuerfel> (raw)
In-Reply-To: <CAMuHMdVMCvw1euM0c2AYrYibO4ObZLV6F_-CDPZZ6x44D6Hwug@mail.gmail.com>
On Monday 23 February 2015 10:14:55 Geert Uytterhoeven wrote:
> On Mon, Feb 23, 2015 at 10:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > + /home/kisskb/slave/src/fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2
> >
> > DAX support was merged with 'depends on !(ARM || MIPS || SPARC)', so I don't
> > see how this could happen.
>
> sh is not ARM, not MIPS, not SPARC, so...?
I misread your email and thought this was still under arm-randconfig.
I checked the other architectures, and found that the same is missing on
ARC, so we should add both:
diff --git a/fs/Kconfig b/fs/Kconfig
index ec35851e5b71..a24d496787d6 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -36,7 +36,7 @@ source "fs/nilfs2/Kconfig"
config FS_DAX
bool "Direct Access (DAX) support"
depends on MMU
- depends on !(ARM || MIPS || SPARC)
+ depends on !(ARC || ARM || MIPS || SH || SPARC)
help
Direct Access (DAX) can be used on memory-backed block devices.
If the block device supports DAX and the filesystem supports DAX,
It's also not implemented on c6x and blackfin, but both of them have
MMU=n, so they are already excluded.
> >> sh-randconfig
>
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]: => 55:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_direction_output' [-Werror=implicit-function-declaration]: => 61:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]: => 30:3
> >
> > Something wrong in arch/sh/include/asm/gpio.h? the codec is only
> > selectable when gpiolib is enabled, but the consumer.h header
> > apparently does not get included here.
>
> I think it's an bad select, for which a patch has been available since
> about 2 weeks.
Ah, right. I was looking at linux-next, which has the fix, so I did not
see the problem at first.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: Build regressions/improvements in v4.0-rc1
Date: Mon, 23 Feb 2015 11:24:46 +0100 [thread overview]
Message-ID: <5721217.aGU5oqfDWo@wuerfel> (raw)
In-Reply-To: <CAMuHMdVMCvw1euM0c2AYrYibO4ObZLV6F_-CDPZZ6x44D6Hwug@mail.gmail.com>
On Monday 23 February 2015 10:14:55 Geert Uytterhoeven wrote:
> On Mon, Feb 23, 2015 at 10:03 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> >> > + /home/kisskb/slave/src/fs/dax.c: error: implicit declaration of function 'copy_user_page' [-Werror=implicit-function-declaration]: => 266:2
> >
> > DAX support was merged with 'depends on !(ARM || MIPS || SPARC)', so I don't
> > see how this could happen.
>
> sh is not ARM, not MIPS, not SPARC, so...?
I misread your email and thought this was still under arm-randconfig.
I checked the other architectures, and found that the same is missing on
ARC, so we should add both:
diff --git a/fs/Kconfig b/fs/Kconfig
index ec35851e5b71..a24d496787d6 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -36,7 +36,7 @@ source "fs/nilfs2/Kconfig"
config FS_DAX
bool "Direct Access (DAX) support"
depends on MMU
- depends on !(ARM || MIPS || SPARC)
+ depends on !(ARC || ARM || MIPS || SH || SPARC)
help
Direct Access (DAX) can be used on memory-backed block devices.
If the block device supports DAX and the filesystem supports DAX,
It's also not implemented on c6x and blackfin, but both of them have
MMU=n, so they are already excluded.
> >> sh-randconfig
>
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'devm_gpiod_get' [-Werror=implicit-function-declaration]: => 55:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_direction_output' [-Werror=implicit-function-declaration]: => 61:2
> >> > + /home/kisskb/slave/src/sound/soc/codecs/max98357a.c: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]: => 30:3
> >
> > Something wrong in arch/sh/include/asm/gpio.h? the codec is only
> > selectable when gpiolib is enabled, but the consumer.h header
> > apparently does not get included here.
>
> I think it's an bad select, for which a patch has been available since
> about 2 weeks.
Ah, right. I was looking at linux-next, which has the fix, so I did not
see the problem at first.
Arnd
next prev parent reply other threads:[~2015-02-23 10:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 8:33 Build regressions/improvements in v4.0-rc1 Geert Uytterhoeven
2015-02-23 8:45 ` Geert Uytterhoeven
2015-02-23 8:45 ` Geert Uytterhoeven
2015-02-23 8:45 ` Geert Uytterhoeven
2015-02-23 8:45 ` Geert Uytterhoeven
2015-02-23 9:03 ` Arnd Bergmann
2015-02-23 9:03 ` Arnd Bergmann
2015-02-23 9:03 ` Arnd Bergmann
2015-02-23 9:14 ` Geert Uytterhoeven
2015-02-23 9:14 ` Geert Uytterhoeven
2015-02-23 9:14 ` Geert Uytterhoeven
2015-02-23 9:14 ` Geert Uytterhoeven
2015-02-23 10:24 ` Arnd Bergmann [this message]
2015-02-23 10:24 ` Arnd Bergmann
2015-02-23 10:24 ` Arnd Bergmann
2015-02-23 10:24 ` Arnd Bergmann
2015-02-23 10:28 ` Geert Uytterhoeven
2015-02-23 10:28 ` Geert Uytterhoeven
2015-02-23 10:28 ` Geert Uytterhoeven
2015-02-23 10:28 ` Geert Uytterhoeven
2015-02-23 11:24 ` Arnd Bergmann
2015-02-23 11:24 ` Arnd Bergmann
2015-02-23 11:24 ` Arnd Bergmann
2015-02-23 11:24 ` Arnd Bergmann
2015-02-24 4:52 ` Michael Ellerman
2015-02-24 4:52 ` Michael Ellerman
2015-02-24 9:38 ` Geert Uytterhoeven
2015-02-24 9:38 ` Geert Uytterhoeven
2015-02-25 2:44 ` Michael Ellerman
2015-02-25 2:44 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721217.aGU5oqfDWo@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.