All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>, Arnd Bergmann <arnd@arndb.de>
Cc: <bcousson@baylibre.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <linux@armlinux.org.uk>,
	<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<nsekhar@ti.com>
Subject: Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Date: Fri, 22 Jul 2016 13:56:47 +0530	[thread overview]
Message-ID: <5791D8C7.5020303@ti.com> (raw)
In-Reply-To: <20160722071644.GZ28140@atomide.com>

Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>>         select OMAP_INTERCONNECT_BARRIER
>>>         select PM_OPP if PM
>>>         select ZONE_DMA if ARM_LPAE
>>> +       select PCI_DOMAINS if PCI
>>>  
>>>  config ARCH_OMAP2PLUS
>>>         bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
> 
> Makes sense to me if many SoCs need this.

since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

Thanks
Kishon

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>, Arnd Bergmann <arnd@arndb.de>
Cc: bcousson@baylibre.com, robh+dt@kernel.org, mark.rutland@arm.com,
	linux@armlinux.org.uk, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	nsekhar@ti.com
Subject: Re: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Date: Fri, 22 Jul 2016 13:56:47 +0530	[thread overview]
Message-ID: <5791D8C7.5020303@ti.com> (raw)
In-Reply-To: <20160722071644.GZ28140@atomide.com>

Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>>         select OMAP_INTERCONNECT_BARRIER
>>>         select PM_OPP if PM
>>>         select ZONE_DMA if ARM_LPAE
>>> +       select PCI_DOMAINS if PCI
>>>  
>>>  config ARCH_OMAP2PLUS
>>>         bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
> 
> Makes sense to me if many SoCs need this.

since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

Thanks
Kishon

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config
Date: Fri, 22 Jul 2016 13:56:47 +0530	[thread overview]
Message-ID: <5791D8C7.5020303@ti.com> (raw)
In-Reply-To: <20160722071644.GZ28140@atomide.com>

Hi,

On Friday 22 July 2016 12:46 PM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [160721 05:08]:
>> On Thursday, July 21, 2016 5:27:56 PM CEST Kishon Vijay Abraham I wrote:
>>> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
>>> index 1a648e9..8e6e2c0 100644
>>> --- a/arch/arm/mach-omap2/Kconfig
>>> +++ b/arch/arm/mach-omap2/Kconfig
>>> @@ -86,6 +86,7 @@ config SOC_DRA7XX
>>>         select OMAP_INTERCONNECT_BARRIER
>>>         select PM_OPP if PM
>>>         select ZONE_DMA if ARM_LPAE
>>> +       select PCI_DOMAINS if PCI
>>>  
>>>  config ARCH_OMAP2PLUS
>>>         bool
>>>
>>
>> Should we just set this unconditionally for ARCH_MULTIPLATFORM maybe?
> 
> Makes sense to me if many SoCs need this.

since it doesn't harm even if a platform has a single PCIe port, it should be
okay to set PCI_DOMAINS. I'll resend the following as a separate patch if it's
okay.

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 90542db..0cccb50 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -338,6 +338,7 @@ config ARCH_MULTIPLATFORM
        select MULTI_IRQ_HANDLER
        select SPARSE_IRQ
        select USE_OF
+       select PCI_DOMAINS if PCI

 config ARM_SINGLE_ARMV7M
        bool "ARMv7-M based platforms (Cortex-M0/M3/M4)"

Thanks
Kishon

  reply	other threads:[~2016-07-22  8:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21 11:57 [PATCH 0/2] dra7: add support for two PCIe ports Kishon Vijay Abraham I
2016-07-21 11:57 ` Kishon Vijay Abraham I
2016-07-21 11:57 ` Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 1/2] ARM: dts: DRA7: Add "linux,pci-domain" property for pci dt nodes Kishon Vijay Abraham I
2016-07-21 11:57   ` [PATCH 1/2] ARM: dts: DRA7: Add "linux, pci-domain" " Kishon Vijay Abraham I
2016-07-21 11:57   ` [PATCH 1/2] ARM: dts: DRA7: Add "linux,pci-domain" " Kishon Vijay Abraham I
2016-07-21 11:57 ` [PATCH 2/2] ARM: DRA7: select PCI_DOMAINS config Kishon Vijay Abraham I
2016-07-21 11:57   ` Kishon Vijay Abraham I
2016-07-21 11:57   ` Kishon Vijay Abraham I
2016-07-21 12:04   ` Arnd Bergmann
2016-07-21 12:04     ` Arnd Bergmann
2016-07-22  7:16     ` Tony Lindgren
2016-07-22  7:16       ` Tony Lindgren
2016-07-22  8:26       ` Kishon Vijay Abraham I [this message]
2016-07-22  8:26         ` Kishon Vijay Abraham I
2016-07-22  8:26         ` Kishon Vijay Abraham I
2016-07-22  9:23         ` Sekhar Nori
2016-07-22  9:23           ` Sekhar Nori
2016-07-22  9:23           ` Sekhar Nori
2016-07-22 13:29         ` Arnd Bergmann
2016-07-22 13:29           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5791D8C7.5020303@ti.com \
    --to=kishon@ti.com \
    --cc=arnd@arndb.de \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.