All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 2/2] hvmloader: drop pointless objcopy invocation
Date: Wed, 31 May 2017 01:38:13 -0600	[thread overview]
Message-ID: <592E8F05020000780015E032@prv-mh.provo.novell.com> (raw)
In-Reply-To: <592E8C92020000780015E014@prv-mh.provo.novell.com>

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

It doesn't alter the image in any way.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -84,9 +84,7 @@ vpath static_tables.c $(ACPI_PATH)
 OBJS += $(ACPI_OBJS)
 
 hvmloader: $(OBJS)
-	$(LD) $(LDFLAGS_DIRECT) -N -Ttext $(LOADADDR) -o hvmloader.tmp $^
-	$(OBJCOPY) hvmloader.tmp hvmloader
-	rm -f hvmloader.tmp
+	$(LD) $(LDFLAGS_DIRECT) -N -Ttext $(LOADADDR) -o $@ $^
 
 roms.inc: $(ROMS)
 	echo "/* Autogenerated file. DO NOT EDIT */" > $@.new




[-- Attachment #2: hvmloader-drop-objcopy.patch --]
[-- Type: text/plain, Size: 591 bytes --]

hvmloader: drop pointless objcopy invocation

It doesn't alter the image in any way.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/firmware/hvmloader/Makefile
+++ b/tools/firmware/hvmloader/Makefile
@@ -84,9 +84,7 @@ vpath static_tables.c $(ACPI_PATH)
 OBJS += $(ACPI_OBJS)
 
 hvmloader: $(OBJS)
-	$(LD) $(LDFLAGS_DIRECT) -N -Ttext $(LOADADDR) -o hvmloader.tmp $^
-	$(OBJCOPY) hvmloader.tmp hvmloader
-	rm -f hvmloader.tmp
+	$(LD) $(LDFLAGS_DIRECT) -N -Ttext $(LOADADDR) -o $@ $^
 
 roms.inc: $(ROMS)
 	echo "/* Autogenerated file. DO NOT EDIT */" > $@.new

[-- Attachment #3: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2017-05-31  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-31  7:27 [PATCH 0/2] hvmloader: misc adjustments Jan Beulich
2017-05-31  7:37 ` [PATCH 1/2] hvmloader: dynamically determine scratch memory range for tests Jan Beulich
2017-07-03 14:59   ` Ping: " Jan Beulich
2017-07-03 16:20   ` Andrew Cooper
2017-07-04  7:33     ` Jan Beulich
2017-05-31  7:38 ` Jan Beulich [this message]
2017-05-31 12:23   ` [PATCH 2/2] hvmloader: drop pointless objcopy invocation Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=592E8F05020000780015E032@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.