All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com, fstests@vger.kernel.org
Subject: [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit
Date: Mon, 22 Nov 2021 15:50:29 -0500	[thread overview]
Message-ID: <595829c06353ab12280513ab880bb742a2389bbe.1637614211.git.josef@toxicpanda.com> (raw)

A change to btrfs-progs uncovered a problem with btrfs/099, we weren't
specifying the qgroupid with the subvol id.  This technically worked
before but only by accident, and all other tests properly specify the
qgroupid for qgroup limit commands.  Fix this test to specify the
qgroupid, which will work with older versions of btrfs-progs and newer
ones as well.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 tests/btrfs/099 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/btrfs/099 b/tests/btrfs/099
index 375cc2b9..f3a2002a 100755
--- a/tests/btrfs/099
+++ b/tests/btrfs/099
@@ -29,7 +29,7 @@ _scratch_mount
 _require_fs_space $SCRATCH_MNT $(($FILESIZE * 2 / 1024))
 
 _run_btrfs_util_prog quota enable $SCRATCH_MNT
-_run_btrfs_util_prog qgroup limit $FILESIZE 5 $SCRATCH_MNT
+_run_btrfs_util_prog qgroup limit $FILESIZE 0/5 $SCRATCH_MNT
 
 # loop 5 times without sync to ensure reserved space leak will happen
 for i in `seq 1 5`; do
-- 
2.26.3


             reply	other threads:[~2021-11-22 20:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 20:50 Josef Bacik [this message]
2021-11-22 23:32 ` [PATCH] fstests: btrfs/099: use the qgroupid for qgroup limit Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=595829c06353ab12280513ab880bb742a2389bbe.1637614211.git.josef@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=fstests@vger.kernel.org \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.