All of lore.kernel.org
 help / color / mirror / Atom feed
From: Volker Lendecke <vl@samba.org>
To: linux-cifs@vger.kernel.org
Cc: Volker Lendecke <vl@samba.org>
Subject: [PATCH 6/7] cifs: Avoid a cast in add_durable_reconnect_v2_context()
Date: Fri, 17 Mar 2023 11:15:27 +0000	[thread overview]
Message-ID: <598f783f2701a596fe8e4bbadf2fa6d97edd91cd.1679051552.git.vl@samba.org> (raw)
In-Reply-To: <cover.1679051552.git.vl@samba.org>

We have the correctly-typed struct smb2_create_req * available in the
caller.

Signed-off-by: Volker Lendecke <vl@samba.org>
---
 fs/cifs/smb2pdu.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 6d4a14efa79f..9e9267da28a2 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -2261,10 +2261,10 @@ add_durable_v2_context(struct smb2_create_req *req,
 }
 
 static int
-add_durable_reconnect_v2_context(struct kvec *iov, unsigned int *num_iovec,
+add_durable_reconnect_v2_context(struct smb2_create_req *req,
+				 struct kvec *iov, unsigned int *num_iovec,
 		    struct cifs_open_parms *oparms)
 {
-	struct smb2_create_req *req = iov[0].iov_base;
 	unsigned int num = *num_iovec;
 
 	/* indicate that we don't need to relock the file */
@@ -2293,7 +2293,8 @@ add_durable_context(struct smb2_create_req *req,
 
 	if (use_persistent) {
 		if (oparms->reconnect)
-			return add_durable_reconnect_v2_context(iov, num_iovec,
+			return add_durable_reconnect_v2_context(req,
+								iov, num_iovec,
 								oparms);
 		else
 			return add_durable_v2_context(req, iov, num_iovec,
-- 
2.30.2


  parent reply	other threads:[~2023-03-17 11:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17 11:15 [PATCH 0/7] Avoid a few casts from void * Volker Lendecke
2023-03-17 11:15 ` [PATCH 1/7] cifs: Avoid a cast in add_lease_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 2/7] cifs: Avoid a cast in add_durable_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 3/7] cifs: Avoid a cast in add_posix_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 4/7] cifs: Avoid a cast in add_sd_context() Volker Lendecke
2023-03-17 11:15 ` [PATCH 5/7] cifs: Avoid a cast in add_durable_v2_context() Volker Lendecke
2023-03-17 11:15 ` Volker Lendecke [this message]
2023-03-17 11:15 ` [PATCH 7/7] cifs: Avoid a cast in add_query_id_context() Volker Lendecke
2023-03-27 14:56 ` [PATCH 0/7] Avoid a few casts from void * Ralph Boehme
2023-04-24  2:22 ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=598f783f2701a596fe8e4bbadf2fa6d97edd91cd.1679051552.git.vl@samba.org \
    --to=vl@samba.org \
    --cc=linux-cifs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.